Skip to content

Commit dfbfe47

Browse files
committed
cardano-node: Add missing comments
1 parent 07a8579 commit dfbfe47

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

cardano-node/src/Cardano/Node/Tracing/Tracers/LedgerMetrics.hs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ startLedgerMetricsTracer tr everyNThSlot nodeKernelData = do
5454
where
5555
ledgerMetricsThread :: IO ()
5656
ledgerMetricsThread = do
57-
myThreadId >>= flip labelThread "Peer Tracer"
57+
myThreadId >>= flip labelThread "Ledger Metrics"
5858
go 1 SNothing
5959
where
6060
go :: Int -> StrictMaybe SlotNo -> IO ()
@@ -83,6 +83,7 @@ data LedgerMetrics =
8383
tsSlotNo :: SlotNo
8484
, tsUtxoSize :: Int
8585
, tsDelegMapSize :: Int
86+
-- Temporarily disabled: uncomment after benchmarking and approval
8687
-- , tsDRepCount :: Int
8788
-- , tsDRepMapSize :: Int
8889
, tsChainDensity :: Double
@@ -105,6 +106,7 @@ traceLedgerMetrics nodeKern slotNo tracer = do
105106
(,,) -- (,,,,)
106107
<$> nkQueryLedger (ledgerUtxoSize . ledgerState) nk
107108
<*> nkQueryLedger (ledgerDelegMapSize . ledgerState) nk
109+
-- Temporarily disabled: uncomment after benchmarking and approval
108110
-- <*> nkQueryLedger (ledgerDRepCount . ledgerState) nk
109111
-- <*> nkQueryLedger (ledgerDRepMapSize . ledgerState) nk
110112
<*> nkQueryChain fragmentChainDensity nk)
@@ -116,6 +118,7 @@ traceLedgerMetrics nodeKern slotNo tracer = do
116118
slotNo
117119
utxoSize
118120
delegMapSize
121+
-- Temporarily disabled: uncomment after benchmarking and approval
119122
-- drepCount
120123
-- drepMapSize
121124
(fromRational chainDensity)
@@ -131,6 +134,7 @@ instance LogFormatting LedgerMetrics where
131134
, "slot" .= toJSON (unSlotNo tsSlotNo)
132135
, "utxoSize" .= Number (fromIntegral tsUtxoSize)
133136
, "delegMapSize" .= Number (fromIntegral tsDelegMapSize)
137+
-- Temporarily disabled: uncomment after benchmarking and approval
134138
-- , "drepCount" .= Number (fromIntegral tsDRepCount)
135139
-- , "drepMapSize" .= Number (fromIntegral tsDRepMapSize)
136140
, "chainDensity" .= Number (fromRational (toRational tsChainDensity))
@@ -139,12 +143,14 @@ instance LogFormatting LedgerMetrics where
139143
"Ledger metrics "
140144
<> " utxoSize " <> showT tsUtxoSize
141145
<> " delegMapSize " <> showT tsDelegMapSize
146+
-- Temporarily disabled: uncomment after benchmarking and approval
142147
-- <> " drepCount" <> showT tsDRepCount
143148
-- <> " drepMapSize" <> showT tsDRepMapSize
144149
<> " chainDensity " <> showT tsChainDensity
145150
asMetrics LedgerMetrics {..} =
146151
[ IntM "utxoSize" (fromIntegral tsUtxoSize)
147152
, IntM "delegMapSize" (fromIntegral tsDelegMapSize)
153+
-- Temporarily disabled: uncomment after benchmarking and approval
148154
-- , IntM "drepCount" (fromIntegral tsDRepCount)
149155
-- , IntM "drepMapSize" (fromIntegral tsDRepMapSize)
150156
]
@@ -158,6 +164,7 @@ instance MetaTrace LedgerMetrics where
158164
metricsDocFor (Namespace _ ["LedgerMetrics"]) =
159165
[ ("utxoSize", "Size of the current UTxO set (number of entries)")
160166
, ("delegMapSize", "Size of the delegation map (number of delegators)")
167+
-- Temporarily disabled: uncomment after benchmarking and approval
161168
-- , ("drepCount", "Number of active DReps (Delegated Representatives)")
162169
-- , ("drepMapSize", "Size of the DRep map (number of stake keys mapped to DReps)")
163170
]
@@ -174,7 +181,8 @@ instance MetaTrace LedgerMetrics where
174181

175182
allNamespaces = [Namespace [] ["LedgerMetrics"]]
176183

177-
184+
-- NOTE: DRep-related fields are currently excluded from logs until benchmarked
185+
-- and confirmed for production readiness.
178186

179187

180188

0 commit comments

Comments
 (0)