cardano-node: ledger metrics without thread delay and fixes

Author: jutaro

cardano-node/src/Cardano/Node/Tracing/Tracers/Consensus.hs

@@ -69,7 +69,6 @@ import           Ouroboros.Network.TxSubmission.Inbound hiding (txId)
 import           Ouroboros.Network.TxSubmission.Outbound
 
 import           Control.Monad (guard)
-import           Control.Monad.Class.MonadTime.SI (Time (..))
 import           Data.Aeson (ToJSON, Value (..), toJSON, (.=))
 import qualified Data.Aeson as Aeson
 import           Data.Foldable (Foldable (toList))

cardano-node/src/Cardano/Node/Tracing/Tracers/LedgerMetrics.hs

@@ -35,7 +35,7 @@ import           Control.Monad.STM (atomically, retry)
 import           "contra-tracer" Control.Tracer (Tracer, traceWith)
 import           Data.Aeson (Value (Number, String), toJSON, (.=))
 import           Data.Text as Text
-import           GHC.Conc (labelThread, myThreadId, unsafeIOToSTM)
+import           GHC.Conc (labelThread, myThreadId)
 
 startLedgerMetricsTracer
   :: forall blk
@@ -75,9 +75,7 @@ startLedgerMetricsTracer tr everyNThSlot nodeKernelData = do
             mSlot <- getCurrentSlot (getBlockchainTime nk)
             case mSlot of
               CurrentSlot s' | SJust s' /= prev -> return s'
-              _ -> do
-                    unsafeIOToSTM ( threadDelay $ 1 * 1000)
-                    retry
+              _ -> retry
             ) nodeKernelData
 
 data LedgerMetrics =

cardano-node/src/Cardano/Node/Tracing/Tracers/Resources.hs

@@ -10,13 +10,12 @@ import           Control.Concurrent (threadDelay)
 import           Control.Concurrent.Async (async)
 import           Control.Monad (forM_, forever)
 import           Control.Monad.Class.MonadAsync (link)
-import           GHC.Conc (labelThread, myThreadId)
 import           "contra-tracer" Control.Tracer
+import           GHC.Conc (labelThread, myThreadId)
 
 -- | Starts a background thread to periodically trace resource statistics.
 -- The thread reads resource stats and traces them using the given tracer.
 -- It is linked to the parent thread to ensure proper error propagation.
-startResourceTracer :: Tracer IO ResourceStats -> Int -> IO ()
 startResourceTracer
   :: Tracer IO ResourceStats
   -> Int