Interrupt cardano nodes when cardano-testnet gets interrupted
#6240
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
requested changes
Jun 5, 2025
nbacquey
force-pushed
the
nb/interrupt_nodes
branch
2 times, most recently
from
e1bed50 to
ab3b54e
Compare
carbolymer
reviewed
Jun 5, 2025
| @@ -1,4 +1,5 @@ | |||
| {-# LANGUAGE BangPatterns #-} | |||
| {-# LANGUAGE CPP #-} | |||
There was a problem hiding this comment.
You solution is correct IMO. One small thing: depending on CPP breaks code formatters (both stylish and fourmolu give up). So from developer experience it is a bit annoying. So can I ask you to create a separate haskell module which uses CPP extension and conditionally installs the handler?
There was a problem hiding this comment.
Done in latest commit
nbacquey
force-pushed
the
nb/interrupt_nodes
branch
2 times, most recently
from
1639b00 to
6e2b121
Compare
nbacquey
force-pushed
the
nb/interrupt_nodes
branch
3 times, most recently
from
3d40313 to
80f42b0
Compare
nbacquey
force-pushed
the
nb/interrupt_nodes
branch
from
80f42b0 to
6dad4e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the nodes spun up by
cardano-testnetwere not interrupted when said testnet was interrupted (the normal way) by receiving SIGINT.Checklist
hlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.