Skip to content

Genesis test failure: restarting the mocked node is too slow #1450

Open
@nfrisby

Description

@nfrisby

The "hopefully" and the "promptly" in this comment

-- Killing the peer overview threads should hopefully clean up all connections promptly
are incorrect.

$ git lg -1
99e49deff - (HEAD, origin/main, origin/HEAD) Add version `0.5` and its publishing date to the `utxo-db-api` doc (#1438) (21 hours ago) <Joris Dral>
$ cabal run ouroboros-consensus-diffusion:test:consensus-test -- --quickcheck-tests=1 --quickcheck-replay='(SMGen 52839424461818769 12444177963069598431,2)' -p '/the node is shut down and restarted after some time/' --quickcheck-shrinks=10000000

Inspecting that trace, I see that the wall clock advances a lot while the node is restarting, and so the ticks' timestamps and the wall clock seem to be out of sync.

I didn't dig enough to know why that's happening or exactly why it's leading to the test failure, but it is already evidence of a problem with the implementation of that test.

(Clarification: it does not block the first release of Genesis as an experimental feature.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    GenesisPRs related to Genesis testing and implementation

    Type

    No type

    Projects

    Status

    🔖 Ready

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions