Skip to content

Commit fdf5d83

Browse files
author
IMS212
committed
Merge branch '1.17' into 1.18
2 parents d58dc6d + c4d09c7 commit fdf5d83

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/main/java/net/coderbot/iris/pipeline/newshader/NewWorldRenderingPipeline.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,8 @@ public void finalizeLevelRendering() {
581581

582582
@Override
583583
public boolean shouldDisableVanillaEntityShadows() {
584-
return true;
584+
// OptiFine seems to disable vanilla shadows when the shaderpack uses shadow mapping?
585+
return shadowMapRenderer instanceof ShadowRenderer;
585586
}
586587

587588
@Override

src/sodiumCompatibility/java/net/coderbot/iris/compat/sodium/mixin/IrisSodiumCompatMixinPlugin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package net.coderbot.iris.compat.sodium.mixin;
22

3-
import net.coderbot.iris.Iris;
43
import net.coderbot.iris.compat.sodium.SodiumVersionCheck;
54
import net.fabricmc.loader.api.FabricLoader;
65
import org.objectweb.asm.tree.ClassNode;
@@ -22,7 +21,8 @@ public void onLoad(String mixinPackage) {
2221
}).orElse(false);
2322

2423
if (!validSodiumVersion) {
25-
Iris.logger.error("Invalid/missing version of Sodium detected, disabling compatibility mixins!");
24+
// We can't use Iris' logger here due to classloading issues.
25+
System.err.println("[Iris] Invalid/missing version of Sodium detected, disabling compatibility mixins!");
2626
}
2727
}
2828

0 commit comments

Comments
 (0)