Use simplified new() form for field initialization (#289)

Author: BCSharp

Src/Microsoft.Dynamic/Actions/Argument.cs

@@ -16,7 +16,7 @@ public struct Argument : IEquatable<Argument> {
         private readonly ArgumentType _kind;
         private readonly string _name;
 
-        public static readonly Argument Simple = new Argument(ArgumentType.Simple, null);
+        public static readonly Argument Simple = new(ArgumentType.Simple, null);
 
         public ArgumentType Kind => _kind;
         public string Name => _name;

Src/Microsoft.Dynamic/Actions/Calls/DefaultOverloadResolver.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
@@ -37,7 +37,7 @@ public class DefaultOverloadResolver : OverloadResolver {
         private readonly CallSignature _signature;
         private readonly CallTypes _callType;
         private DynamicMetaObject _invalidSplattee;
-        private static readonly DefaultOverloadResolverFactory _factory = new DefaultOverloadResolverFactory(DefaultBinder.Instance);
+        private static readonly DefaultOverloadResolverFactory _factory = new(DefaultBinder.Instance);
 
         // instance method call:
         public DefaultOverloadResolver(ActionBinder binder, DynamicMetaObject instance, IList<DynamicMetaObject> args, CallSignature signature)

Src/Microsoft.Dynamic/Actions/Calls/TypeInferer.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
@@ -344,8 +344,8 @@ private static void CollectGenericParameters(Type type, List<Type> containedGenA
         /// z would be a ConstructedParameterInferer.
         /// </summary>
         private class ArgumentInputs {
-            private readonly List<Type>/*!*/ _parameterTypes = new List<Type>();
-            private readonly List<DynamicMetaObject>/*!*/ _inputs = new List<DynamicMetaObject>();
+            private readonly List<Type>/*!*/ _parameterTypes = new();
+            private readonly List<DynamicMetaObject>/*!*/ _inputs = new();
             private readonly Type/*!*/ _genericParam;
 
             public ArgumentInputs(Type/*!*/ genericParam) {

Src/Microsoft.Dynamic/Actions/ConditionalBuilder.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
@@ -19,9 +19,9 @@ namespace Microsoft.Scripting.Actions {
     /// branch must be added.
     /// </summary>
     class ConditionalBuilder {
-        private readonly List<Expression> _conditions = new List<Expression>();
-        private readonly List<Expression> _bodies = new List<Expression>();
-        private readonly List<ParameterExpression> _variables = new List<ParameterExpression>();
+        private readonly List<Expression> _conditions = new();
+        private readonly List<Expression> _bodies = new();
+        private readonly List<ParameterExpression> _variables = new();
         private Expression _body;
         private bool _isError;
         private BindingRestrictions _restrictions = BindingRestrictions.Empty;

Src/Microsoft.Dynamic/Actions/DefaultBinder.DeleteMember.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
@@ -118,7 +118,7 @@ private bool MakeOperatorDeleteMemberBody(SetOrDeleteMemberInfo delInfo, Dynamic
         private sealed class SetOrDeleteMemberInfo {
             public readonly string Name;
             public readonly OverloadResolverFactory ResolutionFactory;
-            public readonly ConditionalBuilder Body = new ConditionalBuilder();
+            public readonly ConditionalBuilder Body = new();
 
             public SetOrDeleteMemberInfo(string name, OverloadResolverFactory resolutionFactory) {
                 Name = name;

Src/Microsoft.Dynamic/Actions/DefaultBinder.GetMember.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
@@ -387,7 +387,7 @@ private sealed class GetMemberInfo {
             public readonly string Name;
             public readonly OverloadResolverFactory ResolutionFactory;
             public readonly bool IsNoThrow;
-            public readonly ConditionalBuilder Body = new ConditionalBuilder();
+            public readonly ConditionalBuilder Body = new();
             public readonly DynamicMetaObject ErrorSuggestion;
 
             public GetMemberInfo(string name, OverloadResolverFactory resolutionFactory, bool noThrow, DynamicMetaObject errorSuggestion) {

Src/Microsoft.Dynamic/Actions/DefaultBinder.cs

@@ -23,7 +23,7 @@ namespace Microsoft.Scripting.Actions {
     /// </summary>
     [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Maintainability", "CA1506:AvoidExcessiveClassCoupling")]
     public partial class DefaultBinder : ActionBinder {
-        internal static readonly DefaultBinder Instance = new DefaultBinder();
+        internal static readonly DefaultBinder Instance = new();
 
         public override bool CanConvertFrom(Type fromType, Type toType, bool toNotNullable, NarrowingLevel level) {
             return toType.IsAssignableFrom(fromType);

Src/Microsoft.Dynamic/Actions/EventTracker.cs

@@ -23,7 +23,7 @@ public class EventTracker : MemberTracker {
         // Each pair in the list holds on the stub handler that was added to the event delegate chain and the callable 
         // object that is passed to +=/-= operators. 
         private WeakDictionary<object, NormalHandlerList> _handlerLists;
-        private static readonly object _staticTarget = new object();
+        private static readonly object _staticTarget = new();
 
         private readonly EventInfo _eventInfo;
         private MethodInfo _addMethod;
@@ -222,7 +222,7 @@ private sealed class ComHandlerList : HandlerList {
             /// <summary>
             /// Storage for the handlers - a key value pair of the callable object and the delegate handler.
             /// </summary>
-            private readonly CopyOnWriteList<KeyValuePair<object, object>> _handlers = new CopyOnWriteList<KeyValuePair<object, object>>();
+            private readonly CopyOnWriteList<KeyValuePair<object, object>> _handlers = new();
 
             public override void AddHandler(object callableObject, Delegate handler) {
                 Assert.NotNull(handler);
@@ -254,7 +254,7 @@ private sealed class NormalHandlerList : HandlerList {
             /// delegate will stay alive and so will the callable object.  That means it's fine to have a weak reference
             /// to both of these objects.
             /// </summary>
-            private readonly CopyOnWriteList<KeyValuePair<WeakReference, WeakReference>> _handlers = new CopyOnWriteList<KeyValuePair<WeakReference, WeakReference>>();
+            private readonly CopyOnWriteList<KeyValuePair<WeakReference, WeakReference>> _handlers = new();
 
             public override void AddHandler(object callableObject, Delegate handler) {
                 Assert.NotNull(handler);

Src/Microsoft.Dynamic/Actions/MemberGroup.cs

@@ -25,7 +25,7 @@ namespace Microsoft.Scripting.Actions {
     /// </summary>
     public class MemberGroup : IEnumerable<MemberTracker> {
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Security", "CA2104:DoNotDeclareReadOnlyMutableReferenceTypes")]
-        public static readonly MemberGroup EmptyGroup = new MemberGroup(MemberTracker.EmptyTrackers);
+        public static readonly MemberGroup EmptyGroup = new(MemberTracker.EmptyTrackers);
 
         private readonly MemberTracker[] _members;
 

Src/Microsoft.Dynamic/Actions/MemberTracker.cs

@@ -26,12 +26,12 @@ public abstract class MemberTracker {
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Security", "CA2105:ArrayFieldsShouldNotBeReadOnly")]
         public static readonly MemberTracker[] EmptyTrackers = Array.Empty<MemberTracker>();
 
-        private static readonly Dictionary<MemberKey, MemberTracker> _trackers = new Dictionary<MemberKey, MemberTracker>();
+        private static readonly Dictionary<MemberKey, MemberTracker> _trackers = new();
 
         /// <summary>
         /// We ensure we only produce one MemberTracker for each member which logically lives on the declaring type.  So 
         /// for example if you get a member from a derived class which is declared on the base class it should be the same 
-        /// as getting the member from the base class.  That’s easy enough until you get into extension members – here there
+        /// as getting the member from the base class.  That's easy enough until you get into extension members – here there
         /// might be one extension member which is being applied to multiple types.  Therefore we need to take into account the 
         /// extension type when ensuring that we only have 1 MemberTracker ever created.
         /// </summary>