review: some meaningful improvements (no)

Author: Irval1337

include/core/batch.h

@@ -11,7 +11,7 @@ class Batch {
 
     Batch(Schema schema) : schema_(std::move(schema)) {
         columns_.reserve(schema_.FieldsCount());
-        for(auto& field : schema_.GetFields()) {
+        for (auto& field : schema_.GetFields()) {
             columns_.emplace_back(MakeColumn(field.type, field.nullable));
         }
     }

include/core/columns/bool_column.h

@@ -66,6 +66,7 @@ class BoolColumn : public Column {
         if (nullable_) {
             AppendBit(is_null_, true);
         }
+        ++size_;
     }
 
     std::unique_ptr<Column> CloneEmpty() const override {

include/csv/csv_row_reader.h

@@ -81,7 +81,7 @@ class CSVRowReader {
                     in_quotes = true;
                     was_quoted = true;
                 } else if (c == '\n') {
-                    row.emplace_back(std::move(field), was_quoted);
+                    row.emplace_back(Field{std::move(field), was_quoted});
                     return row;
                 } else {
                     field += c;
@@ -90,7 +90,10 @@ class CSVRowReader {
         }
 
         if (!field.empty() || !row.empty()) {
-            row.emplace_back(std::move(field), was_quoted);
+            if (in_quotes) {
+                THROW_RUNTIME_ERROR("Got EOF inside the quotes");
+            }
+            row.emplace_back(Field{std::move(field), was_quoted});
             return row;
         }
         return std::nullopt;

include/csv/schema_reader.h

@@ -41,7 +41,7 @@ class SchemaManager {
     }
 
     static void WriteToStream(std::ostream& os, const core::Schema& schema) {
-        for (auto& field : schema.GetFields()) {
+        for (const auto& field : schema.GetFields()) {
             os << field.name << "," << core::DataTypeToString(field.type);
             if (field.nullable) {
                 os << ",nullable";