Use %q to format-quote strings

Author: IsaacG

testrunner/ast.go

@@ -50,7 +50,7 @@ func FindAllRootLevelTests(fileName string) []rootLevelTest {
 	ppc := parser.ParseComments
 	file, err := parser.ParseFile(fset, fileName, nil, ppc)
 	if err != nil {
-		log.Printf("error: not able to parse '%s': %s", fileName, err)
+		log.Printf("error: not able to parse %q: %s", fileName, err)
 		return nil
 	}
 	for _, d := range file.Decls {
@@ -113,7 +113,7 @@ func getSubCode(test string, sub string, code string, file string, pkgName strin
 		fset, file, pkgLine+code, parser.ParseComments,
 	)
 	if err != nil {
-		log.Printf("warning: '%s' not parsed from '%s': %s", test, file, err)
+		log.Printf("warning: %q not parsed from %q: %s", test, file, err)
 		return ""
 	}
 

testrunner/ast_debug.ipynb

@@ -189,10 +189,10 @@
     "        // `go test` returns 1 when tests fail                                  \n",
     "        // The test runner should continue and return 0 in this case            \n",
     "        log.Printf(                                                             \n",
-    "          \"warning: ignoring exit code 1 from '%s'\", testCmd.String(),          \n",
+    "          \"warning: ignoring exit code 1 from %q\", testCmd.String(),          \n",
     "        )                                                                       \n",
     "      } else {                                                                  \n",
-    "        log.Fatalf(\"'%s' failed with exit code %d: %s\",                         \n",
+    "        log.Fatalf(\"%q failed with exit code %d: %s\",                         \n",
     "          testCmd.String(), exitError.ExitCode(), err)                          \n",
     "      }                                                                         \n",
     "    }                                                                           \n",

testrunner/execute.go

@@ -511,7 +511,7 @@ func runTests(input_dir string, additionalTestFlags []string) (bytes.Buffer, boo
 
 	exitError, ok := err.(*exec.ExitError)
 	if !ok {
-		log.Fatalf("error: '%s' failed with non exit error %s",
+		log.Fatalf("error: %q failed with non exit error %s",
 			testCmd.String(), err,
 		)
 	}
@@ -522,7 +522,7 @@ func runTests(input_dir string, additionalTestFlags []string) (bytes.Buffer, boo
 		// Combine stderr and stdout in the same order in which they
 		// show up in the console.
 		stderr.WriteString(stdout.String())
-		stderr.WriteString(fmt.Sprintf("'%s' returned exit code %d: %s",
+		stderr.WriteString(fmt.Sprintf("%q returned exit code %d: %s",
 			testCmd.String(), exc, err,
 		))
 		return stderr, false
@@ -533,7 +533,7 @@ func runTests(input_dir string, additionalTestFlags []string) (bytes.Buffer, boo
 		// `go test` returns 1 when tests fail, this is fine
 		return stdout, true
 	default:
-		log.Fatalf("error: '%s' failed with exit error %d: %s",
+		log.Fatalf("error: %q failed with exit error %d: %s",
 			testCmd.String(), exc, err,
 		)
 	}

testrunner/extract.go

@@ -21,7 +21,7 @@ func splitTestName(testName string) (string, string) {
 func FindTestFile(codePath string) string {
 	files, err := os.ReadDir(codePath)
 	if err != nil {
-		log.Printf("warning: input_dir '%s' cannot be read: %s", codePath, err)
+		log.Printf("warning: input_dir %q cannot be read: %s", codePath, err)
 		return ""
 	}
 
@@ -30,7 +30,7 @@ func FindTestFile(codePath string) string {
 			testpath := filepath.Join(codePath, f.Name())
 			fh, err := os.ReadFile(testpath)
 			if err != nil {
-				log.Printf("warning: test file '%s' read failed: %s", testpath, err)
+				log.Printf("warning: test file %q read failed: %s", testpath, err)
 			}
 
 			// We need to check we found the file that actually contains the tests and not only the
@@ -41,7 +41,7 @@ func FindTestFile(codePath string) string {
 			}
 		}
 	}
-	log.Printf("error: test file not found in input_dir '%s'", codePath)
+	log.Printf("error: test file not found in input_dir %q", codePath)
 	return ""
 }