Tidy up shell scripts in bin/

Author: IsaacG

bin/run-in-docker.sh

@@ -17,7 +17,7 @@
 # ./bin/run-in-docker.sh two-fer /absolute/path/to/two-fer/solution/folder/ /absolute/path/to/output/directory/
 
 # If any required arguments is missing, print the usage and exit
-if [ -z "$1" ] || [ -z "$2" ] || [ -z "$3" ]; then
+if (( $# != 3 )); then
     echo "usage: ./bin/run-in-docker.sh exercise-slug /absolute/path/to/solution/folder/ /absolute/path/to/output/directory/"
     exit 1
 fi

bin/run-tests-in-docker.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env sh
+#!/usr/bin/env bash
 
 # Synopsis:
 # Test the test runner Docker image by running it against a predefined set of 
@@ -21,12 +21,10 @@ docker build --rm -t exercism/go-test-runner .
 # TODO: allow image to work with --read-only filesystem
 
 # Run the Docker image using the settings mimicking the production environment
-docker run \
-    --rm \
-    --network none \
-    --mount type=bind,src="${PWD}/tests",dst=/opt/test-runner/tests \
-    --mount type=volume,dst=/tmp \
-    --volume "${PWD}/bin/run-tests.sh:/opt/test-runner/bin/run-tests.sh" \
-    --workdir /opt/test-runner \
-    --entrypoint /opt/test-runner/bin/run-tests.sh \
-    exercism/go-test-runner
+args=(--rm --network none)
+args+=( --mount type=bind,src="${PWD}/tests",dst=/opt/test-runner/tests )
+args+=( --mount type=volume,dst=/tmp )
+args+=( --volume "${PWD}/bin/run-tests.sh:/opt/test-runner/bin/run-tests.sh" )
+args+=( --workdir /opt/test-runner )
+args+=( --entrypoint /opt/test-runner/bin/run-tests.sh )
+docker run "${args[@]}" exercism/go-test-runner

bin/run-tests.sh

@@ -1,4 +1,4 @@
-#!/usr/bin/env sh
+#!/usr/bin/env bash
 
 # Synopsis:
 # Test the test runner by running it against a predefined set of solutions 
@@ -37,9 +37,9 @@ for test_dir in tests/*; do
     echo "${test_dir_name}: comparing results.json to expected_results.json"
     diff "${results_file_path}" "${expected_results_file_path}"
 
-    if [ $? -ne 0 ]; then
+    if (( $? != 0 )); then
         exit_code=1
     fi
 done
 
-exit ${exit_code}
+exit "${exit_code}"

bin/run.sh

@@ -10,4 +10,4 @@
 # ./run.sh two-fer twofer outdir
 
 cd "$2" || exit
-/opt/test-runner/bin/test-runner $2 $3
+/opt/test-runner/bin/test-runner "$2" "$3"