Deprecate Drupal utility scripts

[nigelgbanks]

We should be pushing for images that are by and large configured at build time or in the worst case by confd templates, and should not rely on running commands via docker exec. As it is unreliable and less predictable and requires a release of isle-buildkit for downstream consumers.

To that end:

• An audit should be done of all the scripts
• A deprecate notice should be raised (not sure how to do this as they are bash scripts, but it should go into the release notes at least).
• Update the documentation to describe a better method for applying configuration from environment variables (i.e. how sandbox does it).
• On a subsequent release, the scripts can then be removed.

For example:
https://github.com/Islandora-Devops/isle-buildkit/blob/d5e177dc50acf964925f59684b6988f25a2620e2/drupal/rootfs/etc/islandora/utilities.sh

Has many assumptions about modules configuration etc, and is used to mutate settings.php at run time.

Those scripts were born out of porting what Ansible did into Docker, a good first start, but it's time to move on from them.

[joecorall]

Update the documentation to describe a better method for applying configuration from environment variables (i.e. how sandbox does it).

This might be able to help here: https://github.com/islandora-devops/islectl

We can carve out common tasks as commands on that utility. If we identify what those are i can build them out. Or anyone comfortable with go (or wants to learn it) PRs are welcome.

[nigelgbanks]

I think my intention with this ticket was to get rid of mutations to settings.php and use something akin to:

https://github.com/Islandora-Devops/isle-site-template/blob/main/drupal/rootfs/var/www/drupal/assets/patches/default_settings.txt

Though I think much of the scripts are still in use by isle-dc. Back when this ticket was raised, there was talk of deprecating isle-dc, though that never panned out.

Though I think there are more issues, I've not really dug deeply into it.

Ideally, I'd like to see the Drupal image have little to know specialized knowledge of the site configuration, rather I'd prefer that consumers of it of the image are responsible for their configuration, since every site will be different.

[aOelschlager]

We made changes to isle-dc last year that more or less mimics how isle-site-template sets up the settings.php file: Islandora-Devops/isle-dc#403
I don't think isle-dc is using the update-settings make command in any of the builds now but I just checked and it is used still in the up make command. I'll try and make a pr to fix that lol.
I do like the islectl repo Joe is working on!