Fixes #31 - waterways appear more than once in the search results

HarelM · HarelM · commit 6b9ebfcb69fa · 2025-02-16T20:51:35.000+02:00
diff --git a/src/main/java/il/org/osm/israelhiking/PlanetSearchProfile.java b/src/main/java/il/org/osm/israelhiking/PlanetSearchProfile.java
@@ -260,7 +260,7 @@ private boolean processMtbNameFeature(SourceFeature feature, FeatureCollector fe
         mergedLines.feature = feature;
       }
       if (!Singles.get(mtbName).ids.isEmpty()) {
-        return false;
+        return true;
       }
       var minIdFeature = mergedLines.feature;
       var point = GeoUtils.point(((Geometry)mergedLines.lineMerger.getMergedLineStrings().iterator().next()).getCoordinate());
@@ -314,7 +314,7 @@ private boolean processWaterwayFeature(SourceFeature feature, FeatureCollector f
         mergedLines.feature = feature;
       }
       if (!Waterways.get(name).ids.isEmpty()) {
-        return false;
+        return true;
       }
       var minIdFeature = mergedLines.feature;
       var point = GeoUtils.point(((Geometry)mergedLines.lineMerger.getMergedLineStrings().iterator().next()).getCoordinate());

Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ private boolean processMtbNameFeature(SourceFeature feature, FeatureCollector fe`
`260`	`260`	`mergedLines.feature = feature;`
`261`	`261`	`}`
`262`	`262`	`if (!Singles.get(mtbName).ids.isEmpty()) {`
`263`		`- return false;`
	`263`	`+ return true;`
`264`	`264`	`}`
`265`	`265`	`var minIdFeature = mergedLines.feature;`
`266`	`266`	`var point = GeoUtils.point(((Geometry)mergedLines.lineMerger.getMergedLineStrings().iterator().next()).getCoordinate());`
`@@ -314,7 +314,7 @@ private boolean processWaterwayFeature(SourceFeature feature, FeatureCollector f`
`314`	`314`	`mergedLines.feature = feature;`
`315`	`315`	`}`
`316`	`316`	`if (!Waterways.get(name).ids.isEmpty()) {`
`317`		`- return false;`
	`317`	`+ return true;`
`318`	`318`	`}`
`319`	`319`	`var minIdFeature = mergedLines.feature;`
`320`	`320`	`var point = GeoUtils.point(((Geometry)mergedLines.lineMerger.getMergedLineStrings().iterator().next()).getCoordinate());`