Merge pull request #57 from Iterable/bugfix/ITBL-6071-push-open-noninit-fix

Fix a NullPointerException when SDK isn't initialized in Application#onCreate

Author: vbabenkoru

iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java

@@ -111,6 +111,11 @@ public IterableAttributionInfo getAttributionInfo() {
      * @param attributionInfo Attribution information object
      */
     void setAttributionInfo(IterableAttributionInfo attributionInfo) {
+        if (_applicationContext == null) {
+            IterableLogger.e(TAG, "setAttributionInfo: Iterable SDK is not initialized with a context.");
+            return;
+        }
+
         IterableUtil.saveExpirableJsonObject(
                 getPreferences(),
                 IterableConstants.SHARED_PREFS_ATTRIBUTION_INFO_KEY,

iterableapi/src/test/java/com/iterable/iterableapi/IterablePushActionReceiverTest.java

@@ -61,6 +61,19 @@ private void stubAnyRequestReturningStatusCode(int statusCode, String body) {
         server.enqueue(response);
     }
 
+    @Test
+    public void testPushOpenWithNonInitializedSDK() throws Exception {
+        stubAnyRequestReturningStatusCode(200, "{}");
+        IterableApi.sharedInstance = new IterableApi();
+        IterablePushActionReceiver iterablePushActionReceiver = new IterablePushActionReceiver();
+        Intent intent = new Intent(IterableConstants.ACTION_PUSH_ACTION);
+        intent.putExtra(IterableConstants.ITERABLE_DATA_ACTION_IDENTIFIER, "silentButton");
+        intent.putExtra(IterableConstants.ITERABLE_DATA_KEY, IterableTestUtils.getResourceString("push_payload_silent_action.json"));
+
+        // This must not crash
+        iterablePushActionReceiver.onReceive(RuntimeEnvironment.application, intent);
+    }
+
     @Test
     public void testTrackPushOpenWithCustomAction() throws Exception {
         final JSONObject responseData = new JSONObject("{\"key\":\"value\"}");