Skip to content

Commit f932710

Browse files
authored
Merge pull request #396 from Iterable/jay/MOB-3673-in-app-close-sig
[MOB-3673] allow clickedUrl to be null in trackInAppClose
2 parents 23c59ca + cdfa788 commit f932710

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -724,7 +724,7 @@ public void trackInAppClick(@NonNull IterableInAppMessage message, @NonNull Stri
724724
* @param closeAction the method of how the in-app was closed
725725
* @param clickLocation the location of the in-app for this event
726726
*/
727-
void trackInAppClose(@NonNull IterableInAppMessage message, @NonNull String clickedURL, @NonNull IterableInAppCloseAction closeAction, @NonNull IterableInAppLocation clickLocation) {
727+
public void trackInAppClose(@NonNull IterableInAppMessage message, @Nullable String clickedURL, @NonNull IterableInAppCloseAction closeAction, @NonNull IterableInAppLocation clickLocation) {
728728
if (!checkSDKInitialization()) {
729729
return;
730730
}

iterableapi/src/main/java/com/iterable/iterableapi/IterableApiClient.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,21 +275,23 @@ public void trackInAppClick(@NonNull IterableInAppMessage message, @NonNull Stri
275275
}
276276
}
277277

278-
void trackInAppClose(@NonNull IterableInAppMessage message, @NonNull String clickedURL, @NonNull IterableInAppCloseAction closeAction, @NonNull IterableInAppLocation clickLocation, @Nullable String inboxSessionId) {
278+
void trackInAppClose(@NonNull IterableInAppMessage message, @Nullable String clickedURL, @NonNull IterableInAppCloseAction closeAction, @NonNull IterableInAppLocation clickLocation, @Nullable String inboxSessionId) {
279279
JSONObject requestJSON = new JSONObject();
280280

281281
try {
282282
addEmailOrUserIdToJson(requestJSON);
283-
requestJSON.put(IterableConstants.KEY_EMAIL, authProvider.getEmail());
284-
requestJSON.put(IterableConstants.KEY_USER_ID, authProvider.getUserId());
283+
// requestJSON.put(IterableConstants.KEY_EMAIL, authProvider.getEmail()); // not needed due to addEmailOrUserIdToJson(requestJSON)?
284+
// requestJSON.put(IterableConstants.KEY_USER_ID, authProvider.getUserId()); // not needed due to addEmailOrUserIdToJson(requestJSON)?
285285
requestJSON.put(IterableConstants.KEY_MESSAGE_ID, message.getMessageId());
286-
requestJSON.put(IterableConstants.ITERABLE_IN_APP_CLICKED_URL, clickedURL);
286+
requestJSON.putOpt(IterableConstants.ITERABLE_IN_APP_CLICKED_URL, clickedURL);
287287
requestJSON.put(IterableConstants.ITERABLE_IN_APP_CLOSE_ACTION, closeAction.toString());
288288
requestJSON.put(IterableConstants.KEY_MESSAGE_CONTEXT, getInAppMessageContext(message, clickLocation));
289289
requestJSON.put(IterableConstants.KEY_DEVICE_INFO, getDeviceInfoJson());
290+
290291
if (clickLocation == IterableInAppLocation.INBOX) {
291292
addInboxSessionID(requestJSON, inboxSessionId);
292293
}
294+
293295
sendPostRequest(IterableConstants.ENDPOINT_TRACK_INAPP_CLOSE, requestJSON);
294296
} catch (JSONException e) {
295297
e.printStackTrace();

0 commit comments

Comments
 (0)