Merge pull request #782 from Iterable/MOB-9021-Remove-Webview-Protocol-method

Ayyanchira · web-flow · commit 12d2379c00b2 · 2024-07-03T12:04:05.000-07:00
[MOB-9021] - Remove protocol method
diff --git a/swift-sdk/Internal/WebViewProtocol.swift b/swift-sdk/Internal/WebViewProtocol.swift
@@ -17,7 +17,6 @@ protocol WebViewProtocol {
     @discardableResult func loadHTMLString(_ string: String, baseURL: URL?) -> WKNavigation?
     func set(position: ViewPosition)
     func set(navigationDelegate: WKNavigationDelegate?)
-    func evaluateJavaScript(_ javaScriptString: String, completionHandler: ((Any?, Error?) -> Void)?)
     func layoutSubviews()
     func calculateHeight() -> Pending<CGFloat, IterableError>
 }
diff --git a/tests/common/MockWebView.swift b/tests/common/MockWebView.swift
@@ -23,10 +23,6 @@ class MockWebView: WebViewProtocol {
     
     func set(navigationDelegate _: WKNavigationDelegate?) {}
     
-    func evaluateJavaScript(_: String, completionHandler: ((Any?, Error?) -> Void)?) {
-        completionHandler?(height, nil)
-    }
-    
     func layoutSubviews() {}
     
     func calculateHeight() -> Pending<CGFloat, IterableError> {

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ protocol WebViewProtocol {`
`17`	`17`	`@discardableResult func loadHTMLString(_ string: String, baseURL: URL?) -> WKNavigation?`
`18`	`18`	`func set(position: ViewPosition)`
`19`	`19`	`func set(navigationDelegate: WKNavigationDelegate?)`
`20`		`- func evaluateJavaScript(_ javaScriptString: String, completionHandler: ((Any?, Error?) -> Void)?)`
`21`	`20`	`func layoutSubviews()`
`22`	`21`	`func calculateHeight() -> Pending<CGFloat, IterableError>`
`23`	`22`	`}`