Skip to content

Commit 9a8169b

Browse files
authored
Merge pull request #800 from Iterable/bug-fix/MOB-7855-universal-link-behavior
Bug fix/mob 7855 universal link behavior
2 parents 5a48b99 + 7389a3c commit 9a8169b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

swift-sdk/Internal/DeepLinkManager.swift

+3-2
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,18 @@ class DeepLinkManager: NSObject {
4343
// Always return true for deep link
4444
return (true, pending)
4545
} else {
46+
var result: Bool = false
4647
if let action = IterableAction.actionOpenUrl(fromUrlString: url.absoluteString) {
4748
let context = IterableActionContext(action: action, source: .universalLink)
4849

49-
ActionRunner.execute(action: action,
50+
result = ActionRunner.execute(action: action,
5051
context: context,
5152
urlHandler: IterableUtil.urlHandler(fromUrlDelegate: urlDelegate,
5253
inContext: context),
5354
urlOpener: urlOpener,
5455
allowedProtocols: allowedProtocols)
5556
}
56-
return (false, Fulfill<IterableAttributionInfo?, Error>(value: nil))
57+
return (result, Fulfill<IterableAttributionInfo?, Error>(value: nil))
5758
}
5859
}
5960

tests/unit-tests/DeepLinkTests.swift

+2-3
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,10 @@ class DeepLinkTests: XCTestCase {
7070

7171
let deepLinkManager = DeepLinkManager(redirectNetworkSessionProvider: createNoRedirectNetworkSessionProvider())
7272

73-
let (isIterableLink, _) = deepLinkManager.handleUniversalLink(URL(string: iterableNoRewriteURL)!,
73+
let (_, _) = deepLinkManager.handleUniversalLink(URL(string: iterableNoRewriteURL)!,
7474
urlDelegate: mockUrlDelegate,
7575
urlOpener: MockUrlOpener())
76-
77-
XCTAssertFalse(isIterableLink)
76+
7877
wait(for: [expectation1], timeout: testExpectationTimeout)
7978
}
8079

0 commit comments

Comments
 (0)