Skip to content

Commit 082fee6

Browse files
authored
properly format query params for get requests (#418)
1 parent 5572d30 commit 082fee6

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

src/embedded/embeddedManager.ts

+1-11
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,11 @@ export class IterableEmbeddedManager {
3333
placementIds: number[]
3434
) {
3535
try {
36-
const params: any = {};
37-
if (placementIds.length > 0) {
38-
params.placementIds = placementIds[0];
39-
if (placementIds.length > 1) {
40-
params.placementIds += placementIds
41-
.slice(1)
42-
.map((id) => `&placementIds=${id}`)
43-
.join('');
44-
}
45-
}
4636
const iterableResult: any = await baseIterableRequest<IterableResponse>({
4737
method: 'GET',
4838
url: ENDPOINTS.get_embedded_messages.route,
4939
params: {
50-
...params,
40+
placementIds,
5141
platform: WEB_PLATFORM,
5242
sdkVersion: SDK_VERSION,
5343
packageName: packageName

src/request.ts

+4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import Axios, { AxiosRequestConfig } from 'axios';
2+
import qs from 'qs';
23
import { BASE_URL, STATIC_HEADERS, EU_ITERABLE_API } from './constants';
34
import { IterablePromise, IterableResponse } from './types';
45
import { AnySchema, ValidationError } from 'yup';
@@ -46,6 +47,9 @@ export const baseIterableRequest = <T = any>(
4647
headers: {
4748
...payload.headers,
4849
...STATIC_HEADERS
50+
},
51+
paramsSerializer: (params) => {
52+
return qs.stringify(params, { arrayFormat: 'repeat' });
4953
}
5054
});
5155
} catch (error) {

0 commit comments

Comments
 (0)