Skip to content

Commit 63ce723

Browse files
authored
[MOB-8854]: Prepublish checks and fixes (#408)
* bump version * fix prepublish and add prepublish to PR checks --------- Co-authored-by: mitch prewitt <[email protected]>
1 parent 7e78550 commit 63ce723

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

.github/workflows/ci.yml

+1-4
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,7 @@ jobs:
2323
node-version: '16.3.0'
2424
cache: 'yarn'
2525
- run: yarn install --frozen-lockfile
26-
- run: yarn typecheck
27-
- run: yarn format
28-
- run: yarn build
29-
- run: yarn build:node
26+
- run: yarn prepublishOnly
3027
- run: node index.node.js
3128
- run: yarn test
3229
- run: yarn check-deps

src/components/banner/index.tsx

+8-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { handleElementClick } from 'src/embedded/utils';
21
import { OOTB } from '../types';
32
import {
43
bannerButtons,
@@ -11,7 +10,11 @@ import {
1110
defaultTitleStyles,
1211
textTitleImageDefaultStyle
1312
} from './styles';
14-
import { addButtonClickEvent, getTrimmedText } from 'src/embedded/utils';
13+
import {
14+
addButtonClickEvent,
15+
getTrimmedText,
16+
handleElementClick
17+
} from 'src/embedded/utils';
1518

1619
const emptyElement = {
1720
id: '',
@@ -99,7 +102,9 @@ export function IterableEmbeddedBanner({
99102
}">
100103
<div id="${
101104
htmlElements?.textTitle?.id
102-
}" style="${defaultTextParentStyles}; ${htmlElements?.textTitle?.styles}">
105+
}" style="${defaultTextParentStyles}; ${
106+
htmlElements?.textTitle?.styles
107+
}">
103108
${
104109
trimmedTitle.length
105110
? `<text id="${htmlElements?.title?.id}" style="${defaultTitleStyles}; ${htmlElements?.title?.styles}">${trimmedTitle}</text>`

src/components/card/index.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ export function IterableEmbeddedCard({
9696
src="${message?.elements?.mediaUrl}"/>`
9797
: ''
9898
}
99-
<div id="${htmlElements?.textTitle?.id}" style="${defaultTextParentStyles}; ${
100-
htmlElements?.textTitle?.styles
101-
}">
99+
<div id="${
100+
htmlElements?.textTitle?.id
101+
}" style="${defaultTextParentStyles}; ${htmlElements?.textTitle?.styles}">
102102
${
103103
trimmedTitle.length
104104
? `<text class="titleText" id="${htmlElements?.title?.id}" style="${defaultTitleStyles} ${htmlElements?.title?.styles}">${trimmedTitle}</text>`

0 commit comments

Comments
 (0)