Merge pull request #629 from Iterable/expo/MOB-11175-make-rn-sdk-compatible-with-expo

[MOB-11175] make-rn-sdk-compatible-with-expo

Author: lposen

.nvmrc

@@ -1 +1 @@
-v18
+v20.19.0

babel.config.js

@@ -1,5 +1,3 @@
 module.exports = {
-  presets: [
-    ['module:react-native-builder-bob/babel-preset', { modules: 'commonjs' }],
-  ],
+  presets: ['module:react-native-builder-bob/babel-preset'],
 };

example/Gemfile

@@ -6,3 +6,11 @@ ruby ">= 2.6.10"
 # Exclude problematic versions of cocoapods and activesupport that causes build failures.
 gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1'
 gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0'
+gem 'xcodeproj', '< 1.26.0'
+gem 'concurrent-ruby', '< 1.3.4'
+
+# Ruby 3.4.0 has removed some libraries from the standard library.
+gem 'bigdecimal'
+gem 'logger'
+gem 'benchmark'
+gem 'mutex_m'

example/README.md

@@ -203,6 +203,23 @@ There are two ways to fix this:
 Run `bundle install` in the _example app directory_.  You can also try running
 it in _ios_ in the _example app directory_.
 
+## Error: `uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger`
+
+This is a known issue with Ruby 3.4.0.  You can fix it by running the following:
+```bash
+gem install xcodeproj -v '< 1.26.0'
+gem install concurrent-ruby -v '< 1.3.4'
+```
+
+## Unable to build on Xcode 16.3
+
+There is a [known issue](https://github.com/facebook/react-native/issues/50411)
+with Xcode 16.3 and [email protected].
+
+Until New Architecture is supporter by Iterable, we cannot upgrade to 0.76.
+Therefore, to fix it we need to downgrade Xcode to 16.2.
+- [Download Xcode 16.2](https://download.developer.apple.com/Developer_Tools/Xcode_16.2/Xcode_16.2.xip)
+
 ## Other
 If things are not working and you are stumped as to why, try running the
 following in the _example app directory_:

package.json

@@ -3,19 +3,14 @@
   "version": "2.0.0-beta",
   "description": "Iterable SDK for React Native.",
   "source": "./src/index.tsx",
-  "main": "./lib/commonjs/index.js",
-  "module": "./lib/module/index.js",
+  "main": "./lib/module/index.js",
+  "types": "./lib/typescript/src/index.d.ts",
   "exports": {
     ".": {
-      "import": {
-        "types": "./lib/typescript/module/src/index.d.ts",
+      "types": "./lib/typescript/src/index.d.ts",
         "default": "./lib/module/index.js"
       },
-      "require": {
-        "types": "./lib/typescript/commonjs/src/index.d.ts",
-        "default": "./lib/commonjs/index.js"
-      }
-    }
+    "./package.json": "./package.json"
   },
   "files": [
     "src",
@@ -93,7 +88,7 @@
     "prettier": "^3.0.3",
     "react": "18.3.1",
     "react-native": "0.75.3",
-    "react-native-builder-bob": "^0.30.2",
+    "react-native-builder-bob": "^0.40.4",
     "react-native-safe-area-context": "^4.11.1",
     "react-native-vector-icons": "^10.2.0",
     "react-native-webview": "^13.12.3",
@@ -115,6 +110,12 @@
     "react-native-vector-icons": "*",
     "react-native-webview": "*"
   },
+  "peerDependenciesMeta": {
+    "expo": {
+      "optional": true
+    }
+  },
+  "sideEffects": false,
   "workspaces": [
     "example"
   ],
@@ -145,12 +146,6 @@
     "source": "src",
     "output": "lib",
     "targets": [
-      [
-        "commonjs",
-        {
-          "esm": true
-        }
-      ],
       [
         "module",
         {
@@ -160,8 +155,7 @@
       [
         "typescript",
         {
-          "project": "tsconfig.build.json",
-          "esm": true
+          "project": "tsconfig.build.json"
         }
       ]
     ]

src/__tests__/IterableInApp.test.ts

@@ -1,6 +1,8 @@
 import { NativeEventEmitter } from 'react-native';
 
 import { IterableLogger } from '../core';
+import { IterableInAppManager } from '../inApp';
+
 import { MockRNIterableAPI } from '../__mocks__/MockRNIterableAPI';
 
 import {
@@ -200,13 +202,12 @@ describe('Iterable In App', () => {
 
     // WHEN the simulated local queue is set to the in-app messages
     MockRNIterableAPI.setMessages(messages);
+    const inAppManager = new IterableInAppManager();
 
     // THEN Iterable,inAppManager.getMessages returns the list of in-app messages
-    return await Iterable.inAppManager
-      .getMessages()
-      .then((messagesObtained) => {
-        expect(messagesObtained).toEqual(messages);
-      });
+    return await inAppManager.getMessages().then((messagesObtained) => {
+      expect(messagesObtained).toEqual(messages);
+    });
   });
 
   test('showMessage_messageAndConsume_returnsClickedUrl', async () => {
@@ -223,13 +224,11 @@ describe('Iterable In App', () => {
 
     // WHEN the simulated clicked url is set to the clicked url
     MockRNIterableAPI.setClickedUrl(clickedUrl);
-
+    const inAppManager = new IterableInAppManager();
     // THEN Iterable,inAppManager.showMessage returns the simulated clicked url
-    return await Iterable.inAppManager
-      .showMessage(message, consume)
-      .then((url) => {
-        expect(url).toEqual(clickedUrl);
-      });
+    return await inAppManager.showMessage(message, consume).then((url) => {
+      expect(url).toEqual(clickedUrl);
+    });
   });
 
   test('removeMessage_params_methodCalledWithParams', () => {
@@ -243,9 +242,10 @@ describe('Iterable In App', () => {
     const location: IterableInAppLocation = IterableInAppLocation.inApp;
     const source: IterableInAppDeleteSource =
       IterableInAppDeleteSource.deleteButton;
+    const inAppManager = new IterableInAppManager();
 
     // WHEN Iterable.inAppManager.removeMessage is called
-    Iterable.inAppManager.removeMessage(message, location, source);
+    inAppManager.removeMessage(message, location, source);
 
     // THEN corresponding method is called on MockIterableAPI with appropriate parameters
     expect(MockRNIterableAPI.removeMessage).toBeCalledWith(
@@ -266,7 +266,8 @@ describe('Iterable In App', () => {
     const read: boolean = true;
 
     // WHEN Iterable.inAppManager.setReadForMessage is called
-    Iterable.inAppManager.setReadForMessage(message, read);
+    const inAppManager = new IterableInAppManager();
+    inAppManager.setReadForMessage(message, read);
 
     // THEN corresponding method is called on MockRNIterableAPI with appropriate parameters
     expect(MockRNIterableAPI.setReadForMessage).toBeCalledWith(
@@ -280,7 +281,8 @@ describe('Iterable In App', () => {
     const paused: boolean = true;
 
     // WHEN Iterable.inAppManager.setAutoDisplayPaused is called
-    Iterable.inAppManager.setAutoDisplayPaused(paused);
+    const inAppManager = new IterableInAppManager();
+    inAppManager.setAutoDisplayPaused(paused);
 
     // THEN corresponding method is called on MockRNIterableAPI with appropriate parameters
     expect(MockRNIterableAPI.setAutoDisplayPaused).toBeCalledWith(paused);