Merge pull request #59 from IvanOfThings/feat/add-allowed-privileges-2

feat: add S3 and CREATE TEMPORARY TABLE privileges

Author: givorra-ls

pkg/resources/role/resource_role_acceptance_test.go

@@ -193,11 +193,9 @@ func TestAccResourceRole(t *testing.T) {
 		Steps: generateTestSteps([]TestStepData{
 			{
 				// Create role
-				roleName: roleName1,
-				database: "*",
-				privileges: []string{
-					"REMOTE",
-				},
+				roleName:   roleName1,
+				database:   "*",
+				privileges: resourcerole.AllowedGlobalPrivileges,
 			}}),
 	})
 	// Validate privileges on create
@@ -227,6 +225,45 @@ func TestAccResourceRole(t *testing.T) {
 			},
 		},
 	})
+	resource.Test(t, resource.TestCase{
+		Providers: testutils.Provider(),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccRoleResource(
+					roleName1,
+					databaseName1,
+					common.Quote([]string{"SYSTEM RELOAD DICTIONARY"}),
+				),
+				ExpectError: regexp.MustCompile("Global privilege SYSTEM RELOAD DICTIONARY is only allowed for database '\\*'"),
+			},
+		},
+	})
+	resource.Test(t, resource.TestCase{
+		Providers: testutils.Provider(),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccRoleResource(
+					roleName1,
+					databaseName1,
+					common.Quote([]string{"S3"}),
+				),
+				ExpectError: regexp.MustCompile("Global privilege S3 is only allowed for database '\\*'"),
+			},
+		},
+	})
+	resource.Test(t, resource.TestCase{
+		Providers: testutils.Provider(),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccRoleResource(
+					roleName1,
+					databaseName1,
+					common.Quote([]string{"CREATE TEMPORARY TABLE"}),
+				),
+				ExpectError: regexp.MustCompile("Global privilege CREATE TEMPORARY TABLE is only allowed for database '\\*'"),
+			},
+		},
+	})
 	// Validate privileges on update
 	resource.Test(t, resource.TestCase{
 		Providers:    testutils.Provider(),

pkg/resources/role/validators.go

@@ -26,6 +26,8 @@ var AllowedDbLevelPrivileges = []string{
 var AllowedGlobalPrivileges = []string{
 	"REMOTE",
 	"SYSTEM RELOAD DICTIONARY",
+	"S3",
+	"CREATE TEMPORARY TABLE",
 }
 
 var AllowedPrivileges = append(AllowedDbLevelPrivileges, AllowedGlobalPrivileges...)