Skip to content

Commit 409e41f

Browse files
authored
Merge pull request #182 from JA-yeong-eop-JA-moeu-JA/refactor/#181-home-categoryId
♻️ Refactor: 홈 상품 리스트 조회 API 로직 개선
2 parents 13487f6 + 5236227 commit 409e41f

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

src/main/java/com/jajaja/domain/product/service/ProductQueryServiceImpl.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,17 @@ private Long resolveCategoryId(Long memberId, Long categoryId) {
190190
if (memberId != null) {
191191
Member member = memberRepository.findById(memberId)
192192
.orElseThrow(() -> new BadRequestException(ErrorStatus.MEMBER_NOT_FOUND));
193-
MemberBusinessCategory memberBusinessCategory = memberBusinessCategoryRepository.findByMember(member)
194-
.orElseThrow(() -> new BadRequestException(ErrorStatus.MEMBER_BUSINESS_CATEGORY_NOT_FOUND));
195-
return memberBusinessCategory.getBusinessCategory().getId();
193+
194+
return memberBusinessCategoryRepository.findByMember(member)
195+
.map(mbc -> mbc.getBusinessCategory().getId())
196+
.orElseGet(() -> {
197+
if (categoryId != null) {
198+
return businessCategoryRepository.findById(categoryId)
199+
.orElseThrow(() -> new BadRequestException(ErrorStatus.BUSINESS_CATEGORY_NOT_FOUND))
200+
.getId();
201+
}
202+
throw new BadRequestException(ErrorStatus.BUSINESS_CATEGORY_REQUIRED);
203+
});
196204
}
197205
if (categoryId != null) {
198206
BusinessCategory category = businessCategoryRepository.findById(categoryId)

0 commit comments

Comments
 (0)