Skip to content

Commit cce6b39

Browse files
authored
Merge pull request #106 from JA-yeong-eop-JA-moeu-JA/feat/#105-profile
✨ feat: 기본프로필 관련 개선
2 parents 97268df + 0efa872 commit cce6b39

File tree

5 files changed

+26
-14
lines changed

5 files changed

+26
-14
lines changed

src/main/java/com/jajaja/domain/member/converter/MemberConverter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ public static Member toEntity(OAuth2ResponseDto oAuth2Response) {
1212
.name(oAuth2Response.getName())
1313
.phone(oAuth2Response.getPhone())
1414
.email(oAuth2Response.getEmail())
15+
.profileKeyName("default-profile-image.png")
1516
.point(0)
1617
.build();
1718
}

src/main/java/com/jajaja/domain/member/dto/response/MemberInfoResponseDto.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ public record MemberInfoResponseDto(
1111
String phone,
1212
String email
1313
) {
14-
public static MemberInfoResponseDto from(Member member) {
14+
public static MemberInfoResponseDto of(Member member, String profileUrl) {
1515
return MemberInfoResponseDto.builder()
1616
.id(member.getId())
1717
.name(member.getName())
18-
.profileUrl(member.getProfileUrl())
18+
.profileUrl(profileUrl)
1919
.phone(member.getPhone())
2020
.email(member.getEmail())
2121
.build();

src/main/java/com/jajaja/domain/member/entity/Member.java

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,23 +36,23 @@ public class Member extends BaseEntity {
3636
@Column(nullable = false, length = 10)
3737
private String name;
3838

39-
@Column(name = "profile_url", length = 512)
40-
private String profileUrl;
39+
@Column(name = "profile_key_name")
40+
private String profileKeyName;
4141

4242
@Column(length = 16)
4343
private String phone;
4444

4545
@Column(nullable = false)
4646
private String email;
47-
47+
4848
@Column(nullable = false)
4949
private Integer point;
5050

5151
@OneToOne(mappedBy = "member", fetch = FetchType.LAZY)
5252
private MemberBusinessCategory memberBusinessCategory;
5353

5454
@OneToMany(mappedBy = "member", cascade = CascadeType.ALL, orphanRemoval = true)
55-
private List<MemberCoupon> memberCoupons = new ArrayList <>();
55+
private List<MemberCoupon> memberCoupons = new ArrayList<>();
5656

5757
@OneToMany(mappedBy = "member", cascade = CascadeType.ALL, orphanRemoval = true)
5858
private List<TeamMember> teamMembers = new ArrayList<>();
@@ -86,8 +86,12 @@ public void updatePhone(String phone) {
8686
public void updateEmail(String email) {
8787
this.email = email;
8888
}
89-
90-
public void updatePoint(int point) { this.point = point; }
91-
92-
public void updateProfileUrl(String profileUrl) { this.profileUrl = profileUrl; }
89+
90+
public void updatePoint(int point) {
91+
this.point = point;
92+
}
93+
94+
public void updateProfileKeyName(String profileKeyName) {
95+
this.profileKeyName = profileKeyName;
96+
}
9397
}

src/main/java/com/jajaja/domain/member/service/MemberCommandServiceImpl.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,13 @@ public MemberInfoResponseDto updateMemberInfo(Long memberId, MemberProfileUpdate
2626
if (request.name() != null) member.updateName(request.name());
2727
if (request.phone() != null) member.updatePhone(request.phone());
2828
if (request.profileKeyName() != null) {
29-
String imageUrl = s3Service.generateStaticUrl(request.profileKeyName());
30-
member.updateProfileUrl(imageUrl);
29+
if (request.profileKeyName().isBlank()) {
30+
member.updateProfileKeyName("default-profile-image.png");
31+
} else {
32+
member.updateProfileKeyName(request.profileKeyName());
33+
}
3134
}
32-
return MemberInfoResponseDto.from(member);
35+
String profileUrl = s3Service.generateStaticUrl(member.getProfileKeyName());
36+
return MemberInfoResponseDto.of(member, profileUrl);
3337
}
3438
}

src/main/java/com/jajaja/domain/member/service/MemberQueryServiceImpl.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.jajaja.domain.member.dto.response.MemberInfoResponseDto;
44
import com.jajaja.domain.member.entity.Member;
55
import com.jajaja.domain.member.repository.MemberRepository;
6+
import com.jajaja.global.S3.service.S3Service;
67
import com.jajaja.global.apiPayload.code.status.ErrorStatus;
78
import com.jajaja.global.apiPayload.exception.custom.BadRequestException;
89
import lombok.RequiredArgsConstructor;
@@ -16,11 +17,13 @@
1617
public class MemberQueryServiceImpl implements MemberQueryService {
1718

1819
private final MemberRepository memberRepository;
20+
private final S3Service s3Service;
1921

2022
@Override
2123
public MemberInfoResponseDto getMemberInfo(Long memberId) {
2224
Member member = memberRepository.findById(memberId)
2325
.orElseThrow(() -> new BadRequestException(ErrorStatus.MEMBER_NOT_FOUND));
24-
return MemberInfoResponseDto.from(member);
26+
String profileUrl = s3Service.generateStaticUrl(member.getProfileKeyName());
27+
return MemberInfoResponseDto.of(member, profileUrl);
2528
}
2629
}

0 commit comments

Comments
 (0)