Skip to content

Commit 6553995

Browse files
JBendaJBenda
authored andcommitted
ci(build): try to debug linking error in pipeline
1 parent c8d4380 commit 6553995

7 files changed

Lines changed: 97 additions & 95 deletions

File tree

.github/workflows/build.yml

Lines changed: 37 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,30 +16,30 @@ jobs:
1616
strategy:
1717
matrix:
1818
include:
19-
- os: macos-latest
20-
artifact: macos
21-
name: MacOSX
22-
inklecate_url: https://github.com/inkle/ink/releases/download/v1.1.1/inklecate_mac.zip
23-
proof: false
24-
unreal: false
25-
- os: macos-14
26-
artifact: macos-arm
27-
name: MacOSX-ARM
28-
inklecate_url: https://github.com/inkle/ink/releases/download/v1.1.1/inklecate_mac.zip
29-
proof: false
30-
unreal: false
19+
# - os: macos-latest
20+
# artifact: macos
21+
# name: MacOSX
22+
# inklecate_url: https://github.com/inkle/ink/releases/download/v1.1.1/inklecate_mac.zip
23+
# proof: false
24+
# unreal: false
25+
# - os: macos-14
26+
# artifact: macos-arm
27+
# name: MacOSX-ARM
28+
# inklecate_url: https://github.com/inkle/ink/releases/download/v1.1.1/inklecate_mac.zip
29+
# proof: false
30+
# unreal: false
3131
- os: windows-latest
3232
artifact: win64
3333
name: Windows x64
3434
inklecate_url: https://github.com/inkle/ink/releases/download/v1.1.1/inklecate_windows.zip
3535
proof: true
3636
unreal: false
37-
- os: "ubuntu-22.04"
38-
artifact: linux
39-
name: Linux x64
40-
inklecate_url: https://github.com/inkle/ink/releases/download/v1.1.1/inklecate_linux.zip
41-
proof: true
42-
unreal: true
37+
# - os: "ubuntu-22.04"
38+
# artifact: linux
39+
# name: Linux x64
40+
# inklecate_url: https://github.com/inkle/ink/releases/download/v1.1.1/inklecate_linux.zip
41+
# proof: true
42+
# unreal: true
4343

4444
steps:
4545

@@ -80,7 +80,25 @@ jobs:
8080
working-directory: ${{github.workspace}}/build
8181
shell: bash
8282
run: cmake --build . --config $BUILD_TYPE
83-
83+
- name: Install Dumpbin
84+
shell: pwsh
85+
if: always()
86+
run: |
87+
Set-ExecutionPolicy Bypass -Scope Process -Force;
88+
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072;
89+
iex ((New-Object System.Net.WebClient).DownloadString('https://community.chocolatey.org/install.ps1'))
90+
choco install visualstudio2019buildtools --package-parameters "--includeRecommended --includeOptional --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64" --no-progress
91+
$vsPath = "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC"
92+
$latestVersion = (Get-ChildItem -Path $vsPath | Sort-Object Name -Descending | Select-Object -First 1).Name
93+
$dumpbinPath = "$vsPath\$latestVersion\bin\Hostx64\x64"
94+
echo $dumpbinPath >> $env:GITHUB_PATH
95+
- name: Inspect inkcpp_cl dependencies
96+
shell: pwsh
97+
working-directory: ${{github.workspace}}/build
98+
if: always()
99+
run: |
100+
dumpbin /dependents inkcpp_cl\inkcpp_cl.exe
101+
dumpbin /imports inkcpp_cl\inkcpp_cl.exe
84102
# Run CMake tests (unit tests, etc.)
85103
- name: CTests
86104
working-directory: ${{github.workspace}}/build

inkcpp/include/globals.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class globals_interface
2828
* @return nullopt if variable won't exist or type won't match
2929
*/
3030
template<typename T>
31-
optional<T> get(const char* name) const
31+
optional<T> get(const char* /*name*/) const
3232
{
3333
static_assert(internal::always_false<T>::value, "Requested Type is not supported");
3434
}
@@ -41,7 +41,7 @@ class globals_interface
4141
* @retval true on success
4242
*/
4343
template<typename T>
44-
bool set(const char* name, const T& val)
44+
bool set(const char* /*name*/, const T& /*val*/)
4545
{
4646
static_assert(internal::always_false<T>::value, "Requested Type is not supported");
4747
return false;

inkcpp/include/types.h

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,15 +129,20 @@ struct value {
129129

130130
/// @}
131131

132+
#ifdef __GNUCC__
133+
# pragma GCC diagnostic push
134+
# pragma GCC diagnostic ignored "-Wtautological-compare"
135+
#endif
132136
/** Get value to corresponding type
133137
* @tparam Ty #Type label of type to get
134138
* @attention behavior if undefined if Ty != value.type
135139
*/
136140
template<Type Ty>
137141
const auto& get() const
138-
{
139-
static_assert(Ty != Ty, "No value getter for the selected type");
140-
}
142+
{ static_assert(Ty != Ty, "No value getter for the selected type"); }
143+
#ifdef __GNUCC__
144+
# pragma GCC diagnostic pop
145+
#endif
141146
};
142147

143148
/** access a @ref ink::runtime::value::Type::Bool value */

inkcpp/operations.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class operation
6060
static constexpr bool enabled = false;
6161

6262
template<typename T>
63-
operation(const T& t)
63+
operation(const T& /*t*/)
6464
{
6565
}
6666

@@ -69,7 +69,7 @@ class operation
6969
* @param stack were the result(s) get pushed
7070
* @param vs array of values, first one = first argument etc
7171
*/
72-
void operator()(basic_eval_stack& stack, value* vs) { inkFail("operation not implemented!"); }
72+
void operator()(basic_eval_stack& /*stack*/, value* /*vs*/) { inkFail("operation not implemented!"); }
7373
};
7474
} // namespace ink::runtime::internal
7575

inkcpp/output.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ void basic_stream::append(const value* in, unsigned int length)
120120
}
121121

122122
template<typename T>
123-
inline void write_char(T& output, char c)
123+
inline void write_char(T& /*output*/, char /*c*/)
124124
{
125125
static_assert(always_false<T>::value, "Invalid output type");
126126
}

inkcpp/string_table.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace ink::runtime::internal
1717
class string_table final : public snapshot_interface
1818
{
1919
public:
20-
virtual ~string_table();
20+
~string_table();
2121

2222
// Create a dynamic string of a particular length
2323
char* create(size_t length);

0 commit comments

Comments
 (0)