Skip to content

Commit e90e4f5

Browse files
committed
build(UE): delete not needed inklecate binaries based on INKCPP_INKLECATE
also skip pypi release if a +UEPatch is part of the version tag
1 parent 12f2ac8 commit e90e4f5

4 files changed

Lines changed: 31 additions & 21 deletions

File tree

.github/workflows/build.yml

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
steps:
4545

4646
# Checkout project
47-
- uses: actions/checkout@v4
47+
- uses: actions/checkout@v6
4848
with:
4949
submodules: true
5050

@@ -88,7 +88,7 @@ jobs:
8888
shell: bash
8989
run: cmake --install . --config $BUILD_TYPE --prefix comp_cl --component cl
9090
- name: Upload Cl
91-
uses: actions/upload-artifact@v4
91+
uses: actions/upload-artifact@v7
9292
with:
9393
name: ${{ matrix.artifact }}-cl
9494
path: build/comp_cl/
@@ -98,7 +98,7 @@ jobs:
9898
shell: bash
9999
run: cmake --install . --config $BUILD_TYPE --prefix comp_lib --component lib
100100
- name: Upload Lib
101-
uses: actions/upload-artifact@v4
101+
uses: actions/upload-artifact@v7
102102
with:
103103
name: ${{ matrix.artifact }}-lib
104104
path: build/comp_lib/
@@ -108,7 +108,7 @@ jobs:
108108
shell: bash
109109
run: cmake --install . --config $BUILD_TYPE --prefix comp_clib --component clib
110110
- name: Upload Clib
111-
uses: actions/upload-artifact@v4
111+
uses: actions/upload-artifact@v7
112112
with:
113113
name: ${{matrix.artifact}}-clib
114114
path: build/comp_clib
@@ -118,35 +118,35 @@ jobs:
118118
working-directory: ${{github.workspace}}/build
119119
shell: bash
120120
run: |
121-
cmake $GITHUB_WORKSPACE -DINKCPP_UNREAL_TARGET_VERSION="5.7" -DINKCPP_UNREAL=ON
121+
cmake $GITHUB_WORKSPACE -DINKCPP_UNREAL_TARGET_VERSION="5.7" -DINKCPP_UNREAL=ON -DINKCPP_INKLECATE=NONE
122122
cmake --install . --config $BUILD_TYPE --prefix comp_unreal_5_7 --component unreal
123-
cmake $GITHUB_WORKSPACE -DINKCPP_UNREAL_TARGET_VERSION="5.6" -DINKCPP_UNREAL=ON
123+
cmake $GITHUB_WORKSPACE -DINKCPP_UNREAL_TARGET_VERSION="5.6" -DINKCPP_UNREAL=ON -DINKCPP_INKLECATE=NONE
124124
cmake --install . --config $BUILD_TYPE --prefix comp_unreal_5_6 --component unreal
125-
cmake $GITHUB_WORKSPACE -DINKCPP_UNREAL_TARGET_VERSION="5.5" -DINKCPP_UNREAL=ON
125+
cmake $GITHUB_WORKSPACE -DINKCPP_UNREAL_TARGET_VERSION="5.5" -DINKCPP_UNREAL=ON -DINKCPP_INKLECATE=NONE
126126
cmake --install . --config $BUILD_TYPE --prefix comp_unreal_5_5 --component unreal
127-
cmake $GITHUB_WORKSPACE -DINKCPP_UNREAL_TARGET_VERSION="5.4" -DINKCPP_UNREAL=ON
127+
cmake $GITHUB_WORKSPACE -DINKCPP_UNREAL_TARGET_VERSION="5.4" -DINKCPP_UNREAL=ON -DINKCPP_INKLECATE=NONE
128128
cmake --install . --config $BUILD_TYPE --prefix comp_unreal_5_4 --component unreal
129129
- name: Upload UE 5.7
130130
if: ${{ matrix.unreal }}
131-
uses: actions/upload-artifact@v4
131+
uses: actions/upload-artifact@v7
132132
with:
133133
name: unreal_5_7
134134
path: build/comp_unreal_5_7/
135135
- name: Upload UE 5.6
136136
if: ${{ matrix.unreal }}
137-
uses: actions/upload-artifact@v4
137+
uses: actions/upload-artifact@v7
138138
with:
139139
name: unreal_5_6
140140
path: build/comp_unreal_5_6/
141141
- name: Upload UE 5.5
142142
if: ${{ matrix.unreal }}
143-
uses: actions/upload-artifact@v4
143+
uses: actions/upload-artifact@v7
144144
with:
145145
name: unreal_5_5
146146
path: build/comp_unreal_5_5/
147147
- name: Upload UE 5.4
148148
if: ${{ matrix.unreal }}
149-
uses: actions/upload-artifact@v4
149+
uses: actions/upload-artifact@v7
150150
with:
151151
name: unreal_5_4
152152
path: build/comp_unreal_5_4/
@@ -183,15 +183,15 @@ jobs:
183183
184184
# Upload results artifact
185185
- name: Upload Results Artifact
186-
uses: actions/upload-artifact@v4
186+
uses: actions/upload-artifact@v7
187187
with:
188188
name: result-${{ matrix.artifact }}
189189
path: proofing/ink-proof/${{ matrix.artifact }}.txt
190190

191191
# Upload website artifact
192192
- name: Upload Ink-Proof Website Artifact
193193
if: ${{ matrix.proof }}
194-
uses: actions/upload-artifact@v4
194+
uses: actions/upload-artifact@v7
195195
with:
196196
name: ${{ matrix.artifact }}-www
197197
path: proofing/ink-proof/out
@@ -203,7 +203,7 @@ jobs:
203203
env:
204204
DOXYGEN_VERSION: "1.17.0"
205205
steps:
206-
- uses: actions/checkout@v4
206+
- uses: actions/checkout@v6
207207
with:
208208
submodules: true
209209
- name: Set upt Python
@@ -246,7 +246,7 @@ jobs:
246246
shell: bash
247247
run: cmake --build . --target doc --config Release
248248
- name: Upload
249-
uses: actions/upload-artifact@v4
249+
uses: actions/upload-artifact@v7
250250
with:
251251
name: doxygen
252252
path: Documentation/
@@ -256,7 +256,7 @@ jobs:
256256
needs: compilation
257257
runs-on: ubuntu-latest
258258
steps:
259-
- uses: actions/checkout@v4
259+
- uses: actions/checkout@v6
260260
with:
261261
submodules: true
262262
- name: Set up Python
@@ -296,7 +296,7 @@ jobs:
296296
run: |
297297
rm dist/*.whl
298298
- name: Upload Python files
299-
uses: actions/upload-artifact@v4
299+
uses: actions/upload-artifact@v7
300300
with:
301301
name: python-package-distribution
302302
path: dist/
@@ -306,7 +306,7 @@ jobs:
306306
runs-on: ubuntu-latest
307307
if: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'master' }}
308308
steps:
309-
- uses: actions/checkout@v4
309+
- uses: actions/checkout@v6
310310
- name: Fetch master branch
311311
run: |
312312
git fetch origin master
@@ -329,7 +329,7 @@ jobs:
329329
runs-on: ubuntu-latest
330330
if: github.ref == 'refs/heads/master'
331331
steps:
332-
- uses: actions/checkout@v4
332+
- uses: actions/checkout@v6
333333

334334
# Download Ink Proof page for Linux
335335
- uses: actions/download-artifact@v4

.github/workflows/release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
id-token: write
2020
contents: write
2121
steps:
22-
- uses: actions/checkout@v4
22+
- uses: actions/checkout@v6
2323
- name: Download artifacts
2424
env:
2525
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -35,6 +35,7 @@ jobs:
3535
- name: List
3636
run: tree
3737
- name: Publish to PyPI
38+
if: ${{! contains(github.ref_name, "+UEPatch")}}
3839
uses: pypa/gh-action-pypi-publish@release/v1.12
3940
- name: Create release
4041
env:

inkcpp/hungarian_solver.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
/* Copyright (c) 2024 Julian Benda
2+
*
3+
* This file is part of inkCPP which is released under MIT license.
4+
* See file LICENSE.txt or go to
5+
* https://github.com/JBenda/inkcpp for full license details.
6+
*/
17
#pragma once
28

39
#include "system.h"

unreal/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ if(INKCPP_UNREAL)
2929
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/inkcpp/Source/ThirdParty/inklecate/")
3030
set(INKCPP_INKLECATE_BUNDLED TRUE)
3131
else()
32+
file(REMOVE_RECURSE "${CMAKE_CURRENT_BINARY_DIR}/inkcpp/Source/ThirdParty/inklecate/windows")
3233
message(WARNING "InkCPP: failed to download inklecate for Windows. "
3334
"A .ink file can still be imported if the user configures the inklecate path "
3435
"in Project Settings > Plugins > InkCPP.")
@@ -39,6 +40,7 @@ if(INKCPP_UNREAL)
3940
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/inkcpp/Source/ThirdParty/inklecate/")
4041
set(INKCPP_INKLECATE_BUNDLED TRUE)
4142
else()
43+
file(REMOVE_RECURSE "${CMAKE_CURRENT_BINARY_DIR}/inkcpp/Source/ThirdParty/inklecate/mac")
4244
message(WARNING "InkCPP: failed to download inklecate for macOS. "
4345
"A .ink file can still be imported if the user configures the inklecate path "
4446
"in Project Settings > Plugins > InkCPP.")
@@ -49,6 +51,7 @@ if(INKCPP_UNREAL)
4951
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/inkcpp/Source/ThirdParty/inklecate/")
5052
set(INKCPP_INKLECATE_BUNDLED TRUE)
5153
else()
54+
file(REMOVE_RECURSE "${CMAKE_CURRENT_BINARY_DIR}/inkcpp/Source/ThirdParty/inklecate/linux")
5255
message(WARNING "InkCPP: failed to download inklecate for Linux. "
5356
"A .ink file can still be imported if the user configures the inklecate path "
5457
"in Project Settings > Plugins > InkCPP.")

0 commit comments

Comments
 (0)