refactor: remove CopyBox component and update recording logic to use detached processes

Author: JDKamalakar

CaptureToolbar.qml

@@ -45,7 +45,7 @@ PluginComponent {
     property bool isMicCaptured: false
     property bool isMicMuted: false
     property int recordingElapsed: 0
-    property int recordingPid: 0
+    property var recordingProcess: null
     property bool showRecPill: (pluginData && pluginData.showRecPill !== undefined) ? pluginData.showRecPill : true
     property bool showNotify: (pluginData && pluginData.showNotify !== undefined) ? pluginData.showNotify : true
     property bool enableEditorShortcut: (pluginData && pluginData.enableEditorShortcut != null) ? pluginData.enableEditorShortcut : true
@@ -540,6 +540,22 @@ PluginComponent {
                 "else " +
                 "start_rec; exec gpu-screen-recorder -w portal" + gsrSuffix + "; " +
                 "fi";
+        } else if (root.captureMode === "all") {
+            scriptBody = "sleep 0.2; mkdir -p \"" + dir + "\"; " +
+                "HAS_PORTAL=\"\"; " +
+                "if command -v dbus-send >/dev/null 2>&1; then " +
+                "dbus-send --dest=org.freedesktop.portal.Desktop --print-reply /org/freedesktop/portal/desktop org.freedesktop.DBus.Introspectable.Introspect 2>/dev/null | grep -q \"org.freedesktop.portal.ScreenCast\" && HAS_PORTAL=\"1\"; " +
+                "elif command -v busctl >/dev/null 2>&1; then " +
+                "busctl introspect org.freedesktop.portal.Desktop /org/freedesktop/portal/desktop 2>/dev/null | grep -q \"org.freedesktop.portal.ScreenCast\" && HAS_PORTAL=\"1\"; " +
+                "fi; " +
+                "if [ -n \"$HAS_PORTAL\" ] && { [ \"$XDG_SESSION_TYPE\" = \"wayland\" ] || [ -n \"$WAYLAND_DISPLAY\" ]; }; then " +
+                "exec gpu-screen-recorder -w portal" + gsrSuffix + "; " +
+                "elif [ \"$XDG_SESSION_TYPE\" = \"wayland\" ] || [ -n \"$WAYLAND_DISPLAY\" ]; then " +
+                "notify-send \"Multi-Monitor Recording\" \"Recording focused screen. Install a desktop portal (e.g. xdg-desktop-portal-niri) to record all screens on Wayland.\" -t 5000; " +
+                "exec gpu-screen-recorder -w \"$MONITOR\"" + gsrSuffix + "; " +
+                "else " +
+                "exec gpu-screen-recorder -w screen" + gsrSuffix + "; " +
+                "fi";
         } else {
             scriptBody = "sleep 0.2; mkdir -p \"" + dir + "\"; exec gpu-screen-recorder -w \"$MONITOR\"" + gsrSuffix;
         }
@@ -554,48 +570,34 @@ PluginComponent {
         }
         root.close();
 
-        recorderProcess.command = ["bash", "-c", finalCmd];
-        recorderProcess.running = true;
+        Quickshell.execDetached(["bash", "-c", finalCmd]);
 
         if (root.showNotify && !deferRecordingUi) {
             Quickshell.execDetached(["notify-send", "Recording Started", "Saving to " + dir]);
         }
     }
 
     function stopRecording() {
-        if (root.recordingPid > 0) {
-            Quickshell.execDetached(["kill", "-SIGINT", String(root.recordingPid)]);
-        } else {
-            Quickshell.execDetached(["pkill", "-SIGINT", "-f", "gpu-screen-recorder"]);
-        }
+        Quickshell.execDetached(["pkill", "-SIGINT", "-f", "gpu-screen-recorder"]);
         Quickshell.execDetached(["pactl", "set-source-mute", "@DEFAULT_SOURCE@", "0"]);
         root.isRecording = false;
         root.isPaused = false;
         root.isMicCaptured = false;
         root.isMicMuted = false;
         root.recordingElapsed = 0;
-        root.recordingPid = 0;
 
         if (root.showNotify) {
             Quickshell.execDetached(["notify-send", "Recording Stopped", "Video saved to " + (root.videoCustomPath || "~/Videos")]);
         }
     }
 
     function pauseRecording() {
-        if (root.recordingPid > 0) {
-            Quickshell.execDetached(["kill", "-SIGUSR2", String(root.recordingPid)]);
-        } else {
-            Quickshell.execDetached(["pkill", "-SIGUSR2", "-f", "gpu-screen-recorder"]);
-        }
+        Quickshell.execDetached(["pkill", "-SIGUSR2", "-f", "gpu-screen-recorder"]);
         root.isPaused = true;
     }
 
     function resumeRecording() {
-        if (root.recordingPid > 0) {
-            Quickshell.execDetached(["kill", "-SIGUSR2", String(root.recordingPid)]);
-        } else {
-            Quickshell.execDetached(["pkill", "-SIGUSR2", "-f", "gpu-screen-recorder"]);
-        }
+        Quickshell.execDetached(["pkill", "-SIGUSR2", "-f", "gpu-screen-recorder"]);
         root.isPaused = false;
     }
 
@@ -607,23 +609,6 @@ PluginComponent {
         return (m < 10 ? "0" : "") + m + ":" + (s < 10 ? "0" : "") + s;
     }
 
-    Process {
-        id: recorderProcess
-        command: []
-        running: false
-        onStarted: {
-            root.recordingPid = processId;
-        }
-        onExited: exitCode => {
-            root.isRecording = false;
-            root.isPaused = false;
-            root.isMicCaptured = false;
-            root.isMicMuted = false;
-            root.recordingElapsed = 0;
-            root.recordingPid = 0;
-        }
-    }
-
     // Recording elapsed timer
     Timer {
         id: recordingTimer

CopyBox.qml

@@ -519,76 +519,5 @@ PluginSettings {
                 }
             }
         }
-
-        // --- Commands & Shortcuts ---
-        Rectangle {
-            width: parent.width
-            height: commandsGroup.implicitHeight + Theme.spacingM * 2
-            color: Theme.surfaceContainer
-            radius: Theme.cornerRadius
-            border.color: Theme.outline
-            border.width: 1
-            opacity: 0.8
-
-            Column {
-                id: commandsGroup
-                anchors.fill: parent
-                anchors.margins: Theme.spacingM
-                spacing: Theme.spacingM
-
-                Row {
-                    width: parent.width; spacing: Theme.spacingM
-                    DankIcon { name: "terminal"; size: 22; anchors.verticalCenter: parent.verticalCenter; opacity: 0.8 }
-                    StyledText {
-                        text: "Commands & Shortcuts"
-                        font.pixelSize: Theme.fontSizeMedium
-                        font.weight: Font.Medium
-                        color: Theme.surfaceText
-                        anchors.verticalCenter: parent.verticalCenter
-                    }
-                }
-
-                StyledText {
-                    width: parent.width
-                    text: "You can open, close, or toggle the screen capture toolbar using the dms CLI:"
-                    font.pixelSize: Theme.fontSizeSmall
-                    color: Theme.surfaceVariantText
-                    wrapMode: Text.WordWrap
-                }
-
-                CopyBox {
-                    width: parent.width
-                    label: "Toggle Toolbar Command"
-                    text: "dms ipc call screenCaptureToolbar toggle"
-                }
-
-                CopyBox {
-                    width: parent.width
-                    label: "Open Toolbar Command"
-                    text: "dms ipc call screenCaptureToolbar open"
-                }
-
-                CopyBox {
-                    width: parent.width
-                    label: "Close Toolbar Command"
-                    text: "dms ipc call screenCaptureToolbar close"
-                }
-
-                StyledText {
-                    width: parent.width
-                    text: "To trigger the screen capture toolbar using the Print key, add this spawn command to your Niri configuration binds:"
-                    font.pixelSize: Theme.fontSizeSmall
-                    color: Theme.primary
-                    font.italic: true
-                    wrapMode: Text.WordWrap
-                }
-
-                CopyBox {
-                    width: parent.width
-                    label: "Niri Bind Configuration"
-                    text: "Print { spawn \"dms\" \"ipc\" \"call\" \"screenCaptureToolbar\" \"toggle\"; }"
-                }
-            }
-        }
     }
 }