the order_activatable? method currently verifies that the gift card is not applied to an order that has a created_at date that is earlier than the gift card's created_at date. We're thinking of removing this check from a store that I'm working on because we've encountered a few cases now of customers not being able to use their gift card code due to that check. The most common case is something like this:
- customer A visits the store for the first time on date x and hence a blank order is created in the system for that customer.
- customer B purchases a gift card on date x + 1 and gives it to customer A.
- customer A returns to the store and attempts to check out using the gift code but is told "The gift code you entered doesn't exist. Please try again." because their order.created_at is set to date x whereas giftcard.created_at is set to x + 1
I'm happy to submit a patch that removes this date related check in order_activatable? but I'm wondering if there's some reason that I'm overlooking as to why it would be a bad idea to do so?
the order_activatable? method currently verifies that the gift card is not applied to an order that has a created_at date that is earlier than the gift card's created_at date. We're thinking of removing this check from a store that I'm working on because we've encountered a few cases now of customers not being able to use their gift card code due to that check. The most common case is something like this:
I'm happy to submit a patch that removes this date related check in order_activatable? but I'm wondering if there's some reason that I'm overlooking as to why it would be a bad idea to do so?