Fixed SymbolOrderBook websocket subscription not getting closed if when waiting for initial data times out

JKorf · JKorf · commit 5e03cb56cdb0 · 2026-02-16T10:22:54.000+01:00
diff --git a/Binance.Net/SymbolOrderBooks/BinanceFuturesCoinSymbolOrderBook.cs b/Binance.Net/SymbolOrderBooks/BinanceFuturesCoinSymbolOrderBook.cs
@@ -103,6 +103,9 @@ protected override async Task<CallResult<UpdateSubscription>> DoStartAsync(Cance
             else
             {
                 var setResult = await WaitForSetOrderBookAsync(_initialDataTimeout, ct).ConfigureAwait(false);
+                if (!setResult)
+                    await subResult.Data.CloseAsync().ConfigureAwait(false);
+
                 return setResult ? subResult : new CallResult<UpdateSubscription>(setResult.Error!);
             }
 
diff --git a/Binance.Net/SymbolOrderBooks/BinanceFuturesUsdtSymbolOrderBook.cs b/Binance.Net/SymbolOrderBooks/BinanceFuturesUsdtSymbolOrderBook.cs
@@ -103,6 +103,9 @@ protected override async Task<CallResult<UpdateSubscription>> DoStartAsync(Cance
             else
             {
                 var setResult = await WaitForSetOrderBookAsync(_initialDataTimeout, ct).ConfigureAwait(false);
+                if (!setResult)
+                    await subResult.Data.CloseAsync().ConfigureAwait(false);
+
                 return setResult ? subResult : new CallResult<UpdateSubscription>(setResult.Error!);
             }
 
diff --git a/Binance.Net/SymbolOrderBooks/BinanceSpotSymbolOrderBook.cs b/Binance.Net/SymbolOrderBooks/BinanceSpotSymbolOrderBook.cs
@@ -99,6 +99,9 @@ protected override async Task<CallResult<UpdateSubscription>> DoStartAsync(Cance
             else
             {
                 var setResult = await WaitForSetOrderBookAsync(_initialDataTimeout, ct).ConfigureAwait(false);
+                if (!setResult)
+                    await subResult.Data.CloseAsync().ConfigureAwait(false);
+
                 return setResult ? subResult : new CallResult<UpdateSubscription>(setResult.Error!);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,9 @@ protected override async Task<CallResult<UpdateSubscription>> DoStartAsync(Cance`
`103`	`103`	`else`
`104`	`104`	`{`
`105`	`105`	`var setResult = await WaitForSetOrderBookAsync(_initialDataTimeout, ct).ConfigureAwait(false);`
	`106`	`+ if (!setResult)`
	`107`	`+ await subResult.Data.CloseAsync().ConfigureAwait(false);`
	`108`	`+`
`106`	`109`	`return setResult ? subResult : new CallResult<UpdateSubscription>(setResult.Error!);`
`107`	`110`	`}`
`108`	`111`
Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,9 @@ protected override async Task<CallResult<UpdateSubscription>> DoStartAsync(Cance`
`99`	`99`	`else`
`100`	`100`	`{`
`101`	`101`	`var setResult = await WaitForSetOrderBookAsync(_initialDataTimeout, ct).ConfigureAwait(false);`
	`102`	`+ if (!setResult)`
	`103`	`+ await subResult.Data.CloseAsync().ConfigureAwait(false);`
	`104`	`+`
`102`	`105`	`return setResult ? subResult : new CallResult<UpdateSubscription>(setResult.Error!);`
`103`	`106`	`}`
`104`	`107`