Fixed some documentation issues

Author: JKorf

.cursor/rules/binance-net.mdc

@@ -14,6 +14,7 @@ This codebase uses **Binance.Net** for Binance cryptocurrency exchange access. D
 
 ```csharp
 using Binance.Net.Clients;
+using Binance.Net;
 using Binance.Net.Objects;
 
 var restClient = new BinanceRestClient(options =>
@@ -36,10 +37,10 @@ var price = ticker.Data.LastPrice;
 
 ## API surface
 
-- `restClient.SpotApi.{ExchangeData|Account|Trading|Margin|SubAccount|Brokerage}`
+- `restClient.SpotApi.{ExchangeData|Account|Trading}`
 - `restClient.UsdFuturesApi.{ExchangeData|Account|Trading}`
 - `restClient.CoinFuturesApi.{ExchangeData|Account|Trading}`
-- `restClient.GeneralApi.`{Brokerage|Futures|CryptoLoans|AutoInvest|Mining|SubAccount|Staking|SimpleEarn|CopyTrading|GiftCard|Nft}
+- `restClient.GeneralApi.{Brokerage|Futures|CryptoLoans|AutoInvest|Mining|SubAccount|Staking|SimpleEarn|CopyTrading|GiftCard|Nft}`
 - `socketClient.SpotApi.{ExchangeData|Account|Trading}` for WebSocket subscriptions and requests
 - `socketClient.UsdFuturesApi.{ExchangeData|Account|Trading}` for WebSocket subscriptions and requests
 - `socketClient.CoinFuturesApi.{ExchangeData|Account|Trading}` for WebSocket subscriptions
@@ -61,6 +62,7 @@ var socketClient = new BinanceSocketClient();
 var sub = await socketClient.SpotApi.ExchangeData.SubscribeToTickerUpdatesAsync(
     "BTCUSDT",
     update => { /* update.Data.LastPrice */ });
+if (!sub.Success) { /* sub.Error */ return; }
 
 // On shutdown:
 await socketClient.UnsubscribeAsync(sub.Data);

.github/copilot-instructions.md

@@ -12,6 +12,7 @@ Never generate `HttpClient` calls to `api.binance.com` or `fapi.binance.com`. Al
 
 ```csharp
 using Binance.Net.Clients;
+using Binance.Net;
 using Binance.Net.Objects;
 
 var restClient = new BinanceRestClient(options =>

CLAUDE.md

@@ -25,6 +25,7 @@ Always create the client via `BinanceRestClient`. For trading, configure credent
 
 ```csharp
 using Binance.Net.Clients;
+using Binance.Net;
 using Binance.Net.Objects;
 
 var restClient = new BinanceRestClient(options =>
@@ -102,8 +103,9 @@ var order = await restClient.UsdFuturesApi.Trading.PlaceOrderAsync(
     symbol: "ETHUSDT",
     side: OrderSide.Buy,
     type: FuturesOrderType.Market,
-    quantity: 0.1m,
-    positionSide: PositionSide.Long);
+    quantity: 0.1m);
+
+// In Hedge mode add positionSide: PositionSide.Long / PositionSide.Short.
 ```
 
 ## Core Pattern: WebSocket Subscriptions
@@ -148,6 +150,7 @@ For exchange-agnostic code, use the unified shared interfaces. Same code works a
 
 ```csharp
 using Binance.Net.Clients;
+using Binance.Net;
 using CryptoExchange.Net.SharedApis;
 
 var binanceShared = new BinanceRestClient().SpotApi.SharedClient;
@@ -166,13 +169,10 @@ Available shared client interfaces include: `ISpotTickerRestClient`, `ISpotOrder
 ```csharp
 using Binance.Net;
 
-services.AddBinance(restOptions =>
+services.AddBinance(options =>
 {
-    restOptions.ApiCredentials = new BinanceCredentials("API_KEY", "API_SECRET");
-},
-socketOptions =>
-{
-    socketOptions.ApiCredentials = new BinanceCredentials("API_KEY", "API_SECRET");
+    options.Rest.ApiCredentials = new BinanceCredentials("API_KEY", "API_SECRET");
+    options.Socket.ApiCredentials = new BinanceCredentials("API_KEY", "API_SECRET");
 });
 
 // Inject IBinanceRestClient and IBinanceSocketClient into your services.
@@ -192,7 +192,7 @@ socketOptions =>
 ## Environments
 
 ```csharp
-using Binance.Net.Objects;
+using Binance.Net;
 
 // Live (default)
 var live = new BinanceRestClient(o => o.Environment = BinanceEnvironment.Live);
@@ -206,11 +206,11 @@ var us = new BinanceRestClient(o => o.Environment = BinanceEnvironment.Us);
 
 ## When the user wants other Binance features
 
-- **Sub-accounts / Brokerage**: `restClient.SpotApi.SubAccount` and `Brokerage` namespaces
-- **Margin**: `restClient.SpotApi.Margin`
+- **Sub-accounts / Brokerage**: `restClient.GeneralApi.SubAccount` and `restClient.GeneralApi.Brokerage`
+- **Margin**: margin endpoints are under `restClient.SpotApi.Account` and `restClient.SpotApi.Trading`
 - **Wallet**: `restClient.SpotApi.Account` (deposit, withdrawal, asset details)
-- **Convert**: `restClient.SpotApi.Trading.ConvertAsync*`
-- **Portfolio Margin**: `restClient.SpotApi.PortfolioMargin`
+- **Convert**: `restClient.SpotApi.Trading.ConvertQuoteRequestAsync`, `ConvertAcceptQuoteAsync`, `GetConvertOrderStatusAsync`, etc.
+- **Portfolio Margin**: `restClient.SpotApi.Account.GetPortfolioMargin*` / `PortfolioMarginBankruptcyLoanRepayAsync`
 - **Options**: separate Options API (less commonly used)
 
 ## Reference

Examples/ai-friendly/01-spot-quickstart.cs

@@ -10,6 +10,7 @@
 //   Substitute API_KEY / API_SECRET below
 //   dotnet run
 
+using Binance.Net;
 using Binance.Net.Clients;
 using Binance.Net.Enums;
 using Binance.Net.Objects;

Examples/ai-friendly/02-futures.cs

@@ -6,6 +6,7 @@
 // Setup: dotnet add package Binance.Net
 // Substitute API_KEY / API_SECRET. The API key must have Futures trading enabled.
 
+using Binance.Net;
 using Binance.Net.Clients;
 using Binance.Net.Enums;
 using Binance.Net.Objects;
@@ -29,13 +30,12 @@
 
 // ---- 2. PLACE MARKET ORDER (open long position) ----
 // Market order — fills immediately at best available price.
-// PositionSide.Long required if account is in Hedge mode; ignore if One-way mode.
+// In Hedge mode add positionSide: PositionSide.Long.
 var openOrder = await client.UsdFuturesApi.Trading.PlaceOrderAsync(
     symbol: symbol,
     side: OrderSide.Buy,
     type: FuturesOrderType.Market,
-    quantity: 0.01m,
-    positionSide: PositionSide.Long);
+    quantity: 0.01m);
 
 if (!openOrder.Success)
 {
@@ -71,7 +71,6 @@
     side: OrderSide.Sell,
     type: FuturesOrderType.Market,
     quantity: Math.Abs(position.Quantity),
-    positionSide: PositionSide.Long,
     reduceOnly: true);
 
 if (closeOrder.Success)
@@ -84,5 +83,5 @@
 //   Stop-market:        type: FuturesOrderType.StopMarket, add stopPrice
 //   Take-profit:        type: FuturesOrderType.TakeProfitMarket, add stopPrice
 //   COIN-M futures:     use client.CoinFuturesApi.* (same API surface)
-//   Hedge vs One-way:   client.UsdFuturesApi.Account.ModifyPositionModeAsync(...)
+//   Hedge mode:         add positionSide: PositionSide.Long / PositionSide.Short to orders
 //   Margin type:        client.UsdFuturesApi.Account.ChangeMarginTypeAsync(symbol, FuturesMarginType.Isolated)

Examples/ai-friendly/03-websocket.cs

@@ -5,6 +5,7 @@
 //
 // Setup: dotnet add package Binance.Net
 
+using Binance.Net;
 using Binance.Net.Clients;
 using Binance.Net.Enums;
 using Binance.Net.Objects;
@@ -45,6 +46,13 @@
         }
     });
 
+if (!klineSub.Success)
+{
+    Console.WriteLine($"Failed to subscribe klines: {klineSub.Error}");
+    await publicSocket.UnsubscribeAsync(tickerSub.Data);
+    return;
+}
+
 // ---- 2. AUTHENTICATED SOCKET CLIENT — for user data ----
 // User data stream pushes order updates, balance changes, position updates.
 var authSocket = new BinanceSocketClient(options =>
@@ -70,6 +78,14 @@
         Console.WriteLine($"Asset {update.Data.Asset} delta: {update.Data.BalanceDelta}");
     });
 
+if (!userSub.Success)
+{
+    Console.WriteLine($"Failed to subscribe user data: {userSub.Error}");
+    await publicSocket.UnsubscribeAsync(tickerSub.Data);
+    await publicSocket.UnsubscribeAsync(klineSub.Data);
+    return;
+}
+
 Console.WriteLine("All subscriptions active. Press Enter to teardown...");
 Console.ReadLine();
 

Examples/ai-friendly/04-multi-exchange.cs

@@ -78,12 +78,13 @@ async Task PrintTicker(ISpotTickerRestClient client, SharedSymbol symbol)
 if (!sub.Success)
 {
     Console.WriteLine($"Subscribe failed: {sub.Error}");
+    return;
 }
 
 Console.WriteLine("Press Enter to exit");
 Console.ReadLine();
 
-await binanceTickerSocket.UnsubscribeAsync(sub.Data);
+await sub.Data.UnsubscribeAsync();
 
 // Common variations:
 //   Multi-exchange arbitrage:  loop over List<ISpotTickerRestClient>, find max bid / min ask

Examples/ai-friendly/05-error-handling.cs

@@ -4,9 +4,11 @@
 //
 // Setup: dotnet add package Binance.Net
 
+using Binance.Net;
 using Binance.Net.Clients;
 using Binance.Net.Enums;
 using Binance.Net.Objects;
+using CryptoExchange.Net.Objects;
 
 var client = new BinanceRestClient(options =>
 {
@@ -77,7 +79,9 @@ async Task<WebCallResult<T>> WithRetry<T>(
 //
 //      var symbols = await client.SpotApi.ExchangeData.GetExchangeInfoAsync();
 //      var symInfo = symbols.Data.Symbols.First(s => s.Name == "BTCUSDT");
-//      var validQty = ExchangeHelpers.AdjustValueStep(rawQty, symInfo.LotSizeFilter!.StepSize);
+//      var lotSize = symInfo.LotSizeFilter!;
+//      var validQty = ExchangeHelpers.AdjustValueStep(
+//          lotSize.MinQuantity, lotSize.MaxQuantity, lotSize.StepSize, RoundingType.Floor, rawQty);
 //
 // Code -1022 ("Signature for this request is not valid"):
 //   API key / secret mismatch, or trying to use Spot key for Futures endpoint.
@@ -88,7 +92,7 @@ async Task<WebCallResult<T>> WithRetry<T>(
 
 // ---- 4. ORDER PLACEMENT WITH FILTER VALIDATION ----
 var exchangeInfo = await client.SpotApi.ExchangeData.GetExchangeInfoAsync("BTCUSDT");
-if (!exchangeInfo.Success || exchangeInfo.Data.Symbols.Count == 0)
+if (!exchangeInfo.Success || exchangeInfo.Data.Symbols.Length == 0)
 {
     Console.WriteLine("Cannot fetch symbol info — aborting order");
     return;
@@ -99,7 +103,12 @@ async Task<WebCallResult<T>> WithRetry<T>(
 
 // Round to allowed step size to avoid -1013 LOT_SIZE error
 decimal validQuantity = symbol.LotSizeFilter != null
-    ? CryptoExchange.Net.ExchangeHelpers.AdjustValueStep(rawQuantity, symbol.LotSizeFilter.StepSize)
+    ? CryptoExchange.Net.ExchangeHelpers.AdjustValueStep(
+        symbol.LotSizeFilter.MinQuantity,
+        symbol.LotSizeFilter.MaxQuantity,
+        symbol.LotSizeFilter.StepSize,
+        RoundingType.Floor,
+        rawQuantity)
     : rawQuantity;
 
 var order = await client.SpotApi.Trading.PlaceOrderAsync(