Qualify link list query aliases

Author: JLG-WOCFR-DEV

liens-morts-detector-jlg/includes/class-blc-links-list-table.php

@@ -1103,17 +1103,17 @@ public function prepare_items($data = null, $total_items_override = null) {
         $params = [];
 
         if (count($type_filter) === 1) {
-            $where[] = 'type = %s';
+            $where[] = "{$links_alias}.type = %s";
             $params[] = $type_filter[0];
         } else {
             $type_placeholders = implode(',', array_fill(0, count($type_filter), '%s'));
-            $where[] = "type IN ($type_placeholders)";
+            $where[] = "{$links_alias}.type IN ($type_placeholders)";
             $params = array_merge($params, $type_filter);
         }
 
         if ($search_term !== '') {
             $like = '%' . $wpdb->esc_like($search_term) . '%';
-            $where[] = "(url LIKE %s OR anchor LIKE %s OR post_title LIKE %s)";
+            $where[] = "({$links_alias}.url LIKE %s OR {$links_alias}.anchor LIKE %s OR {$links_alias}.post_title LIKE %s)";
             $params  = array_merge($params, [$like, $like, $like]);
         }
 
@@ -1123,28 +1123,28 @@ public function prepare_items($data = null, $total_items_override = null) {
         }
 
         if ($is_ignored_view) {
-            $where[] = 'ignored_at IS NOT NULL';
+            $where[] = "{$links_alias}.ignored_at IS NOT NULL";
         } else {
-            $where[] = 'ignored_at IS NULL';
+            $where[] = "{$links_alias}.ignored_at IS NULL";
         }
 
         if ($current_view === 'internal') {
-            $where[] = "(is_internal = 1 OR (is_internal IS NULL AND {$internal_sql}))";
+            $where[] = "({$links_alias}.is_internal = 1 OR ({$links_alias}.is_internal IS NULL AND {$internal_sql}))";
             $params  = array_merge($params, $internal_params);
         } elseif ($current_view === 'external') {
-            $external_clause = "(is_internal = 0 OR (is_internal IS NULL AND ({$external_sql} OR url IS NULL OR url = '')))";
+            $external_clause = "({$links_alias}.is_internal = 0 OR ({$links_alias}.is_internal IS NULL AND ({$external_sql} OR {$links_alias}.url IS NULL OR {$links_alias}.url = '')))";
             $where[] = $external_clause;
             $params  = array_merge($params, $external_params);
         }
 
-        $needs_recheck_clause = "(last_checked_at IS NULL OR last_checked_at = %s OR last_checked_at <= %s)";
+        $needs_recheck_clause = "({$links_alias}.last_checked_at IS NULL OR {$links_alias}.last_checked_at = %s OR {$links_alias}.last_checked_at <= %s)";
 
         if ($current_view === 'status_404_410') {
-            $where[] = 'http_status IN (404, 410)';
+            $where[] = "{$links_alias}.http_status IN (404, 410)";
         } elseif ($current_view === 'status_5xx') {
-            $where[] = '(http_status BETWEEN 500 AND 599)';
+            $where[] = "({$links_alias}.http_status BETWEEN 500 AND 599)";
         } elseif ($current_view === 'status_redirects') {
-            $where[] = '(http_status BETWEEN 300 AND 399)';
+            $where[] = "({$links_alias}.http_status BETWEEN 300 AND 399)";
         } elseif ($current_view === 'needs_recheck') {
             $where[] = $needs_recheck_clause;
             $params = array_merge($params, [$this->get_unchecked_sentinel_value(), $this->get_recheck_threshold_gmt()]);
@@ -1171,13 +1171,16 @@ public function prepare_items($data = null, $total_items_override = null) {
             }
 
             if ($db_column !== '') {
+                if (strpos($db_column, '.') === false) {
+                    $db_column = "{$links_alias}.{$db_column}";
+                }
                 $whitelisted_columns[$column_key] = $db_column;
             }
         }
 
-        $whitelisted_columns['id'] = 'id';
+        $whitelisted_columns['id'] = "{$links_alias}.id";
         if ($is_ignored_view) {
-            $whitelisted_columns['ignored_at'] = 'ignored_at';
+            $whitelisted_columns['ignored_at'] = "{$links_alias}.ignored_at";
         }
 
         $sort_request = $this->get_current_sort_request();
@@ -1188,13 +1191,15 @@ public function prepare_items($data = null, $total_items_override = null) {
             $primary_order_column = $whitelisted_columns[$requested_orderby];
             $order_clauses = [sprintf('%s %s', $primary_order_column, $order_direction)];
 
-            if ($primary_order_column !== 'id') {
-                $order_clauses[] = 'id DESC';
+            if ($primary_order_column !== "{$links_alias}.id") {
+                $order_clauses[] = "{$links_alias}.id DESC";
             }
 
             $order_by = implode(', ', $order_clauses);
         } else {
-            $fallback_order = $is_ignored_view ? ['ignored_at DESC', 'id DESC'] : ['id DESC'];
+            $fallback_order = $is_ignored_view
+                ? ["{$links_alias}.ignored_at DESC", "{$links_alias}.id DESC"]
+                : ["{$links_alias}.id DESC"];
             $order_by = implode(', ', $fallback_order);
         }