Skip to content

Commit 8d5d6f3

Browse files
Merge pull request #407 from JLG-WOCFR-DEV/codex/fix-advanced-mode-functionality
Open advanced settings group by default
2 parents fd11ee2 + e52432c commit 8d5d6f3

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

liens-morts-detector-jlg/includes/blc-admin-pages.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4419,7 +4419,7 @@ function blc_render_settings_sections_grouped($page) {
44194419
$personas = blc_get_settings_persona_presets();
44204420

44214421
ob_start();
4422-
echo '<details class="blc-settings-group blc-settings-group--collapsible" aria-labelledby="blc-settings-advanced-heading">';
4422+
echo '<details class="blc-settings-group blc-settings-group--collapsible" aria-labelledby="blc-settings-advanced-heading" open>';
44234423
echo '<summary class="blc-settings-group__summary">';
44244424
echo '<span id="blc-settings-advanced-heading" class="blc-settings-group__title">' . esc_html__('Réglages avancés', 'liens-morts-detector-jlg') . '</span>';
44254425
echo '<span class="blc-settings-group__description">' . esc_html__('Optimisez les performances, heuristiques et intégrations externes.', 'liens-morts-detector-jlg') . '</span>';

tests/js/__tests__/blc-admin-scripts.test.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ describe('settings mode toggle', () => {
317317
<div class="blc-settings-groups__advanced" data-blc-settings-advanced-placeholder></div>
318318
</div>
319319
<script type="text/template" id="blc-settings-advanced-template">
320-
<details class="blc-settings-group blc-settings-group--collapsible">
320+
<details class="blc-settings-group blc-settings-group--collapsible" open>
321321
<summary class="blc-settings-group__summary">
322322
<span class="blc-settings-group__title">Réglages avancés</span>
323323
<span class="blc-settings-group__description">Optimisez les performances.</span>
@@ -431,6 +431,9 @@ describe('settings mode toggle', () => {
431431
expect(button.getAttribute('aria-checked')).toBe('true');
432432
expect(document.querySelector('[data-current-mode="advanced"]')).not.toBeNull();
433433
expect(placeholder.querySelector('.blc-settings-advanced')).not.toBeNull();
434+
const advancedDetails = placeholder.querySelector('details');
435+
expect(advancedDetails).not.toBeNull();
436+
expect(advancedDetails.hasAttribute('open')).toBe(true);
434437
expect(initAdvancedSettingsSpy).toHaveBeenCalledTimes(1);
435438
expect(window.wp.a11y.speak).toHaveBeenCalledWith('Mode avancé activé. Les réglages supplémentaires sont visibles.', 'polite');
436439
});

0 commit comments

Comments
 (0)