Merge pull request #423 from JLG-WOCFR-DEV/codex/fix-redeclaration-of-blc_sanitize_surveillance_thresholds_op

Prevent duplicate surveillance threshold sanitizers

Author: JLG-WOCFR-DEV

liens-morts-detector-jlg/includes/blc-settings-fields.php

@@ -4756,85 +4756,14 @@ function blc_sanitize_notification_status_filters_option($value) {
  *
  * @return array{global:array<int,array<string,mixed>>,taxonomy:array<int,array<string,mixed>>}
  */
-function blc_sanitize_surveillance_thresholds_option($value) {
-    $structured = array(
-        'global'   => array(),
-        'taxonomy' => array(),
-    );
-
-    if (is_array($value)) {
-        if (isset($value['global']) && is_array($value['global'])) {
-            foreach ($value['global'] as $definition) {
-                if (!is_array($definition)) {
-                    continue;
-                }
-
-                $structured['global'][] = array(
-                    'id'         => isset($definition['id']) ? (string) $definition['id'] : '',
-                    'metric'     => isset($definition['metric']) ? (string) $definition['metric'] : 'broken_ratio',
-                    'comparison' => isset($definition['comparison']) ? (string) $definition['comparison'] : 'gte',
-                    'threshold'  => isset($definition['threshold']) ? (float) $definition['threshold'] : 0.0,
-                    'label'      => isset($definition['label']) ? (string) $definition['label'] : '',
-                    'severity'   => isset($definition['severity']) ? (string) $definition['severity'] : 'warning',
-                );
-            }
-        }
-
-        if (isset($value['taxonomy']) && is_array($value['taxonomy'])) {
-            foreach ($value['taxonomy'] as $definition) {
-                if (!is_array($definition)) {
-                    continue;
-                }
-
-                $taxonomy = isset($definition['taxonomy']) ? (string) $definition['taxonomy'] : '';
-                $taxonomy = blc_surveillance_sanitize_key($taxonomy);
-                if ($taxonomy === '') {
-                    continue;
-                }
-
-                $apply_to_all = !empty($definition['apply_to_all_terms']);
-                $term_ids = array();
-
-                if (!$apply_to_all && isset($definition['term_ids'])) {
-                    $raw = $definition['term_ids'];
-                    if (is_string($raw)) {
-                        $parts = preg_split('/[,\s]+/', $raw);
-                    } elseif (is_array($raw)) {
-                        $parts = $raw;
-                    } else {
-                        $parts = array();
-                    }
+if (!function_exists('blc_sanitize_surveillance_thresholds_option')) {
+    function blc_sanitize_surveillance_thresholds_option($value) {
+        $normalized = blc_normalize_surveillance_thresholds($value);
 
-                    foreach ($parts as $part) {
-                        $term_id = (int) $part;
-                        if ($term_id > 0) {
-                            $term_ids[] = $term_id;
-                        }
-                    }
-                }
+        blc_save_surveillance_thresholds($normalized);
 
-                if (!$apply_to_all && $term_ids === array()) {
-                    continue;
-                }
-
-                $structured['taxonomy'][] = array(
-                    'id'                => isset($definition['id']) ? (string) $definition['id'] : '',
-                    'taxonomy'          => $taxonomy,
-                    'threshold'         => isset($definition['threshold']) ? (float) $definition['threshold'] : 0.0,
-                    'comparison'        => isset($definition['comparison']) ? (string) $definition['comparison'] : 'gte',
-                    'label'             => isset($definition['label']) ? (string) $definition['label'] : '',
-                    'severity'          => isset($definition['severity']) ? (string) $definition['severity'] : 'warning',
-                    'term_ids'          => $term_ids,
-                    'apply_to_all_terms'=> $apply_to_all,
-                );
-            }
-        }
+        return $normalized;
     }
-
-    $normalized = blc_normalize_surveillance_thresholds($structured);
-    blc_save_surveillance_thresholds($normalized);
-
-    return $normalized;
 }
 
 /**
@@ -5139,142 +5068,6 @@ function blc_get_surveillance_severity_options() {
 }
 }
 
-/**
- * Sanitize the surveillance thresholds option payload.
- *
- * @param mixed $value Raw value.
- *
- * @return array<string,mixed>
- */
-function blc_sanitize_surveillance_thresholds_option($value) {
-    return blc_normalize_surveillance_thresholds($value);
-}
-
-/**
- * Sanitize the list of severity levels enabled for a channel.
- *
- * @param mixed $value Raw value.
- *
- * @return array<int,string>
- */
-function blc_sanitize_surveillance_escalation_levels_option($value) {
-    $options = blc_get_surveillance_severity_options();
-
-    if (is_string($value)) {
-        $value = array($value);
-    }
-
-    if (!is_array($value)) {
-        $value = array();
-    }
-
-    $normalized = array();
-
-    foreach ($value as $candidate) {
-        if (!is_scalar($candidate)) {
-            continue;
-        }
-
-        $slug = sanitize_key((string) $candidate);
-        if ($slug === '' || !isset($options[$slug])) {
-            continue;
-        }
-
-        $normalized[$slug] = $slug;
-    }
-
-    return array_values($normalized);
-}
-
-/**
- * Sanitize the cooldown (seconds) configured for a severity.
- *
- * @param mixed $value Raw value.
- *
- * @return int
- */
-function blc_sanitize_surveillance_cooldown_option($value) {
-    $value = is_numeric($value) ? (int) $value : 0;
-
-    if ($value < 60) {
-        $value = 60;
-    }
-
-    return $value;
-}
-
-/**
- * Retrieve the available taxonomy choices for surveillance thresholds.
- *
- * @return array<string,string>
- */
-if (!function_exists('blc_get_surveillance_taxonomy_choices')) {
-function blc_get_surveillance_taxonomy_choices() {
-    $choices = array();
-
-    if (function_exists('get_taxonomies')) {
-        $taxonomies = get_taxonomies(array('public' => true), 'objects');
-
-        if (is_array($taxonomies)) {
-            foreach ($taxonomies as $taxonomy => $object) {
-                $label = isset($object->labels->singular_name) ? (string) $object->labels->singular_name : $taxonomy;
-                $choices[$taxonomy] = $label;
-            }
-        }
-    }
-
-    if ($choices === array()) {
-        $choices['category'] = __('Catégories', 'liens-morts-detector-jlg');
-        $choices['post_tag'] = __('Étiquettes', 'liens-morts-detector-jlg');
-    }
-
-    return $choices;
-}
-}
-
-/**
- * Return the available comparison operators for surveillance thresholds.
- *
- * @return array<string,string>
- */
-if (!function_exists('blc_get_surveillance_comparison_options')) {
-function blc_get_surveillance_comparison_options() {
-    return array(
-        'gte' => __('≥ (supérieur ou égal)', 'liens-morts-detector-jlg'),
-        'gt'  => __('> (strictement supérieur)', 'liens-morts-detector-jlg'),
-        'lte' => __('≤ (inférieur ou égal)', 'liens-morts-detector-jlg'),
-        'lt'  => __('< (strictement inférieur)', 'liens-morts-detector-jlg'),
-        'eq'  => __('= (égal à)', 'liens-morts-detector-jlg'),
-        'neq' => __('≠ (différent de)', 'liens-morts-detector-jlg'),
-    );
-}
-}
-
-/**
- * Return the severity labels for surveillance alerts.
- *
- * @return array<string,string>
- */
-if (!function_exists('blc_get_surveillance_severity_options')) {
-function blc_get_surveillance_severity_options() {
-    return array(
-        'warning'  => __('Avertissement', 'liens-morts-detector-jlg'),
-        'critical' => __('Critique', 'liens-morts-detector-jlg'),
-    );
-}
-}
-
-/**
- * Sanitize the surveillance thresholds option payload.
- *
- * @param mixed $value Raw value.
- *
- * @return array<string,mixed>
- */
-function blc_sanitize_surveillance_thresholds_option($value) {
-    return blc_normalize_surveillance_thresholds($value);
-}
-
 /**
  * Sanitize the list of severity levels enabled for a channel.
  *