Skip to content

Commit e1f1550

Browse files
Merge pull request #262 from JLG-WOCFR-DEV/codex/add-closebutton-key-and-update-modal-behavior
Add localized close text for context modal
2 parents af3bbb9 + e4ca15c commit e1f1550

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

liens-morts-detector-jlg/assets/js/blc-admin-scripts.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ jQuery(document).ready(function($) {
1212
unlinkModalTitle: 'Supprimer le lien',
1313
unlinkModalConfirm: 'Supprimer',
1414
cancelButton: 'Annuler',
15+
closeButton: 'Fermer',
1516
closeLabel: 'Fermer la fenêtre modale',
1617
emptyUrlMessage: 'Veuillez saisir une URL.',
1718
invalidUrlMessage: 'Veuillez saisir une URL valide.',
@@ -370,6 +371,7 @@ jQuery(document).ready(function($) {
370371
isOpen: false,
371372
onConfirm: null,
372373
showInput: true,
374+
showCancel: true,
373375
isSubmitting: false
374376
};
375377

@@ -461,6 +463,7 @@ jQuery(document).ready(function($) {
461463
state.isOpen = false;
462464
state.onConfirm = null;
463465
state.showInput = true;
466+
state.showCancel = true;
464467

465468
$modal.removeClass('is-open').attr('aria-hidden', 'true');
466469
$('body').removeClass('blc-modal-open');
@@ -501,6 +504,7 @@ jQuery(document).ready(function($) {
501504

502505
state.onConfirm = typeof options.onConfirm === 'function' ? options.onConfirm : null;
503506
state.showInput = options.showInput !== false;
507+
state.showCancel = options.showCancel !== false;
504508

505509
lastFocusedElement = document.activeElement;
506510

@@ -527,7 +531,14 @@ jQuery(document).ready(function($) {
527531
}
528532
$confirm.text(confirmText || messages.editModalConfirm || 'Confirmer');
529533

530-
$cancel.text(options.cancelText || messages.cancelButton || 'Annuler');
534+
var cancelText = options.cancelText || messages.cancelButton || 'Annuler';
535+
$cancel.text(cancelText);
536+
537+
if (state.showCancel) {
538+
$cancel.show().prop('hidden', false).removeAttr('hidden').removeAttr('aria-hidden');
539+
} else {
540+
$cancel.hide().prop('hidden', true).attr('hidden', 'hidden').attr('aria-hidden', 'true');
541+
}
531542
$close.attr('aria-label', options.closeLabel || messages.closeLabel || 'Fermer');
532543

533544
clearError();
@@ -1166,8 +1177,8 @@ jQuery(document).ready(function($) {
11661177
title: messages.contextModalTitle || '',
11671178
message: '',
11681179
showInput: false,
1169-
confirmText: messages.cancelButton || 'Fermer',
1170-
cancelText: messages.cancelButton || 'Fermer',
1180+
showCancel: false,
1181+
confirmText: messages.closeButton || messages.cancelButton || 'Fermer',
11711182
closeLabel: messages.closeLabel,
11721183
context: contextExcerpt,
11731184
contextHtml: contextHtml,

liens-morts-detector-jlg/liens-morts-detector-jlg.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ function blc_enqueue_admin_assets($hook) {
169169
'unlinkModalTitle' => __('Supprimer le lien', 'liens-morts-detector-jlg'),
170170
'unlinkModalConfirm' => __('Supprimer', 'liens-morts-detector-jlg'),
171171
'cancelButton' => __('Annuler', 'liens-morts-detector-jlg'),
172+
'closeButton' => __('Fermer', 'liens-morts-detector-jlg'),
172173
'closeLabel' => __('Fermer la fenêtre modale', 'liens-morts-detector-jlg'),
173174
'emptyUrlMessage' => __('Veuillez saisir une URL.', 'liens-morts-detector-jlg'),
174175
'invalidUrlMessage' => __('Veuillez saisir une URL valide.', 'liens-morts-detector-jlg'),

0 commit comments

Comments
 (0)