fix: allow Parameters like $1,$2

manticore-projects · manticore-projects · commit 17f5f2ad680d · 2024-02-23T08:32:34.000+07:00
- fixes #1970 Signed-off-by: Andreas Reichel <andreas@manticore-projects.com>
diff --git a/src/main/java/net/sf/jsqlparser/expression/JdbcParameter.java b/src/main/java/net/sf/jsqlparser/expression/JdbcParameter.java
@@ -11,20 +11,43 @@
 
 import net.sf.jsqlparser.parser.ASTNodeAccessImpl;
 
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
 /**
  * A '?' in a statement or a ?&lt;number&gt; e.g. ?4
  */
 public class JdbcParameter extends ASTNodeAccessImpl implements Expression {
 
+    private String parameterCharacter = "?";
     private Integer index;
     private boolean useFixedIndex = false;
 
-    public JdbcParameter() {
-    }
+    public JdbcParameter() {}
 
-    public JdbcParameter(Integer index, boolean useFixedIndex) {
+    public JdbcParameter(Integer index, boolean useFixedIndex, String parameterCharacter) {
         this.index = index;
         this.useFixedIndex = useFixedIndex;
+        this.parameterCharacter = parameterCharacter;
+
+        // This is needed for Parameters starting with "$" like "$2"
+        // Those will contain the index in the parameterCharacter
+        final Pattern pattern = Pattern.compile("(\\$)(\\d*)");
+        final Matcher matcher = pattern.matcher(parameterCharacter);
+        if (matcher.find() && matcher.groupCount() == 2) {
+            this.useFixedIndex = true;
+            this.parameterCharacter = matcher.group(1);
+            this.index = Integer.valueOf(matcher.group(2));
+        }
+    }
+
+    public String getParameterCharacter() {
+        return parameterCharacter;
+    }
+
+    public JdbcParameter setParameterCharacter(String parameterCharacter) {
+        this.parameterCharacter = parameterCharacter;
+        return this;
     }
 
     public Integer getIndex() {
@@ -50,7 +73,7 @@ public void accept(ExpressionVisitor expressionVisitor) {
 
     @Override
     public String toString() {
-        return useFixedIndex ? "?" + index : "?";
+        return useFixedIndex ? parameterCharacter + index : parameterCharacter;
     }
 
     public JdbcParameter withIndex(Integer index) {
diff --git a/src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java b/src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java
@@ -328,7 +328,7 @@ public void visit(IsBooleanExpression isBooleanExpression) {
 
     @Override
     public void visit(JdbcParameter jdbcParameter) {
-        buffer.append("?");
+        buffer.append(jdbcParameter.getParameterCharacter());
         if (jdbcParameter.isUseFixedIndex()) {
             buffer.append(jdbcParameter.getIndex());
         }
diff --git a/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt b/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
@@ -530,6 +530,8 @@ SPECIAL_TOKEN:
 
 TOKEN:
 {
+<S_PARAMETER: ["$"] (["0"-"9"])+ >
+|
 <S_IDENTIFIER: <LETTER> (<PART_LETTER>)*>
 |   <#LETTER: <UnicodeIdentifierStart>
                 | <Nd> | [ "$" , "#", "_" ] // Not SQL:2016 compliant!
@@ -3126,27 +3128,20 @@ OrderByElement OrderByElement():
     }
 }
 
-JdbcParameter SimpleJdbcParameter() : {
+JdbcParameter JdbcParameter() : {
+    Token tk;
     JdbcParameter retval;
 }
 {
-    "?" { retval = new JdbcParameter(++jdbcParameterIndex, false); }
-		[ LOOKAHEAD(2) token = <S_LONG> { retval.setUseFixedIndex(true); retval.setIndex(Integer.valueOf(token.image)); } ]
-    {
-        return retval;
-    }
-}
+    ( tk="?" | tk=<S_PARAMETER> )
+    { retval = new JdbcParameter(++jdbcParameterIndex, false, tk.image); }
 
-JdbcNamedParameter SimpleJdbcNamedParameter() : {
-    String name;
-}
-{
-    ":" name = RelObjectNameExt()
-    {
-        return new JdbcNamedParameter(token.image);
-    }
+    [ LOOKAHEAD(2) token = <S_LONG> { retval.setUseFixedIndex(true); retval.setIndex(Integer.valueOf(token.image)); } ]
+
+    { return retval; }
 }
 
+
 Limit LimitWithOffset() #LimitWithOffset:
 {
     Limit limit = new Limit();
@@ -3323,7 +3318,7 @@ Top Top():
     (
          token=<S_LONG>                      { top.setExpression(new LongValue(token.image)); }
        |
-         jdbc = SimpleJdbcParameter() { top.setExpression(jdbc); }
+         jdbc = JdbcParameter() { top.setExpression(jdbc); }
          /*"?"                                 { top.setExpression(new JdbcParameter(++jdbcParameterIndex, false)); } [ LOOKAHEAD(2) token = <S_LONG> { ((JdbcParameter)(top.getExpression())).setUseFixedIndex(true); ((JdbcParameter)(top.getExpression())).setIndex(Integer.valueOf(token.image)); } ]*/
        |
        ":"                                  { top.setExpression(new JdbcNamedParameter()); } [ LOOKAHEAD(2) token = <S_IDENTIFIER> { ((JdbcNamedParameter)top.getExpression()).setName(token.image); } ]
@@ -3354,7 +3349,7 @@ Skip Skip():
     (
          token=<S_LONG>                      { skip.setRowCount(Long.parseLong(token.image)); }
                 | token=<S_IDENTIFIER>              { skip.setVariable(token.image); }
-                | jdbc = SimpleJdbcParameter() { skip.setJdbcParameter(jdbc); }
+                | jdbc = JdbcParameter() { skip.setJdbcParameter(jdbc); }
                    /* "?" { skip.setJdbcParameter(new JdbcParameter(++jdbcParameterIndex, false)); } [ LOOKAHEAD(2) token = <S_LONG> { skip.getJdbcParameter().setUseFixedIndex(true); skip.getJdbcParameter().setIndex(Integer.valueOf(token.image)); } ] */
     )
     {
@@ -3396,7 +3391,7 @@ First First():
         |
         token=<S_IDENTIFIER> { first.setVariable(token.image); }
         |
-        jdbc = SimpleJdbcParameter() { first.setJdbcParameter(jdbc); }
+        jdbc = JdbcParameter() { first.setJdbcParameter(jdbc); }
     )
     {
         return first;
@@ -4235,9 +4230,9 @@ Expression PrimaryExpression() #PrimaryExpression:
 
         | LOOKAHEAD(3, {!interrupted}) retval=CaseWhenExpression()
 
-        | LOOKAHEAD(3) retval = SimpleJdbcParameter()
+        | retval = JdbcParameter()
 
-        | LOOKAHEAD(2) retval=JdbcNamedParameter()
+        | LOOKAHEAD(2) retval =JdbcNamedParameter()
 
         | LOOKAHEAD(3) retval=UserVariable()
 
@@ -4758,7 +4753,7 @@ IntervalExpression IntervalExpression() : {
 {
 
 { interval = new IntervalExpression(); }
-    <K_INTERVAL> ["-" {signed=true;}] (token=<S_LONG> | token=<S_DOUBLE> | token=<S_CHAR_LITERAL> | LOOKAHEAD(SimpleJdbcParameter()) expr = SimpleJdbcParameter() | expr = JdbcNamedParameter() | LOOKAHEAD(Function()) expr = Function() | expr = Column())
+    <K_INTERVAL> ["-" {signed=true;}] (token=<S_LONG> | token=<S_DOUBLE> | token=<S_CHAR_LITERAL> | LOOKAHEAD(JdbcParameter()) expr = JdbcParameter() | expr = JdbcNamedParameter() | LOOKAHEAD(Function()) expr = Function() | expr = Column())
     {
         if (expr != null) {
             if (signed) expr = new SignedExpression('-', expr);
@@ -5099,9 +5094,9 @@ FullTextSearch FullTextSearch() : {
     (
       againstValue=<S_CHAR_LITERAL> { fs.setAgainstValue(new StringValue(againstValue.image)); }
       |
-      jdbcParameter=SimpleJdbcParameter() { fs.setAgainstValue(  jdbcParameter ); }
+      jdbcParameter=JdbcParameter() { fs.setAgainstValue(  jdbcParameter ); }
       |
-      jdbcNamedParameter=SimpleJdbcNamedParameter() { fs.setAgainstValue(  jdbcNamedParameter ); }
+      jdbcNamedParameter=JdbcNamedParameter() { fs.setAgainstValue(  jdbcNamedParameter ); }
     )
     [
         (
diff --git a/src/test/java/net/sf/jsqlparser/expression/JdbcNamedParameterTest.java b/src/test/java/net/sf/jsqlparser/expression/JdbcNamedParameterTest.java
@@ -11,8 +11,10 @@
 
 import net.sf.jsqlparser.JSQLParserException;
 import net.sf.jsqlparser.expression.operators.arithmetic.BitwiseAnd;
+import net.sf.jsqlparser.expression.operators.relational.EqualsTo;
 import net.sf.jsqlparser.statement.select.PlainSelect;
 import net.sf.jsqlparser.test.TestUtils;
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -39,4 +41,16 @@ void testIssue1785() throws JSQLParserException {
                 + "where owner = &myowner";
         TestUtils.assertSqlCanBeParsedAndDeparsed(sqlStr, true);
     }
+
+    @Test
+    void testIssue1970() throws JSQLParserException {
+        String sqlStr = "SELECT a from tbl where col = $2";
+        PlainSelect select = (PlainSelect) TestUtils.assertSqlCanBeParsedAndDeparsed(sqlStr, true);
+
+        EqualsTo where = (EqualsTo) select.getWhere();
+        Assertions.assertInstanceOf(JdbcParameter.class, where.getRightExpression());
+
+        JdbcParameter p = (JdbcParameter) where.getRightExpression();
+        Assertions.assertEquals(2, p.getIndex());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ public void visit(IsBooleanExpression isBooleanExpression) {`
`328`	`328`
`329`	`329`	`@Override`
`330`	`330`	`public void visit(JdbcParameter jdbcParameter) {`
`331`		`- buffer.append("?");`
	`331`	`+ buffer.append(jdbcParameter.getParameterCharacter());`
`332`	`332`	`if (jdbcParameter.isUseFixedIndex()) {`
`333`	`333`	`buffer.append(jdbcParameter.getIndex());`
`334`	`334`	`}`
Original file line number	Diff line number	Diff line change
`@@ -530,6 +530,8 @@ SPECIAL_TOKEN:`
`530`	`530`
`531`	`531`	`TOKEN:`
`532`	`532`	`{`
	`533`	`+<S_PARAMETER: ["$"] (["0"-"9"])+ >`
	`534`	`+\|`
`533`	`535`	`<S_IDENTIFIER: <LETTER> (<PART_LETTER>)*>`
`534`	`536`	`\| <#LETTER: <UnicodeIdentifierStart>`
`535`	`537`	`\| <Nd> \| [ "$" , "#", "_" ] // Not SQL:2016 compliant!`
`@@ -3126,27 +3128,20 @@ OrderByElement OrderByElement():`
`3126`	`3128`	`}`
`3127`	`3129`	`}`
`3128`	`3130`
`3129`		`-JdbcParameter SimpleJdbcParameter() : {`
	`3131`	`+JdbcParameter JdbcParameter() : {`
	`3132`	`+ Token tk;`
`3130`	`3133`	`JdbcParameter retval;`
`3131`	`3134`	`}`
`3132`	`3135`	`{`
`3133`		`- "?" { retval = new JdbcParameter(++jdbcParameterIndex, false); }`
`3134`		`- [ LOOKAHEAD(2) token = <S_LONG> { retval.setUseFixedIndex(true); retval.setIndex(Integer.valueOf(token.image)); } ]`
`3135`		`- {`
`3136`		`- return retval;`
`3137`		`- }`
`3138`		`-}`
	`3136`	`+ ( tk="?" \| tk=<S_PARAMETER> )`
	`3137`	`+ { retval = new JdbcParameter(++jdbcParameterIndex, false, tk.image); }`
`3139`	`3138`
`3140`		`-JdbcNamedParameter SimpleJdbcNamedParameter() : {`
`3141`		`- String name;`
`3142`		`-}`
`3143`		`-{`
`3144`		`- ":" name = RelObjectNameExt()`
`3145`		`- {`
`3146`		`- return new JdbcNamedParameter(token.image);`
`3147`		`- }`
	`3139`	`+ [ LOOKAHEAD(2) token = <S_LONG> { retval.setUseFixedIndex(true); retval.setIndex(Integer.valueOf(token.image)); } ]`
	`3140`	`+`
	`3141`	`+ { return retval; }`
`3148`	`3142`	`}`
`3149`	`3143`
	`3144`	`+`
`3150`	`3145`	`Limit LimitWithOffset() #LimitWithOffset:`
`3151`	`3146`	`{`
`3152`	`3147`	`Limit limit = new Limit();`
`@@ -3323,7 +3318,7 @@ Top Top():`
`3323`	`3318`	`(`
`3324`	`3319`	`token=<S_LONG> { top.setExpression(new LongValue(token.image)); }`
`3325`	`3320`	`\|`
`3326`		`- jdbc = SimpleJdbcParameter() { top.setExpression(jdbc); }`
	`3321`	`+ jdbc = JdbcParameter() { top.setExpression(jdbc); }`
`3327`	`3322`	`/"?" { top.setExpression(new JdbcParameter(++jdbcParameterIndex, false)); } [ LOOKAHEAD(2) token = <S_LONG> { ((JdbcParameter)(top.getExpression())).setUseFixedIndex(true); ((JdbcParameter)(top.getExpression())).setIndex(Integer.valueOf(token.image)); } ]/`
`3328`	`3323`	`\|`
`3329`	`3324`	`":" { top.setExpression(new JdbcNamedParameter()); } [ LOOKAHEAD(2) token = <S_IDENTIFIER> { ((JdbcNamedParameter)top.getExpression()).setName(token.image); } ]`
`@@ -3354,7 +3349,7 @@ Skip Skip():`
`3354`	`3349`	`(`
`3355`	`3350`	`token=<S_LONG> { skip.setRowCount(Long.parseLong(token.image)); }`
`3356`	`3351`	`\| token=<S_IDENTIFIER> { skip.setVariable(token.image); }`
`3357`		`- \| jdbc = SimpleJdbcParameter() { skip.setJdbcParameter(jdbc); }`
	`3352`	`+ \| jdbc = JdbcParameter() { skip.setJdbcParameter(jdbc); }`
`3358`	`3353`	`/* "?" { skip.setJdbcParameter(new JdbcParameter(++jdbcParameterIndex, false)); } [ LOOKAHEAD(2) token = <S_LONG> { skip.getJdbcParameter().setUseFixedIndex(true); skip.getJdbcParameter().setIndex(Integer.valueOf(token.image)); } ] */`
`3359`	`3354`	`)`
`3360`	`3355`	`{`
`@@ -3396,7 +3391,7 @@ First First():`
`3396`	`3391`	`\|`
`3397`	`3392`	`token=<S_IDENTIFIER> { first.setVariable(token.image); }`
`3398`	`3393`	`\|`
`3399`		`- jdbc = SimpleJdbcParameter() { first.setJdbcParameter(jdbc); }`
	`3394`	`+ jdbc = JdbcParameter() { first.setJdbcParameter(jdbc); }`
`3400`	`3395`	`)`
`3401`	`3396`	`{`
`3402`	`3397`	`return first;`
`@@ -4235,9 +4230,9 @@ Expression PrimaryExpression() #PrimaryExpression:`
`4235`	`4230`
`4236`	`4231`	`\| LOOKAHEAD(3, {!interrupted}) retval=CaseWhenExpression()`
`4237`	`4232`
`4238`		`- \| LOOKAHEAD(3) retval = SimpleJdbcParameter()`
	`4233`	`+ \| retval = JdbcParameter()`
`4239`	`4234`
`4240`		`- \| LOOKAHEAD(2) retval=JdbcNamedParameter()`
	`4235`	`+ \| LOOKAHEAD(2) retval =JdbcNamedParameter()`
`4241`	`4236`
`4242`	`4237`	`\| LOOKAHEAD(3) retval=UserVariable()`
`4243`	`4238`
`@@ -4758,7 +4753,7 @@ IntervalExpression IntervalExpression() : {`
`4758`	`4753`	`{`
`4759`	`4754`
`4760`	`4755`	`{ interval = new IntervalExpression(); }`
`4761`		`- <K_INTERVAL> ["-" {signed=true;}] (token=<S_LONG> \| token=<S_DOUBLE> \| token=<S_CHAR_LITERAL> \| LOOKAHEAD(SimpleJdbcParameter()) expr = SimpleJdbcParameter() \| expr = JdbcNamedParameter() \| LOOKAHEAD(Function()) expr = Function() \| expr = Column())`
	`4756`	`+ <K_INTERVAL> ["-" {signed=true;}] (token=<S_LONG> \| token=<S_DOUBLE> \| token=<S_CHAR_LITERAL> \| LOOKAHEAD(JdbcParameter()) expr = JdbcParameter() \| expr = JdbcNamedParameter() \| LOOKAHEAD(Function()) expr = Function() \| expr = Column())`
`4762`	`4757`	`{`
`4763`	`4758`	`if (expr != null) {`
`4764`	`4759`	`if (signed) expr = new SignedExpression('-', expr);`
`@@ -5099,9 +5094,9 @@ FullTextSearch FullTextSearch() : {`
`5099`	`5094`	`(`
`5100`	`5095`	`againstValue=<S_CHAR_LITERAL> { fs.setAgainstValue(new StringValue(againstValue.image)); }`
`5101`	`5096`	`\|`
`5102`		`- jdbcParameter=SimpleJdbcParameter() { fs.setAgainstValue( jdbcParameter ); }`
	`5097`	`+ jdbcParameter=JdbcParameter() { fs.setAgainstValue( jdbcParameter ); }`
`5103`	`5098`	`\|`
`5104`		`- jdbcNamedParameter=SimpleJdbcNamedParameter() { fs.setAgainstValue( jdbcNamedParameter ); }`
	`5099`	`+ jdbcNamedParameter=JdbcNamedParameter() { fs.setAgainstValue( jdbcNamedParameter ); }`
`5105`	`5100`	`)`
`5106`	`5101`	`[`
`5107`	`5102`	`(`