Merge branch 'main' into rewrite-journal-abbrevation-repository-12571

Author: LoayTarek5

.github/workflows/link-issue.yml

@@ -113,20 +113,36 @@ jobs:
 
           echo "Updating issue '${{ needs.determine_issue_number.outputs.issue_number }}'"
 
-          # Check if good first/second/.. issue
-          # If yes, copy label to GitHub PR for transparency
+
+          # Copy over labels from issue to PR if they match good first/second/third/forth issue or component:* labels
+
           LABELS=$(gh api repos/${{ github.repository }}/issues/${{ needs.determine_issue_number.outputs.issue_number }}/labels --jq '.[].name')
+
+          # Check for good first/second/.. issue label
           LABEL=$(echo "$LABELS" | grep -E '^good (first|second|third|forth) issue$' || true)
-          if [ -n "$LABEL" ]; then
-            echo "✅ Found label: $LABEL"
+
+          # Check for component:* labels (can be multiple)
+          COMPONENT_LABELS=$(echo "$LABELS" | grep -E '^component:' || true)
+
+          if [ -n "$LABEL" ] || [ -n "$COMPONENT_LABELS" ]; then
             SILENT=false
-            # Apply label
-            gh issue edit "${{ github.event.pull_request.number }}" --add-label "$LABEL"
+            if [ -n "$LABEL" ]; then
+              echo "✅ Found label: $LABEL"
+              gh pr edit "${{ github.event.pull_request.number }}" --add-label "$LABEL"
+            fi
+            if [ -n "$COMPONENT_LABELS" ]; then
+              echo "✅ Found component labels:"
+              while IFS= read -r COMPONENT_LABEL; do
+                echo "   - $COMPONENT_LABEL"
+                gh pr edit "${{ github.event.pull_request.number }}" --add-label "$COMPONENT_LABEL"
+              done <<< "$COMPONENT_LABELS"
+            fi
           else
             echo "🚫 Silent fail if not possible to add assignee"
             SILENT=true
           fi
 
+
           # "gh issue edit" cannot be used - workaround found at https://github.com/cli/cli/issues/9620#issuecomment-2703135049
 
           ASSIGNEES=$(gh api /repos/JabRef/jabref/issues/${{ needs.determine_issue_number.outputs.issue_number }} --jq '[.assignees[].login]')

.github/workflows/tests-code.yml

@@ -57,6 +57,7 @@ jobs:
 
   dependencyscopes:
     name: Dependency Scopes
+    # too slow on ubuntu-slim
     runs-on: ubuntu-latest
     steps:
       - name: Checkout source
@@ -70,7 +71,8 @@ jobs:
 
   openrewrite:
     name: OpenRewrite
-    runs-on: ubuntu-slim
+    # too slow on ubuntu-slim
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout source
         uses: actions/checkout@v6
@@ -314,7 +316,8 @@ jobs:
           files: |
             jablib/src/main/java/org/jabref/logic/citationstyle/CSLStyleUtils.java
             jablib/src/test/java/org/jabref/logic/citationstyle/CSLStyleUtilsTest.java
-
+            jablib/src/main/java/org/jabref/logic/exporter/AcademicPagesExporter.java
+            jablib/src/test/java/org/jabref/logic/exporter/AcademicPagesExporterTest.java
       - uses: ./.github/actions/setup-gradle
         if: steps.changed-windows-related-files.outputs.any_changed == 'true'
       - name: Run jablib tests

CHANGELOG.md

@@ -9,13 +9,15 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 ## [Unreleased]
 
-- We added `--key-patterns` option to CLI parameters to allows users to set a citation key's pattern for a specific entry type. [#14707](https://github.com/JabRef/jabref/issues/14707)
-
 ### Added
 
+- We added `--key-patterns` option to CLI parameters to allows users to set a citation key's pattern for a specific entry type. [#14707](https://github.com/JabRef/jabref/issues/14707)
+- We added a CLI option `--field-formatters` to the `convert` and `generate-bib-from-aux` commands to apply field formatters during export. [#11520](https://github.com/JabRef/jabref/issues/11520)
+- We added a preference to skip the import dialog for entries received from browser extensions, allowing direct import into the current library. The import dialog is shown by default; users can enable direct import in Preferences.
 - We added support for dragging entries from the "Citation relations" tab to other libraries. [#15135](https://github.com/JabRef/jabref/issues/15135)
 - We added a fetcher selection dropdown to the citation count field in the General tab, allowing users to choose between Semantic Scholar, OpenAlex, OpenCitations, and scite.ai as the source. The selected fetcher is now persisted across restarts and can also be configured in the Entry Editor preferences. [#15134](https://github.com/JabRef/jabref/issues/15134)
 - We added support for citation properties in the CAYW endpoint. [#13821](https://github.com/JabRef/jabref/issues/13821)
+- We added an export format for [`academicpages`](https://academicpages.github.io/) format. [#12727](https://github.com/JabRef/jabref/issues/12727)
 - We added "All" option to the citation fetcher combo box, which queries all providers (CrossRef, OpenAlex, OpenCitations, SemanticScholar) and merges the results into a single deduplicated list.
 - We added a quick setting toggle to enable cover images download. [#15322](https://github.com/JabRef/jabref/pull/15322)
 
@@ -30,10 +32,12 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
     ⚠️ JabRef will recreate the index in a new folder for new files and this will take a long time for a huge library.
     Moreover, switching back and forth JabRef versions and meanwhile adding PDFs also requires rebuilding the index now and then.
     [#15220](https://github.com/JabRef/jabref/pull/15220)
+- We enabled drag and drop of Windows shortcut (`.lnk`) files to open libraries. [#15036](https://github.com/JabRef/jabref/issues/15036)
 - We refined the "Select files to import" page in "Search for unlinked local files" dialog to give the users the choice of linking the file to a related entry or import it to a new entry. [#13689](https://github.com/JabRef/jabref/issues/13689)
 
 ### Fixed
 
+- We fixed PDF import to prefer the content extracted title over filename like XMP metadata titles. [#11999](https://github.com/JabRef/jabref/issues/11999)
 - We fixed RIS export writing the full page range into both start page and end page fields instead of splitting them correctly. [#15106](https://github.com/JabRef/jabref/issues/15106)
 - We fixed an issue where shortcut keys did not work for linked files in the entry editor. [#12564](https://github.com/JabRef/jabref/issues/12564)
 - We fixed the issue where incomplete search produced noisy error logs when entering input in the search bar. [#14632](https://github.com/JabRef/jabref/issues/14632)

build-logic/build.gradle.kts

@@ -11,7 +11,7 @@ dependencies {
     implementation("com.adarshr:gradle-test-logger-plugin:4.0.0")
     implementation("com.autonomousapps:dependency-analysis-gradle-plugin:3.6.1")
     implementation("com.github.andygoossens:gradle-modernizer-plugin:1.12.0")
-    implementation("com.gradleup.shadow:shadow-gradle-plugin:9.3.2")
+    implementation("com.gradleup.shadow:shadow-gradle-plugin:9.4.0")
     implementation("de.undercouch.download:de.undercouch.download.gradle.plugin:5.7.0")
     implementation("org.gradlex:extra-java-module-info:1.14")
     implementation("org.gradlex:java-module-dependencies:1.12.1")

build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts

@@ -22,6 +22,7 @@ jvmDependencyConflicts {
     conflictResolution {
         select("org.gradlex:jna", "net.java.dev.jna:jna-jpms")
         select("org.gradlex:jna-platform", "net.java.dev.jna:jna-platform-jpms")
+        select("org.jabref:mslinks", "com.github.vatbub:mslinks")
     }
 }
 

build.gradle.kts

@@ -10,7 +10,7 @@ plugins {
 // This is the behavior when applied in the root project (https://docs.openrewrite.org/reference/gradle-plugin-configuration#multi-module-gradle-projects)
 
 dependencies {
-    rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:3.26.0"))
+    rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:3.26.1"))
     rewrite("org.openrewrite.recipe:rewrite-static-analysis")
     rewrite("org.openrewrite.recipe:rewrite-logging-frameworks")
     rewrite("org.openrewrite.recipe:rewrite-testing-frameworks")

gradle.properties

@@ -1,3 +1,6 @@
+# Activate this if you work on the build itself
+# org.gradle.logging.level=info
+
 org.gradle.vfs.watch=true
 
 # -Xmx6g
@@ -10,18 +13,17 @@ org.gradle.jvmargs=-Xmx6g -Dorg.kordamp.banner=false
 
 # hint by https://docs.gradle.org/current/userguide/performance.html#enable_configuration_cache
 org.gradle.configuration-cache=true
+
 org.gradle.configuration-cache.parallel=true
 
 # hint by https://docs.gradle.org/current/userguide/performance.html#enable_the_build_cache
 org.gradle.caching=true
 
-# Activate this if you work on the build itself
-# org.gradle.logging.level=info
-
-org.gradle.configureondemand=true
-
 # hint by https://docs.gradle.org/current/userguide/performance.html#sec:enable_parallel_execution
 org.gradle.parallel=true
 
+# Causes issues when .kts files change
+org.gradle.configureondemand=false
+
 # Tweak Java Toolchains
 org.gradle.java.installations.auto-download=true

gradle/modules.properties

@@ -8,7 +8,7 @@ info.picocli.codegen=info.picocli:picocli-codegen
 io.github.darvil.terminal.textformatter=io.github.darvil82:terminal-text-formatter
 io.github.eadr=io.github.adr:e-adr
 jul.to.slf4j=org.slf4j:jul-to-slf4j
-mslinks=com.github.vatbub:mslinks
+mslinks=org.jabref:mslinks
 org.apache.logging.log4j.to.slf4j=org.apache.logging.log4j:log4j-to-slf4j
 org.glassfish.jersey.container.grizzly2.http=org.glassfish.jersey.containers:jersey-container-grizzly2-http
 org.glassfish.jersey.core.common=org.glassfish.jersey.core:jersey-common

jabgui/src/main/java/org/jabref/gui/fieldeditors/FieldEditors.java

@@ -83,7 +83,7 @@ public static FieldEditorFX getForField(final Field field,
         } else if (field == StandardField.OWNER) {
             return new OwnerEditor(field, suggestionProvider, fieldCheckers, undoAction, redoAction);
         } else if (field == StandardField.GROUPS) {
-            return new GroupEditor(field, suggestionProvider, fieldCheckers, preferences, isMultiLine, undoManager, undoAction, redoAction);
+            return new GroupsEditor(field, suggestionProvider, fieldCheckers);
         } else if (field == StandardField.FILE) {
             return new LinkedFilesEditor(field, databaseContext, suggestionProvider, fieldCheckers);
         } else if (fieldProperties.contains(FieldProperty.YES_NO)) {
@@ -110,7 +110,7 @@ public static FieldEditorFX getForField(final Field field,
         } else if (fieldProperties.contains(FieldProperty.PERSON_NAMES)) {
             return new PersonsEditor(field, suggestionProvider, fieldCheckers, isMultiLine, undoManager, undoAction, redoAction);
         } else if (StandardField.KEYWORDS == field) {
-            return new KeywordsEditor(field, suggestionProvider, fieldCheckers);
+            return new KeywordsEditor(field, suggestionProvider, fieldCheckers, preferences);
         } else if (field == InternalField.KEY_FIELD) {
             return new CitationKeyEditor(field, suggestionProvider, fieldCheckers, databaseContext, undoAction, redoAction);
         } else if (fieldProperties.contains(FieldProperty.MARKDOWN)) {