Skip to content

Commit b0e4685

Browse files
authored
Fix grammatical issues in dependency injection decision
Corrected grammatical errors in the document.
1 parent 861aef0 commit b0e4685

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/decisions/0055-dependency-injection-approach.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ parent: Decision Records
88

99
JabRef uses JavaFX for its graphical interface and plain Java for its logic layer. We need a consistent and maintainable strategy for dependency injection (DI).
1010

11-
JavaFX imposes certain constraints on controllers and view models, especially regarding how FXML loads classes. At the same time, the rest of the app benefits from clear, explicit, and testable construction patterns. However, sometimes there are too much arguments in a constructor. The question is how to balance JavaFX requirements with the architectural clarity of constructor-based DI.
11+
JavaFX imposes certain constraints on controllers and view models, especially regarding how FXML loads classes. At the same time, the rest of the app benefits from clear, explicit, and testable construction patterns. However, sometimes there are too many arguments in a constructor. The question is how to balance JavaFX requirements with the architectural clarity of constructor-based DI.
1212

1313
## Decision Drivers
1414

@@ -37,7 +37,7 @@ Chosen option: "Use a mix of a DI framework and constructor-based DI", because t
3737
### Confirmation
3838

3939
Compliance can be verified by code review:
40-
JavaFX views should not expose required constructor parameters, classes that are necessary for the view model are injected as a fields in view class.
40+
JavaFX views should not expose required constructor parameters, classes that are necessary for the view model are injected as fields in view class.
4141
Core logic classes should expose dependencies through constructors, with no field injection or framework-specific annotations.
4242

4343
## Pros and Cons of the Options
@@ -59,7 +59,7 @@ Core logic classes should expose dependencies through constructors, with no fiel
5959

6060
More specifically:
6161

62-
* JavaFX controllers: use afterburnerfx framework.
62+
* JavaFX controllers: use `afterburnerfx` framework.
6363
* JAX-RS: use `jakarta.inject.Inject` and HK2 `org.glassfish.hk2.api.ServiceLocator`.
6464
* Other code: use constructor-based DI.
6565

0 commit comments

Comments
 (0)