lsp4j dependencies are obfuscated/not called by their official names

[Stewori]

Is your suggestion for improvement related to a problem? Please describe.
I'm always frustrated when... dependencies are obfuscated by using non-canonical names.

Describe the solution you'd like
In the jabsrv and jabls modules the lsp4j dependencies are required as

    requires lsp4j;
    requires lsp4j.jsonrpc;
    requires lsp4j.websocket;
    requires lsp4j.websocket.jakarta;

however, the official, canonical, correct I dare say, module names are

    requires org.eclipse.lsp4j;
    requires org.eclipse.lsp4j.jsonrpc;
    requires org.eclipse.lsp4j.websocket;
    requires org.eclipse.lsp4j.websocket.jakarta;

Those module names were chosen by the maintainers of those libs and cannot be changed by a third party. I know, there is some mapping in place in build.gradle.kts files: This is dependency obfuscation as it makes identifying the dependency unnecessarily difficult for code analyzers.

That said, even the maven group used in the kts files is strangely com.github.eclipse.lsp4j, which does not exist on maven central. The group is actually org.eclipse.lsp4j.

Why not just use the original maven central dependency and call the modules by their correct names?
Mapping lines like module("com.github.eclipse.lsp4j:org.eclipse.lsp4j", "lsp4j") should be unnecessary then.

Currently I am patching the module-info.java files manually to link APIdia docs to the canonical lsp4j modules. However, this issue should rather be fixed at the root.

[Stewori]

I did not mean to label this a "feature". I chose the "improvement" template since this issue is not really a bug.

[koppor]

OMG, we should have a check running that the build fails if the modified module names differ. See https://github.com/gradlex-org/extra-java-module-info/blob/main/CHANGELOG.md#version-113.

And we do, but lsp4j caused headaches at our side:

    // "com.github.eclipse:org.eclipse.lsp4j", "lsp4j"
    //   - The name 'org.eclipse.lsp4j' is different than the name derived from the Jar file name 'lsp4j'; turn off 'failOnModifiedDerivedModuleNames' or explicitly allow override via 'overrideModuleName()'
    //   - Not a module and no mapping defined: lsp4j-0.24.0.jar

1. Create an MWE with jgit (maybe base on https://github.com/koppor/jgit-mwe)
2. File an upstream bug to https://github.com/gradlex-org/extra-java-module-info/

CC @jjohannes

[Stewori]

Thx, Oliver for the quick reaction. However, I do not really understand the issue. The jar file should not be named lsp4j.jar in the first place: https://repo1.maven.org/maven2/org/eclipse/lsp4j/org.eclipse.lsp4j/0.24.0/
There, the file is named org.eclipse.lsp4j.jar-0.24.0.jar as it should. Okay, that's the org.eclipse distribution rather than com.github.eclipse (which I cannot sort out anyway).

[Siedlerchr]

That is indeed weird, it was added in d33d55c#diff-e726275bd851fa3b80992a32abf411685511a54b5082ca7140317347b4f99181
but probably not reverted again

Unfortunately the lsp4j guys did have issues with the module info and simply reverted it lol
eclipse-lsp4j/lsp4j@10515b1
Refs eclipse-lsp4j/lsp4j#894

[Stewori]

Interesting. Notably, the reverted module-info.java files confirm that the module names are intended to be org.eclipse.lsp4j.x

[Siedlerchr]

The issue should now be fixed. PR is in the pipeline it worked with com.github because it was then using jitpack.io to resolve the depdendencies...