-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Labels
good first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.size: medium📌 Pinned📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Description
Currently, the assumption of org.jabref.logic.importer.fetcher.CustomizableKeyFetcher#getTestUrl is that the API key is appended.
It is appended at org.jabref.gui.preferences.websearch.WebSearchTabViewModel#checkCustomApiKey and then some fetch is done.
This does not work if the API key is used otherwise.
Task
- Replace
default String getTestUrl()byboolean isValidKey(String apiKey.- Instead of
checkCustomApiKeytesting for the key, the fetcher itself does the test - No default implementaiton - all fetchers need to implement - stub:
return truewith a TODO that it needs to be implemented
- Instead of
- Remove the tests
baseURLConstructionetc fromorg.jabref.logic.importer.fetcher.BiodiversityLibraryTest - Implement
checkCustomApiKeyfororg.jabref.logic.importer.fetcher.BiodiversityLibrarybased on the existing idea. -- You can move code fromWebSearchTabViewModel#checkCustomApiKeyto here - Adapt
WebSearchTabViewModel#checkCustomApiKeyto use the new interface - Adapt
org.jabref.logic.importer.fetcher.IEEEto test for api key - add newprivategetURLForQueryaccepting an API key - and have the existinggetURLForQuerymake use of it - Use"JabRef API key test"as search (look at the code on how to construct a lucene query)
Metadata
Metadata
Assignees
Labels
good first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.size: medium📌 Pinned📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Type
Projects
Status
In Progress