Implement reset for Name Display Preferences by RakockiW · Pull Request #15136 · JabRef/jabref

RakockiW · 2026-02-16T22:59:15Z

Related issues and pull requests

Closes #14412

PR Description

Hello! I followed the steps in #14400 and implemented resetting for Name Display Preferences.

Steps to test

Checklist

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
[/] I added screenshots in the PR description (if change is visible to the user)
[/] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
[/] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
[/] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

github-actions · 2026-02-16T22:59:29Z

Hey @RakockiW! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing. We also use Qodo for review assistance. It will update your pull request description with a review help and offer suggestions to improve the pull request.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. You can read about the whole pull request process in our contribution guide.

Please ensure that your pull request is in line with our AI Usage Policy and make necessary disclosures.

qodo-free-for-open-source-projects · 2026-02-16T22:59:34Z

Review Summary by Qodo

Implement reset functionality for Name Display Preferences

✨ Enhancement

Walkthroughs

Description

• Add reset functionality for Name Display Preferences
• Implement getDefault() and setAll() methods in NameDisplayPreferences
• Remove hardcoded preference defaults from JabRefGuiPreferences
• Integrate name display preferences into reset and import workflows

Diagram

flowchart LR
  NDP["NameDisplayPreferences"]
  NDP -->|"add getDefault()"| NDP2["Default instance"]
  NDP -->|"add setAll()"| NDP3["Update preferences"]
  JRP["JabRefGuiPreferences"]
  JRP -->|"remove hardcoded defaults"| JRP2["Cleaner config"]
  JRP -->|"add getNameDisplayPreferencesFromBackingStore()"| JRP3["Load from storage"]
  JRP2 -->|"integrate into clear()"| RESET["Reset workflow"]
  JRP3 -->|"integrate into importPreferences()"| IMPORT["Import workflow"]

File Changes

1. jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java ✨ Enhancement +16/-0

Add reset and default methods to NameDisplayPreferences
• Add private no-arg constructor with default values (NATBIB display style, LASTNAME_ONLY
 abbreviation)
• Add getDefault() static method to create default instance
• Add setAll() method to update both display style and abbreviation style from another instance
jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java

2. jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java ✨ Enhancement +11/-11

Integrate name display preferences into reset and import

• Remove hardcoded name display preference defaults from initialization
• Add getNameDisplayPreferencesFromBackingStore() method to load preferences from backing store
• Integrate name display preferences reset into clear() method
• Integrate name display preferences import into importPreferences() method
• Update getNameDisplayPreferences() to use backing store loader instead of direct instantiation

jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java

qodo-free-for-open-source-projects · 2026-02-16T23:03:48Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (2) 📎 Requirement gaps (0)

1. Null-unsafe setAll 📘 Rule violation ⛯ Reliability

Description

NameDisplayPreferences.setAll dereferences preferences without a null/edge-case guard, which can
cause a runtime NullPointerException. This violates the requirement to explicitly handle null/edge
cases at potential failure points.

Code

jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java[R36-38]

+    public void setAll(NameDisplayPreferences preferences) {
+        this.displayStyle.set(preferences.displayStyle.get());
+        this.abbreviationStyle.set(preferences.abbreviationStyle.get());

Evidence
The robustness rule requires explicit handling of null/edge cases; the newly added public setAll
method directly accesses preferences.displayStyle and preferences.abbreviationStyle without
validating preferences first.
Rule 3: Generic: Robust Error Handling and Edge Case Management
jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java[36-38]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`NameDisplayPreferences.setAll` can throw a `NullPointerException` if called with a null `preferences` argument.
## Issue Context
This method is public and is used to reset/import preferences; it should be resilient to null/edge cases per robustness requirements.
## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java[36-39]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Reset behavior untested 📘 Rule violation ✓ Correctness

Description

The PR changes preference reset/import behavior for name display settings but does not add/update
tests to cover the new behavior. This risks regressions in preferences clearing/importing logic.

Code

jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java[347]
+        getNameDisplayPreferences().setAll(NameDisplayPreferences.getDefault());

Evidence

The compliance checklist requires behavior changes to be covered by tests; this PR modifies
clear() and importPreferences(...) behavior for NameDisplayPreferences, and the PR description
indicates JUnit tests were not added.

AGENTS.md
jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java[327-372]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The updated reset/import logic for `NameDisplayPreferences` is not covered by tests.
## Issue Context
`JabRefGuiPreferences.clear()` and `JabRefGuiPreferences.importPreferences(...)` now call `getNameDisplayPreferences().setAll(...)`, and backing-store parsing logic was refactored; tests should assert the resulting `DisplayStyle`/`AbbreviationStyle` values for representative stored preference combinations.
## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java[327-372]
- jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java[925-990]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

qodo-free-for-open-source-projects · 2026-02-16T23:03:49Z

jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java

+    private NameDisplayPreferences getNameDisplayPreferencesFromBackingStore(NameDisplayPreferences defaults) {
+        return new NameDisplayPreferences(
+                defaults.getDisplayStyle(),
+                defaults.getAbbreviationStyle());
+    }


1. getnamedisplaypreferencesfrombackingstore ignores store 📘 Rule violation ✓ Correctness

getNameDisplayPreferencesFromBackingStore is named as if it reads persisted values, but it only copies fields from defaults, so stored/imported preferences can be silently ignored. This violates the requirement for self-documenting naming because the identifier does not match actual behavior.

Agent Prompt

## Issue description `getNameDisplayPreferencesFromBackingStore` is misleading and currently does not read from the backing store. It only returns values from the `defaults` argument, which can cause persisted/imported name display preferences to be ignored. ## Issue Context Other `*FromBackingStore` helpers in this class read values via `getBoolean/getInt/...` with a fallback to `defaults`. Name display preferences should follow the same pattern (or the method should be renamed if it is intentionally default-only). ## Fix Focus Areas - jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java[930-930] - jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java[1228-1232]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

qodo-free-for-open-source-projects · 2026-02-17T20:38:28Z

Review Summary by Qodo

Implement reset functionality for Name Display Preferences

✨ Enhancement

Walkthroughs

Description

• Add reset functionality for Name Display Preferences
• Implement getDefault() and setAll() methods in NameDisplayPreferences
• Refactor preference loading to use backing store with proper defaults
• Remove hardcoded preference defaults from JabRefGuiPreferences
• Integrate reset into preferences clear operation

Diagram

flowchart LR
  A["NameDisplayPreferences"] -->|"add getDefault()"| B["Default preferences"]
  A -->|"add setAll()"| C["Reset mechanism"]
  D["JabRefGuiPreferences"] -->|"refactor loading"| E["getNameDisplayPreferencesFromBackingStore()"]
  E -->|"use defaults"| B
  F["clear() method"] -->|"call setAll()"| C

File Changes

1. jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java ✨ Enhancement +16/-0

Add default and reset methods to preferences class
• Add private no-arg constructor with default values (NATBIB, FULL)
• Add getDefault() static method to create default preferences instance
• Add setAll() method to copy preferences from another instance
jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java

2. jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java ✨ Enhancement +41/-28

Refactor name display preferences loading and reset

• Remove hardcoded preference defaults for name display settings
• Add getNameDisplayPreferencesFromBackingStore() method to load from backing store
• Refactor getNameDisplayStyle() and getNameAbbreviationStyle() into separate backing store
 methods with proper default fallback
• Integrate getNameDisplayPreferences().setAll(NameDisplayPreferences.getDefault()) into clear()
 method
• Integrate backing store loading into importPreferences() method
• Update getNameDisplayPreferences() to use backing store loader

jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java

RakockiW · 2026-02-17T20:38:40Z

Hi, I would be grateful if you could give me feedback on whether my approach in the method getNameDisplayPreferencesFromBackingStore is correct.
I do explicit handling for the "all flags false" case to correctly restore LASTNAME_FIRSTNAME and NONE, since there are no dedicated enums for these values.

qodo-free-for-open-source-projects · 2026-02-17T20:44:00Z

Persistent review updated to latest commit f9577d1

jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java

qodo-free-for-open-source-projects · 2026-02-17T22:40:35Z

Review Summary by Qodo

Implement reset functionality for Name Display Preferences

✨ Enhancement

Walkthroughs

Description

• Add reset functionality for Name Display Preferences
• Implement getDefault() and setAll() methods in NameDisplayPreferences
• Refactor preference loading to use backing store with proper defaults
• Remove hardcoded preference defaults from JabRefGuiPreferences
• Integrate name display preferences reset into global preferences clear method

Diagram

flowchart LR
  A["NameDisplayPreferences"] -->|"add getDefault()"| B["Default preferences"]
  A -->|"add setAll()"| C["Reset mechanism"]
  D["JabRefGuiPreferences"] -->|"refactor loading"| E["getNameDisplayPreferencesFromBackingStore()"]
  E -->|"use defaults"| B
  D -->|"integrate reset"| F["clear() method"]
  F -->|"calls setAll()"| C

File Changes

1. jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java ✨ Enhancement +16/-0

Add default and reset methods to preferences class
• Add private no-argument constructor with default values (NATBIB display style and FULL
 abbreviation style)
• Add getDefault() static method to create default preferences instance
• Add setAll() method to copy preferences from another instance
jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java

2. jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java ✨ Enhancement +41/-28

Refactor name display preferences loading and reset integration

• Remove hardcoded preference defaults for name display settings from defaults map
• Add getNameDisplayPreferencesFromBackingStore() method to load preferences with fallback to
 defaults
• Refactor getNameDisplayStyle() and getNameAbbreviationStyle() into
 getNameDisplayStyleFromBackingStore() and getNameAbbreviationStyleFromBackingStore() with proper
 default handling
• Integrate name display preferences reset into clear() method
• Integrate name display preferences import into importPreferences() method
• Update getNameDisplayPreferences() to use backing store loader

jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java

qodo-free-for-open-source-projects · 2026-02-17T22:48:12Z

Persistent review updated to latest commit b95cf28

qodo-free-for-open-source-projects · 2026-02-17T23:06:24Z

Review Summary by Qodo

Implement reset functionality for Name Display Preferences

✨ Enhancement

Walkthroughs

Description

• Add reset functionality for Name Display Preferences
• Implement getDefault() and setAll() methods in NameDisplayPreferences
• Refactor preference loading to use backing store with proper defaults
• Remove hardcoded preference defaults from JabRefGuiPreferences
• Integrate name display preferences reset into clear() and importPreferences() methods

Diagram

flowchart LR
  A["NameDisplayPreferences"] -->|"add getDefault()"| B["Default preferences"]
  A -->|"add setAll()"| C["Update preferences"]
  D["JabRefGuiPreferences"] -->|"remove hardcoded defaults"| E["Cleaner initialization"]
  D -->|"add getNameDisplayPreferencesFromBackingStore()"| F["Load from backing store"]
  G["clear() method"] -->|"call setAll(getDefault())"| H["Reset to defaults"]
  I["importPreferences() method"] -->|"call setAll(getFromBackingStore())"| J["Restore from storage"]

File Changes

1. jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java ✨ Enhancement +16/-0

Add default and bulk update methods
• Add private no-argument constructor with default values
• Add getDefault() static method to create default preferences instance
• Add setAll() method to update all preference values from another instance
jabgui/src/main/java/org/jabref/gui/maintable/NameDisplayPreferences.java

2. jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java ✨ Enhancement +41/-28

Refactor name display preferences loading and reset

• Remove hardcoded preference defaults for name display settings from defaults map
• Add getNameDisplayPreferencesFromBackingStore() method to load preferences from backing store
• Refactor getNameDisplayStyle() and getNameAbbreviationStyle() into separate backing store
 methods with proper default fallback logic
• Integrate name display preferences reset in clear() method
• Integrate name display preferences restoration in importPreferences() method
• Update getNameDisplayPreferences() to use backing store loader instead of direct initialization

jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java

RakockiW · 2026-03-01T21:50:32Z

Sorry, thanks for poining that out.

calixtus · 2026-03-01T22:06:50Z

jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java

+            System.out.println(NAMES_NATBIB + ": " + newValue);
            putBoolean(NAMES_AS_IS, newValue == NameDisplayPreferences.DisplayStyle.AS_IS);
+            System.out.println(NAMES_AS_IS + ": " + newValue);
            putBoolean(NAMES_FIRST_LAST, newValue == NameDisplayPreferences.DisplayStyle.FIRSTNAME_LASTNAME);
+            System.out.println(NAMES_FIRST_LAST + ": " + newValue);
        });
        EasyBind.listen(nameDisplayPreferences.abbreviationStyleProperty(), (obs, oldValue, newValue) -> {
            putBoolean(ABBR_AUTHOR_NAMES, newValue == NameDisplayPreferences.AbbreviationStyle.FULL);
+            System.out.println(ABBR_AUTHOR_NAMES + ": " + newValue);
            putBoolean(NAMES_LAST_ONLY, newValue == NameDisplayPreferences.AbbreviationStyle.LASTNAME_ONLY);
+            System.out.println(NAMES_LAST_ONLY + ": " + newValue);


What happend here?

Deleted, sorry.

into fix-for-issue-14412

testlens-app · 2026-03-02T17:45:30Z

✅ All tests passed ✅

🏷️ Commit: 943707d
▶️ Tests: 11252 executed
⚪️ Checks: 50/50 completed

Learn more about TestLens at testlens.app.

* Implement reset for NameDisplayPreferences * Fixed implemention of getNameDisplayPreferencesFromBackingStore method * refactor * deleted sout statements

…rg.openrewrite.recipe-rewrite-recipe-bom-3.25.0 * upstream/main: (35 commits) Chore: add dependency-management.md (#15278) Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (#15277) New Crowdin updates (#15274) Chore(deps): Bump actions/upload-artifact from 6 to 7 (#15271) Chore(deps): Bump actions/download-artifact from 7 to 8 (#15270) Chore(deps): Bump docker/login-action from 3 to 4 (#15268) Fix threading issues in citations relations tab (#15233) Fix: Citavi XML importer now preserves citation keys (#14658) (#15257) Preserve no break spaces in Latex to Unicode conversion (#15174) Fix: open javafx.scene.control.skin to controlsfx (#15260) Reduce complexity in dependencies setup (restore) (#15194) New translations jabref_en.properties (French) (#15256) Fix: exception dialog shows up when moving sidepanel down/up (#15248) Implement reset for Name Display Preferences (#15136) Chore(deps): Bump net.bytebuddy:byte-buddy in /versions (#15252) Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#15253) Chore(deps): Bump io.zonky.test:embedded-postgres in /versions (#15254) Chore(deps): Bump net.ltgt.errorprone from 5.0.0 to 5.1.0 in /jablib (#15251) New Crowdin updates (#15247) Refined the "Select files to import" page in "Search for unlinked local files" dialog (#15110) ...

Implement reset for NameDisplayPreferences

abda53f

github-actions bot added the first contrib label Feb 16, 2026

github-actions bot added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Feb 16, 2026

qodo-free-for-open-source-projects bot reviewed Feb 16, 2026

View reviewed changes

github-actions bot added the status: no-bot-comments label Feb 16, 2026

RakockiW marked this pull request as draft February 16, 2026 23:21

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Feb 16, 2026

Enable resetting of NameDisplayPreferences #14412

Closed

Fixed implemention of getNameDisplayPreferencesFromBackingStore method

ad6c30c

github-actions bot added status: changes-required Pull requests that are not yet complete status: no-bot-comments and removed status: no-bot-comments status: changes-required Pull requests that are not yet complete labels Feb 17, 2026

RakockiW marked this pull request as ready for review February 17, 2026 20:38

koppor marked this pull request as draft February 17, 2026 20:38

qodo-free-for-open-source-projects bot reviewed Feb 17, 2026

View reviewed changes

jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java Outdated Show resolved Hide resolved

RakockiW marked this pull request as ready for review February 17, 2026 22:40

koppor marked this pull request as draft February 17, 2026 22:40

RakockiW marked this pull request as ready for review February 17, 2026 23:06

koppor marked this pull request as draft February 17, 2026 23:06

RakockiW marked this pull request as ready for review February 17, 2026 23:06

RakockiW force-pushed the fix-for-issue-14412 branch from 373ebd4 to 0352567 Compare March 1, 2026 21:28

This comment has been minimized.

Sign in to view

github-actions bot added status: changes-required Pull requests that are not yet complete status: no-bot-comments and removed status: no-bot-comments status: changes-required Pull requests that are not yet complete labels Mar 1, 2026

RakockiW force-pushed the fix-for-issue-14412 branch from 0352567 to ad6c30c Compare March 1, 2026 21:40

This comment has been minimized.

Sign in to view

refactor

c65858a

This comment has been minimized.

Sign in to view

Merge branch 'main' into fix-for-issue-14412

5b7536c

This comment has been minimized.

Sign in to view

calixtus reviewed Mar 1, 2026

View reviewed changes

RakockiW added 2 commits March 1, 2026 23:11

deleted sout statements

b882122

Merge branch 'fix-for-issue-14412' of https://github.com/RakockiW/jabref

03e0b58

into fix-for-issue-14412

This comment has been minimized.

Sign in to view

RakockiW requested a review from calixtus March 1, 2026 22:12

Merge branch 'main' into fix-for-issue-14412

6a3257d

This comment has been minimized.

Sign in to view

Merge branch 'main' into fix-for-issue-14412

943707d

calixtus approved these changes Mar 2, 2026

View reviewed changes

calixtus added this pull request to the merge queue Mar 2, 2026

github-actions bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Mar 2, 2026

Merged via the queue into JabRef:main with commit c12efc0 Mar 2, 2026
50 checks passed

RakockiW deleted the fix-for-issue-14412 branch March 2, 2026 20:55

Uh oh!

Conversation

RakockiW commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues and pull requests

PR Description

Steps to test

Checklist

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

qodo-free-for-open-source-projects bot commented Feb 16, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-free-for-open-source-projects bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

qodo-free-for-open-source-projects bot Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

qodo-free-for-open-source-projects bot commented Feb 17, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

RakockiW commented Feb 17, 2026

Uh oh!

qodo-free-for-open-source-projects bot commented Feb 17, 2026

Uh oh!

Uh oh!

qodo-free-for-open-source-projects bot commented Feb 17, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-free-for-open-source-projects bot commented Feb 17, 2026

Uh oh!

qodo-free-for-open-source-projects bot commented Feb 17, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

RakockiW commented Mar 1, 2026

Uh oh!

calixtus Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

RakockiW Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

testlens-app bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All tests passed ✅

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RakockiW commented Feb 16, 2026 •

edited

Loading

qodo-free-for-open-source-projects bot commented Feb 16, 2026 •

edited

Loading

testlens-app bot commented Mar 2, 2026 •

edited

Loading