Skip to content

Commit a4f0966

Browse files
JacekZubielikJacekZubielik
authored
chore(lint): code (#123)
1 parent 0a1e854 commit a4f0966

15 files changed

Lines changed: 144 additions & 72 deletions

‎.github/ISSUE_TEMPLATE/bug_report.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# Copyright VMware, Inc.
22
# SPDX-License-Identifier: APACHE-2.0
3-
3+
---
44
name: Bug
55
description: Create a report to help us improve
66
labels: ["tech-issues"]
77
body:
88
- type: markdown
99
attributes:
1010
value: |
11-
Thank you for reporting an issue.
11+
Thank you for reporting an issue.
1212
1313
Please fill in as much of the following form as you're able.
1414
- type: input

‎.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
---
12
blank_issues_enabled: false

‎.github/ISSUE_TEMPLATE/feature_request.yml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1+
---
12
name: Feature request
23
description: Suggest an idea for this project
34
title: "[name of the chart e.g. prometheus-couchdb-exporter] Issue Title"
45
labels: [enhancement]
5-
assignees:
6-
-
76
body:
87
- type: markdown
98
attributes:
@@ -15,7 +14,7 @@ body:
1514
attributes:
1615
label: Is your feature request related to a problem ?
1716
description: Give a clear and concise description of what the problem is.
18-
placeholder: ex. I'm always frustrated when [...]
17+
placeholder: ex. I'm always frustrated when [...]
1918
validations:
2019
required: true
2120

‎.github/configs/ct-install.yaml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
## Reference: https://github.com/helm/chart-testing/blob/master/doc/ct_lint-and-install.md
22
# Don't add the 'debug' attribute, otherwise the workflow won't work anymore
33
# Only Used for the CT Install Stage
4+
---
45
remote: origin
56
chart-dirs:
67
- charts
78
chart-repos:
89
- jz-helm-charts=https://jacekzubielik.github.io/jz-helm-charts
9-
helm-extra-args: "--timeout 1200s"
10+
helm-extra-args: "--timeout 1200s"
1011
validate-chart-schema: false
1112
validate-maintainers: true
1213
validate-yaml: true
1314
exclude-deprecated: true
14-
excluded-charts:
15-
- "argocd-applicationset"
15+
excluded-charts:
16+
- "argocd-applicationset"

‎.github/configs/ct-lint.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
## Reference: https://github.com/helm/chart-testing/blob/master/doc/ct_lint-and-install.md
22
# Don't add the 'debug' attribute, otherwise the workflow won't work anymore
33
# Only Used for the CT Lint Stage
4+
---
45
remote: origin
56
chart-dirs:
67
- charts

‎.github/configs/kind-config.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# https://kind.sigs.k8s.io/docs/user/configuration/
2+
---
23
kind: Cluster
34
apiVersion: kind.x-k8s.io/v1alpha4
45
nodes:

‎.github/configs/lintconf.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,4 @@ rules:
4040
type: unix
4141
trailing-spaces: enable
4242
truthy:
43-
level: warning
43+
level: warning

‎.github/dependabot.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
---
12
version: 2
23
updates:
34
- package-ecosystem: "github-actions"
45
directory: "/"
56
schedule:
6-
interval: "weekly"
7+
interval: "weekly"

‎.github/labeler.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ chart/uptime-kuma:
3131
- any-glob-to-any-file: "charts/uptime-kuma/**/*"
3232
chart/zigbee2mqtt:
3333
- changed-files:
34-
- any-glob-to-any-file: "charts/zigbee2mqtt/**/*"
34+
- any-glob-to-any-file: "charts/zigbee2mqtt/**/*"

‎.github/workflows/lint-and-test.yml‎

Lines changed: 55 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,56 @@
11
---
2-
name: Lint and Test
3-
on:
4-
pull_request:
5-
branches:
6-
- main
7-
workflow_dispatch:
8-
9-
jobs:
10-
chart-test:
11-
runs-on:
12-
- ubuntu-latest
13-
14-
steps:
15-
- name: Checkout
16-
uses: actions/checkout@v4
17-
with:
18-
fetch-depth: 0
19-
20-
- name: Set up Helm
21-
uses: azure/setup-helm@v4.3.0
22-
with:
23-
version: v3.16.4
24-
25-
- name: Set up python
26-
uses: actions/setup-python@v5
27-
with:
28-
python-version: '3.13'
29-
check-latest: true
30-
31-
- name: Setup Chart Linting
32-
id: lint
33-
uses: helm/chart-testing-action@v2.7.0
34-
35-
- name: Chart-testing (list-changed)
36-
id: list-changed
37-
run: |
38-
changed=$(ct --config ./.github/configs/ct-lint.yaml list-changed --target-branch ${{ github.event.repository.default_branch }})
39-
charts=$(echo "$changed" | tr '\n' ' ' | xargs)
40-
if [[ -n "$changed" ]]; then
41-
echo "changed=true" >> "$GITHUB_OUTPUT"
42-
echo "changed_charts=$charts" >> "$GITHUB_OUTPUT"
43-
fi
44-
45-
- name: Chart-testing (lint)
46-
run: ct lint --debug --config ./.github/configs/ct-lint.yaml --lint-conf ./.github/configs/lintconf.yaml --target-branch ${{ github.event.repository.default_branch }}
47-
48-
- name: Create kind cluster
49-
uses: helm/kind-action@v1.12.0
50-
if: steps.list-changed.outputs.changed == 'true'
51-
with:
52-
config: ./.github/configs/kind-config.yaml
53-
54-
- name: Chart-testing (install)
55-
run: ct install --config ./.github/configs/ct-install.yaml
56-
if: steps.list-changed.outputs.changed == 'true'
2+
name: Lint and Test
3+
on:
4+
pull_request:
5+
branches:
6+
- main
7+
workflow_dispatch:
8+
9+
jobs:
10+
chart-test:
11+
runs-on:
12+
- ubuntu-latest
13+
14+
steps:
15+
- name: Checkout
16+
uses: actions/checkout@v4
17+
with:
18+
fetch-depth: 0
19+
20+
- name: Set up Helm
21+
uses: azure/setup-helm@v4.3.0
22+
with:
23+
version: v3.16.4
24+
25+
- name: Set up python
26+
uses: actions/setup-python@v5
27+
with:
28+
python-version: '3.13'
29+
check-latest: true
30+
31+
- name: Setup Chart Linting
32+
id: lint
33+
uses: helm/chart-testing-action@v2.7.0
34+
35+
- name: Chart-testing (list-changed)
36+
id: list-changed
37+
run: |
38+
changed=$(ct --config ./.github/configs/ct-lint.yaml list-changed --target-branch ${{ github.event.repository.default_branch }})
39+
charts=$(echo "$changed" | tr '\n' ' ' | xargs)
40+
if [[ -n "$changed" ]]; then
41+
echo "changed=true" >> "$GITHUB_OUTPUT"
42+
echo "changed_charts=$charts" >> "$GITHUB_OUTPUT"
43+
fi
44+
45+
- name: Chart-testing (lint)
46+
run: ct lint --debug --config ./.github/configs/ct-lint.yaml --lint-conf ./.github/configs/lintconf.yaml --target-branch ${{ github.event.repository.default_branch }}
47+
48+
- name: Create kind cluster
49+
uses: helm/kind-action@v1.12.0
50+
if: steps.list-changed.outputs.changed == 'true'
51+
with:
52+
config: ./.github/configs/kind-config.yaml
53+
54+
- name: Chart-testing (install)
55+
run: ct install --config ./.github/configs/ct-install.yaml
56+
if: steps.list-changed.outputs.changed == 'true'

0 commit comments

Comments
 (0)