Clear allocation notes on server deletion (pterodactyl#5157)

Author: giomxx

CHANGELOG.md

@@ -17,6 +17,7 @@ This project follows [Semantic Versioning](http://semver.org) guidelines.
 * Fixes node description not being settable via the API.
 * Fixes 0-bytes files returning an error when attempting to upload.
 * Fixes nodes displaying the first available location even when that field was not edited and the node has a different value set.
+* Fixes allocation notes not being reset when a server is deleted. ([#5157](https://github.com/pterodactyl/panel/pull/5157))
 
 ### Changed
 * Minimum NodeJS version updated to 22 for building.

app/Services/Servers/ServerDeletionService.php

@@ -35,7 +35,7 @@ public function withForce(bool $bool = true): self
     }
 
     /**
-     * Delete a server from the panel and remove any associated databases from hosts.
+     * Delete a server from the panel, clear any allocation notes, and remove any associated databases from hosts.
      *
      * @throws \Throwable
      * @throws \Pterodactyl\Exceptions\DisplayException
@@ -77,6 +77,10 @@ public function handle(Server $server): void
                 }
             }
 
+            // clear any allocation notes for the server
+            $server->allocations()->update(['notes' => null]);
+
+
             $server->delete();
         });
     }

database/migrations/2024_07_13_091852_clear_unused_allocation_notes.php

@@ -0,0 +1,26 @@
+<?php
+
+use Illuminate\Support\Facades\DB;
+use Illuminate\Database\Migrations\Migration;
+
+return new class () extends Migration {
+    /**
+     * Run the migrations.
+     */
+    public function up(): void
+    {
+
+        DB::table('allocations')
+            ->whereNull('server_id')
+            ->update(['notes' => null]);
+
+    }
+
+    /**
+     * Reverse the migrations.
+     */
+    public function down(): void
+    {
+        // Reverse not needed
+    }
+};