change test to start wolfsshd as service

Author: JacobBarthelmeh

.github/workflows/windows-cert-store-test.yml

@@ -291,7 +291,7 @@ jobs:
             Write-Host "WARNING: wolfssh.exe not found (SSH client test will be skipped)"
         }
 
-    - name: Start wolfSSHd in background
+    - name: Start wolfSSHd as Windows service
       working-directory: ${{ github.workspace }}\wolfssh
       shell: pwsh
       run: |
@@ -301,22 +301,69 @@ jobs:
             exit 1
         }
         
-        # Start wolfsshd in background
-        $sshdProcess = Start-Process -FilePath $sshdPath `
-            -ArgumentList "-D", "-f", "sshd_config_test", "-p", "${{env.TEST_PORT}}" `
-            -PassThru -NoNewWindow
+        # Get absolute path for service
+        $sshdPathFull = (Resolve-Path $sshdPath).Path
+        $configPathFull = (Resolve-Path "sshd_config_test").Path
         
-        Write-Host "Started wolfSSHd with PID: $($sshdProcess.Id)"
-        Add-Content -Path $env:GITHUB_ENV -Value "SSHD_PID=$($sshdProcess.Id)"
+        # Service name
+        $serviceName = "wolfsshd"
         
-        # Wait a bit for server to start
+        # Remove service if it already exists
+        $existingService = Get-Service -Name $serviceName -ErrorAction SilentlyContinue
+        if ($existingService) {
+            Write-Host "Removing existing $serviceName service"
+            if ($existingService.Status -eq 'Running') {
+                Stop-Service -Name $serviceName -Force -ErrorAction SilentlyContinue
+                Start-Sleep -Seconds 2
+            }
+            sc.exe delete $serviceName | Out-Null
+            Start-Sleep -Seconds 2
+        }
+        
+        # Create the service with proper binpath
+        # binpath format: "path\to\exe" -f "config" -p port
+        $binPath = "`"$sshdPathFull`" -f `"$configPathFull`" -p ${{env.TEST_PORT}}"
+        Write-Host "Creating service with binpath: $binPath"
+        
+        $createResult = sc.exe create $serviceName binPath= $binPath
+        if ($LASTEXITCODE -ne 0) {
+            Write-Host "ERROR: Failed to create service"
+            Write-Host $createResult
+            exit 1
+        }
+        Write-Host "Service created: $createResult"
+        
+        # Start the service
+        Write-Host "Starting $serviceName service"
+        $startResult = sc.exe start $serviceName
+        if ($LASTEXITCODE -ne 0) {
+            Write-Host "ERROR: Failed to start service"
+            Write-Host $startResult
+            # Try to get service status for debugging
+            sc.exe query $serviceName
+            exit 1
+        }
+        Write-Host "Service started: $startResult"
+        
+        # Wait a bit for service to start
         Start-Sleep -Seconds 3
         
-        # Check if process is still running
-        if (-not (Get-Process -Id $sshdProcess.Id -ErrorAction SilentlyContinue)) {
-            Write-Host "ERROR: wolfSSHd process exited immediately"
+        # Check service status
+        $service = Get-Service -Name $serviceName -ErrorAction SilentlyContinue
+        if (-not $service) {
+            Write-Host "ERROR: Service $serviceName not found after creation"
+            exit 1
+        }
+        
+        if ($service.Status -ne 'Running') {
+            Write-Host "ERROR: Service is not running. Status: $($service.Status)"
+            # Get more details
+            sc.exe query $serviceName
             exit 1
         }
+        
+        Write-Host "wolfSSHd service is running (Status: $($service.Status))"
+        Add-Content -Path $env:GITHUB_ENV -Value "SSHD_SERVICE_NAME=$serviceName"
 
     - name: Test SFTP connection
       working-directory: ${{ github.workspace }}\wolfssh
@@ -486,13 +533,23 @@ jobs:
       working-directory: ${{ github.workspace }}\wolfssh
       shell: pwsh
       run: |
-        # Stop wolfSSHd
-        if ($env:SSHD_PID) {
-            $pid = [int]$env:SSHD_PID
-            if (Get-Process -Id $pid -ErrorAction SilentlyContinue) {
-                Stop-Process -Id $pid -Force
-                Write-Host "Stopped wolfSSHd process $pid"
+        # Stop and remove wolfSSHd service
+        $serviceName = $env:SSHD_SERVICE_NAME
+        if ([string]::IsNullOrEmpty($serviceName)) {
+            $serviceName = "wolfsshd"
+        }
+        
+        $service = Get-Service -Name $serviceName -ErrorAction SilentlyContinue
+        if ($service) {
+            if ($service.Status -eq 'Running') {
+                Write-Host "Stopping $serviceName service"
+                Stop-Service -Name $serviceName -Force -ErrorAction SilentlyContinue
+                Start-Sleep -Seconds 2
             }
+            
+            Write-Host "Deleting $serviceName service"
+            sc.exe delete $serviceName | Out-Null
+            Start-Sleep -Seconds 1
         }
         
         # Remove test certificates from store