updates on checking with test

Author: JacobBarthelmeh

.github/workflows/windows-cert-store-test.yml

@@ -57,6 +57,18 @@ jobs:
       working-directory: ${{ github.workspace }}\wolfssl
       run: msbuild /m /p:PlatformToolset=v142 /p:Platform=${{env.BUILD_PLATFORM}} /p:Configuration=${{env.WOLFSSL_BUILD_CONFIGURATION}} /t:wolfssl ${{env.WOLFSSL_SOLUTION_FILE_PATH}}
 
+    - name: Upload wolfSSL build artifacts
+      uses: actions/upload-artifact@v4
+      with:
+        name: wolfssl-windows-build
+        if-no-files-found: warn
+        retention-days: 1
+        path: |
+          wolfssl/IDE/WIN/${{env.WOLFSSL_BUILD_CONFIGURATION}}/${{env.BUILD_PLATFORM}}/**
+          wolfssl/IDE/WIN/${{env.WOLFSSL_BUILD_CONFIGURATION}}/**
+          wolfssl/${{env.WOLFSSL_BUILD_CONFIGURATION}}/${{env.BUILD_PLATFORM}}/**
+          wolfssl/${{env.WOLFSSL_BUILD_CONFIGURATION}}/**
+
     - name: Restore NuGet packages
       working-directory: ${{ github.workspace }}\wolfssh\ide\winvs
       run: nuget restore ${{env.SOLUTION_FILE_PATH}}
@@ -172,6 +184,12 @@ jobs:
         name: wolfssh-windows-build
         path: .
 
+    - name: Download wolfSSL build artifacts
+      uses: actions/download-artifact@v4
+      with:
+        name: wolfssl-windows-build
+        path: .
+
     - name: Set up test environment - ${{ matrix.test_name }}
       working-directory: ${{ github.workspace }}\wolfssh
       shell: pwsh
@@ -307,7 +325,7 @@ jobs:
             Write-Host "WARNING: wolfssh.exe not found (SSH client test will be skipped)"
         }
 
-    - name: Copy wolfSSL DLL to executable directory
+    - name: Copy wolfSSL DLL to executable directory (if dynamic build)
       working-directory: ${{ github.workspace }}
       shell: pwsh
       run: |
@@ -320,15 +338,18 @@ jobs:
         $sshdDir = Split-Path -Parent $sshdPath
         Write-Host "wolfsshd.exe directory: $sshdDir"
         
-        # Check common wolfSSL build output paths
+        # If wolfssl.lib is already next to wolfsshd.exe, it's a static build - no DLL needed
+        $libInSshdDir = Join-Path $sshdDir "wolfssl.lib"
+        if (Test-Path $libInSshdDir) {
+            Write-Host "wolfssl.lib present beside wolfsshd.exe - static build; wolfssl.dll not required"
+            exit 0
+        }
+        
+        # Dynamic build: find and copy wolfssl.dll
         $wolfsslRoot = "${{ github.workspace }}\wolfssl"
         $buildConfig = "${{env.WOLFSSL_BUILD_CONFIGURATION}}"
         $buildPlatform = "${{env.BUILD_PLATFORM}}"
         
-        Write-Host "Searching for wolfSSL DLL in: $wolfsslRoot"
-        Write-Host "Build configuration: $buildConfig, Platform: $buildPlatform"
-        
-        # Try common output paths first
         $commonPaths = @(
             "$wolfsslRoot\IDE\WIN\$buildConfig\$buildPlatform\wolfssl.dll",
             "$wolfsslRoot\IDE\WIN\$buildConfig\wolfssl.dll",
@@ -338,75 +359,18 @@ jobs:
         
         $wolfsslDll = $null
         foreach ($path in $commonPaths) {
-            if (Test-Path $path) {
-                $wolfsslDll = Get-Item $path
-                Write-Host "Found wolfssl.dll at common path: $($wolfsslDll.FullName)"
-                break
-            }
+            if (Test-Path $path) { $wolfsslDll = Get-Item $path; break }
         }
-        
-        # If not found in common paths, search recursively
         if (-not $wolfsslDll) {
-            Write-Host "Not found in common paths, searching recursively..."
-            $wolfsslDll = Get-ChildItem -Path $wolfsslRoot -Recurse -Filter "wolfssl.dll" -ErrorAction SilentlyContinue | 
-                Where-Object { 
-                    $_.FullName -like "*$buildConfig*" -and 
-                    ($_.FullName -like "*$buildPlatform*" -or $_.DirectoryName -notlike "*Debug*")
-                } | 
-                Select-Object -First 1
+            $wolfsslDll = Get-ChildItem -Path $wolfsslRoot -Recurse -Filter "wolfssl.dll" -ErrorAction SilentlyContinue | Select-Object -First 1
         }
         
         if ($wolfsslDll) {
             $targetDll = Join-Path $sshdDir "wolfssl.dll"
-            Write-Host "Copying wolfssl.dll from: $($wolfsslDll.FullName)"
-            Write-Host "Copying to: $targetDll"
             Copy-Item -Path $wolfsslDll.FullName -Destination $targetDll -Force
-            if (Test-Path $targetDll) {
-                Write-Host "Successfully copied wolfssl.dll"
-            } else {
-                Write-Host "ERROR: Copy failed - target file not found after copy"
-                exit 1
-            }
+            Write-Host "Copied wolfssl.dll to $targetDll"
         } else {
-            Write-Host "WARNING: wolfssl.dll not found"
-            Write-Host "Listing all DLL files in wolfSSL directory:"
-            Get-ChildItem -Path $wolfsslRoot -Recurse -Filter "*.dll" -ErrorAction SilentlyContinue | 
-                Where-Object { $_.FullName -like "*$buildConfig*" } | 
-                Select-Object FullName | Format-Table
-        }
-        
-        # Also copy wolfssl.lib if found
-        $wolfsslLib = $null
-        foreach ($path in $commonPaths) {
-            $libPath = $path -replace "\.dll$", ".lib"
-            if (Test-Path $libPath) {
-                $wolfsslLib = Get-Item $libPath
-                Write-Host "Found wolfssl.lib at common path: $($wolfsslLib.FullName)"
-                break
-            }
-        }
-        
-        if (-not $wolfsslLib) {
-            $wolfsslLib = Get-ChildItem -Path $wolfsslRoot -Recurse -Filter "wolfssl.lib" -ErrorAction SilentlyContinue | 
-                Where-Object { 
-                    $_.FullName -like "*$buildConfig*" -and 
-                    ($_.FullName -like "*$buildPlatform*" -or $_.DirectoryName -notlike "*Debug*")
-                } | 
-                Select-Object -First 1
-        }
-        
-        if ($wolfsslLib) {
-            $targetLib = Join-Path $sshdDir "wolfssl.lib"
-            Write-Host "Copying wolfssl.lib from: $($wolfsslLib.FullName)"
-            Write-Host "Copying to: $targetLib"
-            Copy-Item -Path $wolfsslLib.FullName -Destination $targetLib -Force
-            if (Test-Path $targetLib) {
-                Write-Host "Successfully copied wolfssl.lib"
-            } else {
-                Write-Host "WARNING: wolfssl.lib copy may have failed"
-            }
-        } else {
-            Write-Host "INFO: wolfssl.lib not found (may be static build or not needed)"
+            Write-Host "wolfssl.dll not found; if build is static (wolfssl.lib in output), this is OK"
         }
 
     - name: Verify host key configuration
@@ -475,65 +439,44 @@ jobs:
         
         Write-Host "Host key configuration verified: OK"
 
-    - name: Test wolfSSHd startup (diagnostic)
+    - name: Verify dependencies and environment
       working-directory: ${{ github.workspace }}\wolfssh
       shell: pwsh
       run: |
         $sshdPath = (Get-Content env:SSHD_PATH)
-        if (-not (Test-Path $sshdPath)) {
-            Write-Host "ERROR: wolfsshd.exe not found at $sshdPath"
-            exit 1
+        $sshdDir = Split-Path -Parent $sshdPath
+        
+        Write-Host "=== Verifying wolfsshd.exe environment ==="
+        Write-Host "Executable: $sshdPath"
+        Write-Host "Directory: $sshdDir"
+        
+        # Check if DLL is present
+        $dllPath = Join-Path $sshdDir "wolfssl.dll"
+        if (Test-Path $dllPath) {
+            Write-Host "✓ wolfssl.dll found"
+            $dllInfo = Get-Item $dllPath
+            Write-Host "  Size: $($dllInfo.Length) bytes"
+            Write-Host "  Modified: $($dllInfo.LastWriteTime)"
+        } else {
+            Write-Host "✗ wolfssl.dll NOT FOUND in $sshdDir"
+            Write-Host "Files in directory:"
+            Get-ChildItem -Path $sshdDir | Select-Object Name, Length | Format-Table
         }
         
+        # Check config file
         $configPath = "sshd_config_test"
-        if (-not (Test-Path $configPath)) {
-            Write-Host "ERROR: Config file not found: $configPath"
-            exit 1
+        if (Test-Path $configPath) {
+            Write-Host "✓ Config file found: $configPath"
+        } else {
+            Write-Host "✗ Config file NOT FOUND: $configPath"
         }
         
-        Write-Host "=== Testing wolfsshd.exe startup (direct run) ==="
-        Write-Host "Executable: $sshdPath"
-        Write-Host "Config: $configPath"
-        
-        # Try to run it directly to see error messages
-        $processInfo = New-Object System.Diagnostics.ProcessStartInfo
-        $processInfo.FileName = $sshdPath
-        $processInfo.Arguments = "-f $configPath -p ${{env.TEST_PORT}}"
-        $processInfo.UseShellExecute = $false
-        $processInfo.RedirectStandardOutput = $true
-        $processInfo.RedirectStandardError = $true
-        $processInfo.CreateNoWindow = $true
-        
-        $process = New-Object System.Diagnostics.Process
-        $process.StartInfo = $processInfo
-        
-        try {
-            $process.Start() | Out-Null
-            Start-Sleep -Seconds 2
-            
-            if (-not $process.HasExited) {
-                Write-Host "Process is running (good sign)"
-                $process.Kill()
-                $process.WaitForExit(5000)
-            } else {
-                Write-Host "Process exited immediately (exit code: $($process.ExitCode))"
-                $stdout = $process.StandardOutput.ReadToEnd()
-                $stderr = $process.StandardError.ReadToEnd()
-                if ($stdout) {
-                    Write-Host "STDOUT: $stdout"
-                }
-                if ($stderr) {
-                    Write-Host "STDERR: $stderr"
-                }
-            }
-        } catch {
-            Write-Host "ERROR running process: $_"
-        } finally {
-            if (-not $process.HasExited) {
-                $process.Kill()
-            }
-            $process.Dispose()
-        }
+        # Note: Direct execution will fail with "StartServiceCtrlDispatcher failed"
+        # This is expected - the executable is built as a service and must run via SCM
+        Write-Host ""
+        Write-Host "Note: wolfsshd.exe is built as a Windows service."
+        Write-Host "Direct execution will fail (this is expected)."
+        Write-Host "It must be started via Service Control Manager (sc.exe)."
 
     - name: Start wolfSSHd as Windows service
       working-directory: ${{ github.workspace }}\wolfssh
@@ -564,8 +507,47 @@ jobs:
             Start-Sleep -Seconds 2
         }
         
+        # Pre-service checks
+        $sshdDir = Split-Path -Parent $sshdPathFull
+        $dllPath = Join-Path $sshdDir "wolfssl.dll"
+        $libPath = Join-Path $sshdDir "wolfssl.lib"
+        Write-Host "=== Pre-service checks ==="
+        Write-Host "Executable: $sshdPathFull"
+        Write-Host "Config: $configPathFull"
+        Write-Host "Working directory (sshd dir): $sshdDir"
+        
+        # wolfSSL: either DLL (dynamic) or static (.lib linked into exe)
+        if (Test-Path $dllPath) {
+            Write-Host "✓ wolfssl.dll found (dynamic build)"
+            $dllInfo = Get-Item $dllPath
+            Write-Host "  Size: $($dllInfo.Length) bytes"
+        } elseif (Test-Path $libPath) {
+            Write-Host "✓ wolfssl.lib present, no wolfssl.dll - static build (no DLL required)"
+        } else {
+            Write-Host "WARNING: Neither wolfssl.dll nor wolfssl.lib in $sshdDir"
+            Write-Host "Files present:"
+            Get-ChildItem -Path $sshdDir | Select-Object Name, Length | Format-Table
+            # Continue anyway; service may still start if wolfssl is linked another way
+        }
+        
+        if (-not (Test-Path $configPathFull)) {
+            Write-Host "ERROR: Config file not found: $configPathFull"
+            exit 1
+        } else {
+            Write-Host "✓ Config file found"
+            # Verify config file is readable
+            try {
+                $configContent = Get-Content $configPathFull -Raw
+                Write-Host "  Size: $($configContent.Length) bytes"
+            } catch {
+                Write-Host "ERROR: Cannot read config file: $_"
+                exit 1
+            }
+        }
+        
         # Create the service with proper binpath
-        # binpath format: "path\to\exe" -f "config" -p port
+        # Note: sc.exe requires the binPath to have the executable path and arguments
+        # The entire command line goes in binPath, with the exe path in quotes
         $binPath = "`"$sshdPathFull`" -f `"$configPathFull`" -p ${{env.TEST_PORT}}"
         Write-Host "Creating service with binpath: $binPath"
         
@@ -577,6 +559,10 @@ jobs:
         }
         Write-Host "Service created: $createResult"
         
+        # Set service to auto-start on failure (for debugging)
+        # This won't help if it exits cleanly, but might help with crashes
+        sc.exe failure $serviceName reset= 86400 actions= restart/5000/restart/5000/restart/5000 | Out-Null
+        
         # Start the service
         Write-Host "Starting $serviceName service"
         $startResult = sc.exe start $serviceName
@@ -590,7 +576,7 @@ jobs:
         Write-Host "Service started: $startResult"
         
         # Wait a bit for service to start
-        Start-Sleep -Seconds 3
+        Start-Sleep -Seconds 5
         
         # Check service status
         $service = Get-Service -Name $serviceName -ErrorAction SilentlyContinue
@@ -601,21 +587,72 @@ jobs:
         
         if ($service.Status -ne 'Running') {
             Write-Host "ERROR: Service is not running. Status: $($service.Status)"
-            # Get more details
+            
+            # Get detailed service information
             Write-Host "=== Service Query ==="
             sc.exe query $serviceName
-            Write-Host "=== Event Log (last 20 entries) ==="
-            Get-EventLog -LogName Application -Source "wolfsshd" -Newest 20 -ErrorAction SilentlyContinue | Format-List
-            Get-EventLog -LogName System -Source "Service Control Manager" -Newest 10 -ErrorAction SilentlyContinue | 
-                Where-Object { $_.Message -like "*wolfsshd*" } | Format-List
+            
+            # Get service configuration to see the actual command
+            Write-Host "=== Service Configuration ==="
+            sc.exe qc $serviceName
+            
+            # Check service error code and details
+            Write-Host "=== Service Error Code ==="
+            $serviceInfo = Get-CimInstance -ClassName Win32_Service -Filter "Name='$serviceName'" -ErrorAction SilentlyContinue
+            if ($serviceInfo) {
+                Write-Host "ExitCode: $($serviceInfo.ExitCode)"
+                Write-Host "State: $($serviceInfo.State)"
+                Write-Host "Status: $($serviceInfo.Status)"
+                Write-Host "PathName: $($serviceInfo.PathName)"
+                Write-Host "StartMode: $($serviceInfo.StartMode)"
+            }
+            
+            # Try to get process exit code if it ran briefly
+            Write-Host "=== Checking for recent process exit ==="
+            $recentProcesses = Get-WinEvent -FilterHashtable @{LogName='System'; ID=7034,7035,7036} -MaxEvents 50 -ErrorAction SilentlyContinue | 
+                Where-Object { $_.Message -like "*wolfsshd*" } | 
+                Select-Object -First 5
+            if ($recentProcesses) {
+                Write-Host "Recent service events:"
+                $recentProcesses | ForEach-Object { Write-Host "  $($_.TimeCreated): $($_.Message)" }
+            }
+            
+            # Check event logs for errors
+            Write-Host "=== System Event Log (Service Control Manager) ==="
+            Get-EventLog -LogName System -Source "Service Control Manager" -Newest 20 -ErrorAction SilentlyContinue | 
+                Where-Object { $_.Message -like "*wolfsshd*" -or $_.Message -like "*$serviceName*" } | 
+                Select-Object TimeGenerated, EntryType, Message | Format-List
+            
+            Write-Host "=== Application Event Log ==="
+            Get-EventLog -LogName Application -Newest 30 -ErrorAction SilentlyContinue | 
+                Where-Object { $_.Source -like "*wolf*" -or $_.Message -like "*wolf*" } | 
+                Select-Object TimeGenerated, Source, EntryType, Message | Format-List
+            
+            # Check wolfSSL: DLL (dynamic) or .lib (static)
+            Write-Host "=== Checking wolfSSL (DLL or static) ==="
+            $sshdDir = Split-Path -Parent $sshdPathFull
+            $dllPath = Join-Path $sshdDir "wolfssl.dll"
+            $libPath = Join-Path $sshdDir "wolfssl.lib"
+            if (Test-Path $dllPath) {
+                Write-Host "wolfssl.dll: YES (dynamic build)"
+            } elseif (Test-Path $libPath) {
+                Write-Host "wolfssl.dll: NO; wolfssl.lib: YES (static build - OK)"
+            } else {
+                Write-Host "wolfssl.dll: NO; wolfssl.lib: NO"
+                Write-Host "Files in $sshdDir :"
+                Get-ChildItem -Path $sshdDir | Select-Object Name, Length | Format-Table
+            }
+            
+            # Check if process is running
             Write-Host "=== Checking if process is running ==="
             $processes = Get-Process | Where-Object { $_.ProcessName -like "*wolfsshd*" }
             if ($processes) {
                 Write-Host "Found processes:"
-                $processes | Format-Table Id, ProcessName, StartTime
+                $processes | Format-Table Id, ProcessName, StartTime, Path
             } else {
                 Write-Host "No wolfsshd processes found"
             }
+            
             exit 1
         }