Skip to content

Commit 3eed741

Browse files
authored
Merge pull request HarbourMasters#50 from Jameriquiah/material-fix
fix material exporter
2 parents 8781cd4 + 198e526 commit 3eed741

3 files changed

Lines changed: 4 additions & 10 deletions

File tree

fast64_internal/f3d/f3d_bleed.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,6 @@ def get_geo_cmds(
7575
set_modes, clear_modes = set(set_modes), set(clear_modes)
7676
if len(clear_modes) == 0 and len(set_modes) == 0:
7777
return ([], [])
78-
if is_ex2:
79-
if matWriteMethod == GfxMatWriteMethod.WriteAll:
80-
return ([SPLoadGeometryMode(set_modes)], [])
81-
elif len(set_modes) > 0 and len(clear_modes) > 0:
82-
return ([SPGeometryMode(clear_modes, set_modes)], [SPGeometryMode(set_modes, clear_modes)])
8378
material, revert = [], []
8479
if len(set_modes) > 0:
8580
material.append(SPSetGeometryMode(set_modes))

fast64_internal/f3d/f3d_writer.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1317,7 +1317,7 @@ def saveOrGetF3DMaterial(material, fModel, _obj, drawLayer, convertTextureData):
13171317
useDict = all_combiner_uses(f3dMat)
13181318

13191319
defaults = create_or_get_world(bpy.context.scene).rdp_defaults
1320-
saveGeoModeDefinition(fMaterial, f3dMat.rdp_settings, defaults, fModel.matWriteMethod, fModel.f3d.F3DEX_GBI_2)
1320+
fMaterial.mat_only_DL.commands.append(DPPipeSync())
13211321

13221322
# Checking for f3dMat.rdp_settings.g_lighting here will prevent accidental exports,
13231323
# There may be some edge case where this isn't desired.
@@ -1331,8 +1331,6 @@ def saveOrGetF3DMaterial(material, fModel, _obj, drawLayer, convertTextureData):
13311331
fLights = saveLightsDefinition(fModel, fMaterial, f3dMat, materialName + "_lights")
13321332
fMaterial.mat_only_DL.commands.extend([SPSetLights(fLights)])
13331333

1334-
fMaterial.mat_only_DL.commands.append(DPPipeSync())
1335-
13361334
if fMaterial.revert is not None:
13371335
fMaterial.revert.commands.append(DPPipeSync())
13381336

fast64_internal/hm64/mm/mm_f3d_writer.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1323,7 +1323,7 @@ def saveOrGetF3DMaterial(material, fModel, obj, drawLayer, convertTextureData):
13231323
useDict = all_combiner_uses(f3dMat)
13241324

13251325
defaults = create_or_get_world(bpy.context.scene).rdp_defaults
1326-
saveGeoModeDefinition(fMaterial, f3dMat.rdp_settings, defaults, fModel.matWriteMethod, fModel.f3d.F3DEX_GBI_2)
1326+
fMaterial.mat_only_DL.commands.append(DPPipeSync())
13271327

13281328
# Checking for f3dMat.rdp_settings.g_lighting here will prevent accidental exports,
13291329
# There may be some edge case where this isn't desired.
@@ -1337,7 +1337,6 @@ def saveOrGetF3DMaterial(material, fModel, obj, drawLayer, convertTextureData):
13371337
fLights = saveLightsDefinition(fModel, fMaterial, f3dMat, materialName + "_lights")
13381338
fMaterial.mat_only_DL.commands.extend([SPSetLights(fLights)])
13391339

1340-
fMaterial.mat_only_DL.commands.append(DPPipeSync())
13411340
fMaterial.revert.commands.append(DPPipeSync())
13421341

13431342
fMaterial.getScrollData(material, getMaterialScrollDimensions(f3dMat))
@@ -1386,6 +1385,8 @@ def saveOrGetF3DMaterial(material, fModel, obj, drawLayer, convertTextureData):
13861385
)
13871386
)
13881387

1388+
saveGeoModeDefinition(fMaterial, f3dMat.rdp_settings, defaults, fModel.matWriteMethod, fModel.f3d.F3DEX_GBI_2)
1389+
13891390
if f3dMat.set_ao:
13901391
fMaterial.mat_only_DL.commands.append(
13911392
SPAmbOcclusion(

0 commit comments

Comments
 (0)