Add "non-detached" signature support

[James-E-A]

It looks like PQClean adds an alternative "non-detached" signature mode

• https://github.com/PQClean/PQClean/blob/3b43bc6fe46fe47be38f87af5019a7f1462ae6dd/crypto_sign/dilithium3/clean/sign.c#L185
• https://github.com/PQClean/PQClean/blob/3b43bc6fe46fe47be38f87af5019a7f1462ae6dd/crypto_sign/falcon-512/clean/pqclean.c#L318
• https://github.com/PQClean/PQClean/blob/3b43bc6fe46fe47be38f87af5019a7f1462ae6dd/crypto_sign/sphincs-shake-128f-simple/clean/sign.c#L243

The API there looks a little weird

0. returns int indicating success/failure
1. uint8_t *sm which is a pre-allocated array of mlen + CRYPTO_BYTES bytes, which the result will be written into
2. size_t *smlen which is a pre-allocated pointer, which (*mlen) + siglen will be written into
   • This is, of course, only useful when siglen < CRYPTO_BYTES may occur, (i.e. variable-length signatures.)
3. const uint8_t *m, which is the array containing the message.
   • When sm == m, then I guess that allows big efficiency gains with memmove? (Does that mean we can reasonably deduce that the signature is always appended to the message?)
4. size_t mlen, which is, of course, the length of the message
5. const uint8_t sk[CRYPTO_SECRETKEYBYTES]

[James-E-A]

sign_attached is low priority, perhaps; it really does look like this is a pure "helper function" that does nothing special

int crypto_sign(uint8_t *sm, size_t *smlen,
                const uint8_t *m, size_t mlen,
                const uint8_t *sk) {
    size_t siglen;

    crypto_sign_signature(sm, &siglen, m, mlen, sk);

    memmove(sm + SPX_BYTES, m, mlen);
    *smlen = siglen + mlen;

    return 0;
}

However, I wonder if it could provide value in making an API for writing into a bytearray, cf. BufferedIOBase.readinto()?

Maybe not exactly the same, but using PyByteArray_Resize?

from pqc.sign import falcon_512 as sigalg

m = '\x00\x69MessageToBeSigned\x69\x00'

msigned = sigalg.sign_attached(m)
mbuf = bytearray(m); sigalg.sign_inplace(mbuf)

assert len(msigned) > len(m)
assert len(mbuf) > len(m)
sigalg.verify_attached(msigned)
sigalg.verify_attached(mbuf)