[Bug] Regression in 1.21.0

[ingalls]

Describe the bug

@JamesLMilner Seeing a regression in the recently released version when a feature is obtained and then removed.

The finish handling event is here:
https://github.com/dfpc-coe/CloudTAK/blob/main/api/web/src/stores/modules/draw.ts#L153-L270

But I've tracked down the error to the following TerraDraw call:
https://github.com/dfpc-coe/CloudTAK/blob/main/api/web/src/stores/modules/draw.ts#L411

The error appears to be thrown outside of the current scope as wrapping the call with

423         try {                                                                                                                                                                                                     
424         return this.draw.removeFeatures([id]);                                                                                                                                                                    
425         } catch (err) {                                                                                                                                                                                           
426         console.error('Error removing feature', err);                                                                                                                                                             
427         }   

does not capture the error and the error bubbles up to the generic error handler.

I've confirmed that 1.20.0 is unaffected and have pinned to that release.

error { target: Window, isTrusted: true, message: "Error: No feature with this id (f9ccb04a-7b2d-462d-be25-3ddfcc4b1c4e), can not get properties copy", filename: "http://localhost:8080/node_modules/.vite/deps/chunk-7SES3HDX.js?v=dc640590", lineno: 2597, colno: 20, error: Error, srcElement: Window, currentTarget: Window, eventPhase: 2, … }
​
bubbles: true
​
cancelBubble: false
​
cancelable: true
​
colno: 20
​
composed: false
​
currentTarget: null
​
defaultPrevented: true
​
error: Error: No feature with this id (f9ccb04a-7b2d-462d-be25-3ddfcc4b1c4e), can not get properties copy
​
eventPhase: 0
​
explicitOriginalTarget: <canvas class="maplibregl-canvas" tabindex="0" aria-label="Map" role="region" width="3456" height="1232" style="width: 1728px; height: 616px;">
​
filename: "http://localhost:8080/node_modules/.vite/deps/chunk-7SES3HDX.js?v=dc640590"
​
isTrusted: true
​
lineno: 2597
​
message: "Error: No feature with this id (f9ccb04a-7b2d-462d-be25-3ddfcc4b1c4e), can not get properties copy"
​
originalTarget: Window http://localhost:8080/#13.7/39.67975/-105.91259
​
returnValue: false
​
srcElement: Window http://localhost:8080/#13.7/39.67975/-105.91259
​
target: Window http://localhost:8080/#13.7/39.67975/-105.91259
​
timeStamp: 224260
​
type: "error"
​
<get isTrusted()>: function isTrusted()
​
<prototype>: ErrorEventPrototype { message: Getter, filename: Getter, lineno: Getter, … }

Terra Draw npm version
1.21.0

[JamesLMilner]

Hey @ingalls - sorry to hear that! There was quite a bit of refactoring to unlock future functionality in the latest release.

I'm just away from the computer at the moment, but is there some specific mode this is occurring for or is it all modes? If you have any additional context that might help debug that would be awesome!

[ingalls]

@JamesLMilner No worries, locking the dependency isn't a big deal. I was testing this specifically in LineString mode. I'm about to jump on an airplane back from Canada myself so I can test this is other modes tomorrow and see if it is a core issue or specific to the mode.

[JamesLMilner]

Thanks @ingalls! I've very briefly been trying to reproduce but not had much luck unfortunately. If you have any additional details that might help narrow it down that would be helpful. Potentially logging out the feature before it is deleted would help me understand what might be going on? I'm writing a suite of unit tests at the moment that tries to mimic this behaviour but all have been working as expected so far.

[JamesLMilner]

These are the tests I've been writing to try and trigger the issue, but no luck yet unfortunately: https://github.com/JamesLMilner/terra-draw/pull/760/files

[JamesLMilner]

I now have when I think is a speculative fix on that PR - it seems I can trigger that exact error if a delete feature that is currently being drawn and then continue to try and draw afterwards. The changes on that branch make it so that cleanup is called on the mode of the current drawn feature when removeFeatures is called. This resets the drawing state so as to not cause a corrupt drawing state when trying to draw after deletion of a feature that is midway through being drawn.

[JamesLMilner]

I was actually able to replicate the exact issue and now know the solution - it was related to what I was getting at in the above PR changes but a more specific case. I am incorporating it into a wider fix.