fix(core): handle specifiers like =9.0.0

Closes #239

Author: JamieMason

src/specifier.rs

@@ -484,7 +484,8 @@ impl Specifier {
 
     match self {
       Self::Exact(s) => {
-        let new_specifier = format!("{}{}", range_str, s.raw);
+        // Use node_version to get clean version without = prefix
+        let new_specifier = format!("{}{}", range_str, s.node_version);
         Some(Self::new(&new_specifier))
       }
       Self::Major(s) => {

src/specifier/exact.rs

@@ -16,11 +16,14 @@ pub struct Exact {
 
 impl Exact {
   pub fn create(raw: &str) -> Specifier {
-    match Specifier::new_node_version(raw) {
+    // Strip leading = if present (npm allows =1.2.3 as equivalent to 1.2.3)
+    let version_without_equals = raw.strip_prefix('=').unwrap_or(raw);
+
+    match Specifier::new_node_version(version_without_equals) {
       Some(node_version) => {
-        let node_range = Specifier::new_node_range(raw).unwrap_or_else(|| {
+        let node_range = Specifier::new_node_range(version_without_equals).unwrap_or_else(|| {
           // Fallback: should never happen if node_version parses
-          Rc::new(node_semver::Range::parse(raw).unwrap())
+          Rc::new(node_semver::Range::parse(version_without_equals).unwrap())
         });
         Specifier::Exact(Self {
           raw: raw.to_string(),

src/specifier/parser.rs

@@ -5,7 +5,10 @@ pub fn is_simple_semver(str: &str) -> bool {
 }
 
 pub fn is_exact(str: &str) -> bool {
-  regexes::EXACT.is_match(str) || regexes::EXACT_TAG.is_match(str)
+  regexes::EXACT.is_match(str)
+    || regexes::EXACT_TAG.is_match(str)
+    || regexes::EXACT_EQUALS.is_match(str)
+    || regexes::EXACT_EQUALS_TAG.is_match(str)
 }
 
 pub fn is_latest(str: &str) -> bool {

src/specifier/regexes.rs

@@ -7,6 +7,10 @@ lazy_static! {
   pub static ref EXACT: Regex = Regex::new(r"^[0-9]+\.[0-9]+\.[0-9]+$").unwrap();
   /// "1.2.3-alpha" || "1.2.3-rc.1"
   pub static ref EXACT_TAG: Regex = Regex::new(r"^[0-9]+\.[0-9]+\.[0-9]+\-[a-z0-9.-_]+$").unwrap();
+  /// "=1.2.3"
+  pub static ref EXACT_EQUALS: Regex = Regex::new(r"^=([0-9]+\.[0-9]+\.[0-9]+)$").unwrap();
+  /// "=1.2.3-alpha" || "=1.2.3-rc.1"
+  pub static ref EXACT_EQUALS_TAG: Regex = Regex::new(r"^=([0-9]+\.[0-9]+\.[0-9]+)\-[a-z0-9.-_]+$").unwrap();
   /// "^1.2.3"
   pub static ref CARET: Regex = Regex::new(r"^\^([0-9]+\.[0-9]+\.[0-9]+)$").unwrap();
   /// "^1.2.3-alpha" || "^1.2.3-rc.1"

src/specifier_test.rs

@@ -822,3 +822,35 @@ fn issue_213_git_tags_starting_with_v() {
     _ => panic!("Expected Git"),
   };
 }
+
+#[test]
+fn parses_equals_prefix_as_exact_version() {
+  // Test issue #239 - npm allows =X.Y.Z as equivalent to X.Y.Z
+  let spec = Specifier::new("=9.0.0");
+  match spec.as_ref() {
+    Specifier::Exact(actual) => {
+      assert_eq!(actual.raw, "=9.0.0");
+      assert_eq!(actual.node_version.major, 9);
+      assert_eq!(actual.node_version.minor, 0);
+      assert_eq!(actual.node_version.patch, 0);
+      assert_eq!(spec.get_semver_range(), Some(SemverRange::Exact));
+      assert_eq!(spec.get_node_version().unwrap().to_string(), "9.0.0");
+    }
+    _ => panic!("Expected Exact, got {:?}", spec),
+  }
+}
+
+#[test]
+fn parses_equals_prefix_with_prerelease() {
+  let spec = Specifier::new("=1.2.3-alpha.1");
+  match spec.as_ref() {
+    Specifier::Exact(actual) => {
+      assert_eq!(actual.raw, "=1.2.3-alpha.1");
+      assert_eq!(actual.node_version.major, 1);
+      assert_eq!(actual.node_version.minor, 2);
+      assert_eq!(actual.node_version.patch, 3);
+      assert_eq!(spec.get_semver_range(), Some(SemverRange::Exact));
+    }
+    _ => panic!("Expected Exact, got {:?}", spec),
+  }
+}

src/visit_packages/preferred_semver_test.rs

@@ -2028,4 +2028,83 @@ mod custom_types {
       },
     ]);
   }
+
+  #[test]
+  fn exact_version_with_equals_prefix_should_be_fixable_when_semver_group_requires_caret() {
+    // Reproduces issue #239
+    // User has semverGroups with range "^" but dependency uses =9.0.0 (npm's equals prefix)
+    // This should be marked as fixable (needs ^ prefix added)
+    let ctx = TestBuilder::new()
+      .with_packages(vec![json!({
+        "name": "pkg-a",
+        "version": "1.0.0",
+        "dependencies": {
+          "react": "=9.0.0"
+        }
+      })])
+      .with_config(json!({
+        "semverGroups": [{
+          "range": "^"
+        }]
+      }))
+      .build_and_visit_packages();
+
+    expect(&ctx).to_have_instances(vec![
+      ExpectedInstance {
+        state: InstanceState::valid(IsLocalAndValid),
+        dependency_name: "pkg-a",
+        id: "pkg-a in /version of pkg-a",
+        actual: "1.0.0",
+        expected: Some("1.0.0"),
+        overridden: None,
+      },
+      ExpectedInstance {
+        state: InstanceState::fixable(SemverRangeMismatch),
+        dependency_name: "react",
+        id: "react in /dependencies of pkg-a",
+        actual: "=9.0.0",
+        expected: Some("^9.0.0"),
+        overridden: None,
+      },
+    ]);
+  }
+
+  #[test]
+  fn exact_version_without_prefix_should_be_fixable_when_semver_group_requires_caret() {
+    // Also test plain exact versions like "9.0.0" (without =)
+    // These should also be flagged when semver group requires ^
+    let ctx = TestBuilder::new()
+      .with_packages(vec![json!({
+        "name": "pkg-a",
+        "version": "1.0.0",
+        "dependencies": {
+          "react": "9.0.0"
+        }
+      })])
+      .with_config(json!({
+        "semverGroups": [{
+          "range": "^"
+        }]
+      }))
+      .build_and_visit_packages();
+
+    expect(&ctx).to_have_instances(vec![
+      ExpectedInstance {
+        state: InstanceState::valid(IsLocalAndValid),
+        dependency_name: "pkg-a",
+        id: "pkg-a in /version of pkg-a",
+        actual: "1.0.0",
+        expected: Some("1.0.0"),
+        overridden: None,
+      },
+      ExpectedInstance {
+        state: InstanceState::fixable(SemverRangeMismatch),
+        dependency_name: "react",
+        id: "react in /dependencies of pkg-a",
+        actual: "9.0.0",
+        expected: Some("^9.0.0"),
+        overridden: None,
+      },
+    ]);
+  }
 }