feat(cli): read sources from lerna.json if present

Closes #11

Author: JamieMason

src/constants.ts

@@ -44,8 +44,8 @@ export const SEMVER_ORDER = [
 
 const DEFAULT_INDENT = '  ';
 const DEFAULT_SEMVER_RANGE = RANGE_EXACT;
-const MONOREPO_PATTERN = './package.json';
-const PACKAGES_PATTERN = './packages/*/package.json';
+const MONOREPO_PATTERN = 'package.json';
+const PACKAGES_PATTERN = 'packages/*/package.json';
 const ALL_PATTERNS = [MONOREPO_PATTERN, PACKAGES_PATTERN];
 
 export const FIX_MISMATCHES = {

src/fix-mismatches.ts

@@ -26,7 +26,7 @@ export const run = async (program: CommanderApi) => {
     .option(OPTION_INDENT.spec, OPTION_INDENT.description)
     .parse(process.argv);
 
-  const pkgs = await getPackages(program);
+  const pkgs = getPackages(program);
   const dependencyTypes = getDependencyTypes(program);
   const indent = getIndent(program);
   const mismatchedVersionsByName = getMismatchedVersionsByName(

src/format.ts

@@ -68,7 +68,7 @@ export const run = async (program: CommanderApi) => {
     .option(OPTION_INDENT.spec, OPTION_INDENT.description)
     .parse(process.argv);
 
-  const pkgs = await getPackages(program);
+  const pkgs = getPackages(program);
   const indent = getIndent(program);
 
   await Promise.all(

src/lib/get-packages.spec.ts

@@ -0,0 +1,48 @@
+import mock = require('mock-fs');
+import { resolve } from 'path';
+import { getMockCommander } from '../../test/helpers';
+import { getPackages } from './get-packages';
+import { removeSync } from 'fs-extra';
+
+describe('getPackages', () => {
+  afterEach(() => {
+    mock.restore();
+  });
+
+  beforeEach(() => {
+    mock({
+      'cli/a/package.json': JSON.stringify({ name: 'cli-a' }),
+      'cli/b/package.json': JSON.stringify({ name: 'cli-b' }),
+      'lerna.json': JSON.stringify({ packages: ['lerna/*'] }),
+      'lerna/a/package.json': JSON.stringify({ name: 'lerna-a' }),
+      'lerna/b/package.json': JSON.stringify({ name: 'lerna-b' }),
+      'packages/a/package.json': JSON.stringify({ name: 'packages-a' }),
+      'packages/b/package.json': JSON.stringify({ name: 'packages-b' })
+    });
+  });
+
+  it('prefers CLI', () => {
+    const program = getMockCommander(['cli/*/package.json']);
+    expect(getPackages(program)).toEqual([
+      { data: { name: 'cli-a' }, path: 'cli/a/package.json' },
+      { data: { name: 'cli-b' }, path: 'cli/b/package.json' }
+    ]);
+  });
+
+  it('falls back to lerna.json if present', () => {
+    const program = getMockCommander([]);
+    expect(getPackages(program)).toEqual([
+      { data: { name: 'lerna-a' }, path: 'lerna/a/package.json' },
+      { data: { name: 'lerna-b' }, path: 'lerna/b/package.json' }
+    ]);
+  });
+
+  it('resorts to defaults', () => {
+    const program = getMockCommander([]);
+    removeSync('lerna.json');
+    expect(getPackages(program)).toEqual([
+      { data: { name: 'packages-a' }, path: 'packages/a/package.json' },
+      { data: { name: 'packages-b' }, path: 'packages/b/package.json' }
+    ]);
+  });
+});

src/lib/get-packages.ts

@@ -1,19 +1,23 @@
-import fs = require('fs-extra');
+import { readJsonSync } from 'fs-extra';
 import globby = require('globby');
+import { join, resolve } from 'path';
 import { OPTION_SOURCES } from '../constants';
 import { CommanderApi, IManifestDescriptor } from '../typings';
 
-export const getSources = (program: CommanderApi): string[] =>
-  program.source && program.source.length
-    ? program.source
-    : OPTION_SOURCES.default;
+export const getSources = (program: CommanderApi): string[] => {
+  if (program.source && program.source.length) {
+    return program.source;
+  }
+  const lernaPath = resolve(process.cwd(), 'lerna.json');
+  const lerna = readJsonSync(lernaPath, { throws: false });
+  if (lerna && lerna.packages && lerna.packages.length) {
+    return lerna.packages.map((glob: string) => join(glob, 'package.json'));
+  }
+  return OPTION_SOURCES.default;
+};
 
-export const getPackages = async (
-  program: CommanderApi
-): Promise<IManifestDescriptor[]> =>
-  Promise.all(
-    (await globby(getSources(program))).map(async (filePath) => ({
-      data: await fs.readJSON(filePath),
-      path: filePath
-    }))
-  );
+export const getPackages = (program: CommanderApi): IManifestDescriptor[] =>
+  globby.sync(getSources(program)).map((filePath) => ({
+    data: readJsonSync(filePath),
+    path: filePath
+  }));

src/list-mismatches.ts

@@ -21,7 +21,7 @@ export const run = async (program: CommanderApi) => {
     .parse(process.argv);
 
   const dependencyTypes = getDependencyTypes(program);
-  const pkgs = await getPackages(program);
+  const pkgs = getPackages(program);
   const mismatchedVersionsByName = getMismatchedVersionsByName(
     dependencyTypes,
     pkgs

src/list.ts

@@ -21,7 +21,7 @@ export const run = async (program: CommanderApi) => {
     .parse(process.argv);
 
   const dependencyTypes = getDependencyTypes(program);
-  const pkgs = await getPackages(program);
+  const pkgs = getPackages(program);
   const versionsByName = getVersionsByName(dependencyTypes, pkgs);
 
   _.each(versionsByName, (versions, name) => {

src/set-semver-ranges.ts

@@ -33,7 +33,7 @@ export const run = async (program: CommanderApi) => {
   const semverRange: string =
     program.semverRange || OPTION_SEMVER_RANGE.default;
 
-  const pkgs = await getPackages(program);
+  const pkgs = getPackages(program);
   const dependencyTypes = getDependencyTypes(program);
   const indent = getIndent(program);