test(core): fix incomplete PartialEq for InstanceState

Author: JamieMason

src/instance_state.rs

@@ -90,7 +90,13 @@ impl InstanceState {
 
 impl PartialEq for InstanceState {
   fn eq(&self, other: &Self) -> bool {
-    self.cmp(other) == Ordering::Equal
+    match (self, other) {
+      (InstanceState::Unknown, InstanceState::Unknown) => true,
+      (InstanceState::Valid(a), InstanceState::Valid(b)) => a == b,
+      (InstanceState::Invalid(a), InstanceState::Invalid(b)) => a == b,
+      (InstanceState::Suspect(a), InstanceState::Suspect(b)) => a == b,
+      _ => false,
+    }
   }
 }
 

src/visit_packages/banned_test.rs

@@ -223,7 +223,7 @@ fn removes_instance_with_versions_by_name_strategy() {
       overridden: None,
     },
     ExpectedInstance {
-      state: InstanceState::valid(IsNonSemverButIdentical),
+      state: InstanceState::valid(IsHighestOrLowestSemver),
       dependency_name: "lodash",
       id: "lodash in /dependencies of package-a",
       actual: "4.17.21",

src/visit_packages/preferred_semver_test.rs

@@ -502,7 +502,7 @@ mod local {
         overridden: None,
       },
       ExpectedInstance {
-        state: InstanceState::valid(IsLocalAndValid),
+        state: InstanceState::valid(SatisfiesLocal),
         dependency_name: "package-a",
         id: "package-a in /dependencies of package-b",
         actual: "link:../package-a",