feat(core): ignore missing snapTo dependencies by default

Closes #173

Author: JamieMason

src/context.rs

@@ -88,6 +88,13 @@ impl Context {
       for instance in self.instances.iter() {
         match *instance.state.borrow() {
           InstanceState::Valid(_) => continue,
+          InstanceState::Suspect(_) => {
+            if self.config.rcfile.strict {
+              std::process::exit(1);
+            } else {
+              continue;
+            }
+          }
           _ => std::process::exit(1),
         }
       }

src/effects/fix.rs

@@ -62,6 +62,7 @@ pub fn run(ctx: Context) -> Context {
         },
         InstanceState::Suspect(variant) => match variant {
           SuspectInstance::RefuseToBanLocal
+          | SuspectInstance::DependsOnMissingSnapTarget
           | SuspectInstance::RefuseToPinLocal
           | SuspectInstance::RefuseToSnapLocal
           | SuspectInstance::InvalidLocalVersion => {

src/effects/ui.rs

@@ -168,9 +168,6 @@ impl Ui<'_> {
               UnfixableInstance::SameRangeMismatch => {
                 info!("{count} {icon} {name} {state_links}");
               }
-              UnfixableInstance::DependsOnMissingSnapTarget => {
-                info!("{count} {icon} {name} {state_links}");
-              }
             }
           }
           InvalidInstance::Conflict(variant) => {
@@ -201,6 +198,9 @@ impl Ui<'_> {
       InstanceState::Suspect(variant) => {
         let icon = self.warn_icon();
         match variant {
+          SuspectInstance::DependsOnMissingSnapTarget => {
+            info!("{count} {icon} {name} {state_links}");
+          }
           SuspectInstance::RefuseToBanLocal => {
             info!("{count} {icon} {name} {state_links}");
           }
@@ -332,9 +332,6 @@ impl Ui<'_> {
             UnfixableInstance::SameRangeMismatch => {
               info!("          {icon} {actual} {location} {state_link}");
             }
-            UnfixableInstance::DependsOnMissingSnapTarget => {
-              info!("          {icon} {actual} {location} {state_link}");
-            }
           },
           InvalidInstance::Conflict(variant) => match variant {
             SemverGroupAndVersionConflict::MatchConflictsWithHighestOrLowestSemver => {
@@ -361,6 +358,9 @@ impl Ui<'_> {
       InstanceState::Suspect(variant) => {
         let icon = self.warn_icon();
         match variant {
+          SuspectInstance::DependsOnMissingSnapTarget => {
+            info!("          {icon} {actual} {location} {state_link}");
+          }
           SuspectInstance::RefuseToBanLocal => {
             info!("          {icon} {actual} {location} {state_link}");
           }

src/instance_state.rs

@@ -169,11 +169,6 @@ pub enum UnfixableInstance {
   /// - ? Instance has no semver group
   /// - ? We can't know what range the user wants and have to ask them
   SameRangeMismatch,
-  /// - ✓ Instance is in a snapped to version group
-  /// - ✘ An instance of the same dependency was not found in any of the snapped
-  ///   to packages
-  /// - ✘ This is a misconfiguration resulting in this instance being orphaned
-  DependsOnMissingSnapTarget,
 }
 
 #[derive(Clone, Debug, Eq, Hash, PartialEq)]
@@ -238,4 +233,9 @@ pub enum SuspectInstance {
   /// - ! Local Instance has no version property
   /// - ! Not an error on its own unless an instance of it mismatches
   InvalidLocalVersion,
+  /// - ✓ Instance is in a snapped to version group
+  /// - ✘ An instance of the same dependency was not found in any of the snapped
+  ///   to packages
+  /// - ! This is a misconfiguration resulting in this instance being orphaned
+  DependsOnMissingSnapTarget,
 }

src/visit_packages.rs

@@ -381,7 +381,7 @@ pub fn visit_packages(ctx: Context) -> Context {
             } else {
               debug!("    no target version was found");
               dependency.instances.borrow().iter().for_each(|instance| {
-                instance.mark_unfixable(DependsOnMissingSnapTarget);
+                instance.mark_suspect(DependsOnMissingSnapTarget);
               });
             }
           }

src/visit_packages_test.rs

@@ -2495,7 +2495,7 @@ fn instance_cannot_find_a_snapped_to_version() {
       overridden: None,
     },
     ExpectedInstance {
-      state: InstanceState::unfixable(DependsOnMissingSnapTarget),
+      state: InstanceState::suspect(DependsOnMissingSnapTarget),
       dependency_name: "foo",
       id: "foo in /dependencies of follower",
       actual: "1.0.0",