refactor(core): remove #![allow(unused_variables)]

Author: JamieMason

src/effects/ui/dependency.rs

@@ -134,7 +134,7 @@ fn get_invalid_status_codes_in_brackets(ctx: &Context, dependency: &Dependency)
 fn get_common_parts(
   ctx: &Context,
   dependency: &Dependency,
-  group_variant: &VersionGroupVariant,
+  _group_variant: &VersionGroupVariant,
 ) -> (String, String, String, String, String, String) {
   let instances_len = dependency.instances.len();
   let count_column = ui::util::count_column(instances_len);

src/effects/ui/group.rs

@@ -4,7 +4,7 @@ use {
   log::info,
 };
 
-pub fn print_header(ctx: &Context, group: &VersionGroup) {
+pub fn print_header(_ctx: &Context, group: &VersionGroup) {
   let print_width = 80;
   let label = &group.selector.label;
   let header = format!("= {label} ");

src/main.rs

@@ -1,5 +1,3 @@
-#![allow(unused_variables)]
-
 use {
   crate::{
     cli::{Cli, Subcommand},

src/specifier_test.rs

@@ -788,35 +788,33 @@ fn satisfies_all() {
 
 #[test]
 fn issue_213_git_tags_starting_with_v() {
-  for git_url in git_urls() {
-    let value = "github:uNetworking/uWebSockets.js#v20.43.0";
-    match Specifier::new(value, None) {
-      Specifier::Git(actual) => {
-        assert_eq!(actual.raw, value);
-        assert_eq!(actual.origin, "github:uNetworking/uWebSockets.js");
-        let semver = actual.semver.as_ref().unwrap();
-        assert_eq!(semver.raw, "20.43.0");
-        assert_eq!(semver.variant, BasicSemverVariant::Patch);
-        assert_eq!(semver.range_variant, SemverRange::Exact);
-        assert_eq!(semver.node_version.major, 20);
-        assert_eq!(semver.node_version.minor, 43);
-        assert_eq!(semver.node_version.patch, 0);
-        assert!(semver.node_version.pre_release.is_empty());
+  let value = "github:uNetworking/uWebSockets.js#v20.43.0";
+  match Specifier::new(value, None) {
+    Specifier::Git(actual) => {
+      assert_eq!(actual.raw, value);
+      assert_eq!(actual.origin, "github:uNetworking/uWebSockets.js");
+      let semver = actual.semver.as_ref().unwrap();
+      assert_eq!(semver.raw, "20.43.0");
+      assert_eq!(semver.variant, BasicSemverVariant::Patch);
+      assert_eq!(semver.range_variant, SemverRange::Exact);
+      assert_eq!(semver.node_version.major, 20);
+      assert_eq!(semver.node_version.minor, 43);
+      assert_eq!(semver.node_version.patch, 0);
+      assert!(semver.node_version.pre_release.is_empty());
 
-        let next_semver = BasicSemver::new("1.2.3").unwrap();
-        let edited = actual.with_semver(&next_semver);
-        assert_eq!(edited.raw, "github:uNetworking/uWebSockets.js#v1.2.3");
-        assert_eq!(edited.origin, "github:uNetworking/uWebSockets.js");
-        let semver = edited.semver.unwrap();
-        assert_eq!(semver.raw, "1.2.3");
-        assert_eq!(semver.variant, BasicSemverVariant::Patch);
-        assert_eq!(semver.range_variant, SemverRange::Exact);
-        assert_eq!(semver.node_version.major, 1);
-        assert_eq!(semver.node_version.minor, 2);
-        assert_eq!(semver.node_version.patch, 3);
-        assert!(semver.node_version.pre_release.is_empty());
-      }
-      _ => panic!("Expected Git"),
-    };
-  }
+      let next_semver = BasicSemver::new("1.2.3").unwrap();
+      let edited = actual.with_semver(&next_semver);
+      assert_eq!(edited.raw, "github:uNetworking/uWebSockets.js#v1.2.3");
+      assert_eq!(edited.origin, "github:uNetworking/uWebSockets.js");
+      let semver = edited.semver.unwrap();
+      assert_eq!(semver.raw, "1.2.3");
+      assert_eq!(semver.variant, BasicSemverVariant::Patch);
+      assert_eq!(semver.range_variant, SemverRange::Exact);
+      assert_eq!(semver.node_version.major, 1);
+      assert_eq!(semver.node_version.minor, 2);
+      assert_eq!(semver.node_version.patch, 3);
+      assert!(semver.node_version.pre_release.is_empty());
+    }
+    _ => panic!("Expected Git"),
+  };
 }