[BUG] - Downloads with a non "OK" response are not properly handled

[sciencewhiz]

Describe the bug
Thrifty Config doesn't download. It stays at 0%

** CSA USB Tool Version**

• 2025.1.0

To Reproduce
Steps to reproduce the behavior:

1. Select CSA Tab
2. Scroll down and click on Thrifty Config
3. Click on Download
4. Stays at 0% and doesn't download

Stack Trace
None

Expected behavior
Thrifty Config to download

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows
• OS Version: 11 25H2 (26200)
• .NET Version not sure, I have multiple runtimes installed. Latest is 10.0.3

Additional context
All other files have downloaded succesfully. I double checked the md5sum. I suspect it has to do with the + in the file name, but won't have time to debug for a while.

[JamieSinn]

82b448d

This should help, URLEncoding it might fix it

[sciencewhiz]

That commit doesn't appear to have fixed it.

[JamieSinn]

This looks like it's a bit more weird - as I can manually download this via the httpclient but not via the app.

For now I'm not immensely worried - but I would probably see if you can poke Thrifty to see how their download site works and if this can be fixed on their side too.

[sciencewhiz]

It looks like cloudflare is returning 403

[JamieSinn]

Yeah - definitely likely that this is a Thrifty side issue then. I'll leave this open for triage and update the title.